2022-01-11 11:45:38

by Pawel Laszczak

Subject: [PATCH] usb: cdnsp: remove not used temp_64 variables

From: Pawel Laszczak <[email protected]>

Patch removes initialized but not used variables temp_64
from cdnsp_run function.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Pawel Laszczak <[email protected]>
---
drivers/usb/cdns3/cdnsp-gadget.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/usb/cdns3/cdnsp-gadget.c b/drivers/usb/cdns3/cdnsp-gadget.c
index 27df0c697897..ec8a0dc792bc 100644
--- a/drivers/usb/cdns3/cdnsp-gadget.c
+++ b/drivers/usb/cdns3/cdnsp-gadget.c
@@ -1243,12 +1243,9 @@ static int cdnsp_run(struct cdnsp_device *pdev,
enum usb_device_speed speed)
{
u32 fs_speed = 0;
- u64 temp_64;
u32 temp;
int ret;

- temp_64 = cdnsp_read_64(&pdev->ir_set->erst_dequeue);
- temp_64 &= ~ERST_PTR_MASK;
temp = readl(&pdev->ir_set->irq_control);
temp &= ~IMOD_INTERVAL_MASK;
temp |= ((IMOD_DEFAULT_INTERVAL / 250) & IMOD_INTERVAL_MASK);
--
2.25.1

2022-01-12 13:02:14

by Peter Chen

Subject: Re: [PATCH] usb: cdnsp: remove not used temp_64 variables

On 22-01-11 12:44:49, Pawel Laszczak wrote:
> From: Pawel Laszczak <[email protected]>
>
> Patch removes initialized but not used variables temp_64
> from cdnsp_run function.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Pawel Laszczak <[email protected]>

Reviewed-by: Peter Chen <[email protected]>

> ---
> drivers/usb/cdns3/cdnsp-gadget.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/cdns3/cdnsp-gadget.c b/drivers/usb/cdns3/cdnsp-gadget.c
> index 27df0c697897..ec8a0dc792bc 100644
> --- a/drivers/usb/cdns3/cdnsp-gadget.c
> +++ b/drivers/usb/cdns3/cdnsp-gadget.c
> @@ -1243,12 +1243,9 @@ static int cdnsp_run(struct cdnsp_device *pdev,
> enum usb_device_speed speed)
> {
> u32 fs_speed = 0;
> - u64 temp_64;
> u32 temp;
> int ret;
>
> - temp_64 = cdnsp_read_64(&pdev->ir_set->erst_dequeue);
> - temp_64 &= ~ERST_PTR_MASK;
> temp = readl(&pdev->ir_set->irq_control);
> temp &= ~IMOD_INTERVAL_MASK;
> temp |= ((IMOD_DEFAULT_INTERVAL / 250) & IMOD_INTERVAL_MASK);
> --
> 2.25.1
>

--

Thanks,
Peter Chen