2022-01-13 16:20:15

by Jiapeng Chong

Subject: [PATCH] io_uring: Remove unused function req_ref_put

Fix the following clang warnings:

fs/io_uring.c:1195:20: warning: unused function 'req_ref_put'
[-Wunused-function].

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
fs/io_uring.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index de9c9de90655..fa3277844d2e 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -1192,12 +1192,6 @@ static inline bool req_ref_put_and_test(struct io_kiocb *req)
return atomic_dec_and_test(&req->refs);
}

-static inline void req_ref_put(struct io_kiocb *req)
-{
- WARN_ON_ONCE(!(req->flags & REQ_F_REFCOUNT));
- WARN_ON_ONCE(req_ref_put_and_test(req));
-}
-
static inline void req_ref_get(struct io_kiocb *req)
{
WARN_ON_ONCE(!(req->flags & REQ_F_REFCOUNT));
--
2.20.1.7.g153144c

2022-01-13 19:44:35

by Jens Axboe

Subject: Re: [PATCH] io_uring: Remove unused function req_ref_put

On 1/13/22 9:20 AM, Jiapeng Chong wrote:
> Fix the following clang warnings:
>
> fs/io_uring.c:1195:20: warning: unused function 'req_ref_put'
> [-Wunused-function].
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

This was introduced by:

aa43477b0402 ("io_uring: poll rework")

so I added a Fixes line for that. Applied, thanks.

--
Jens Axboe