2022-01-14 04:24:49

by Xiaoke Wang

Subject: [PATCHv2] integrity: check the return value of audit_log_start()

From: Xiaoke Wang <[email protected]>

audit_log_start() returns audit_buffer pointer on success or NULL on
error, so it is better to check the return value of it.

Signed-off-by: Xiaoke Wang <[email protected]>
---
Changelogs: simplify the patch.
Note: Take the suggestion from Paul Moore.
security/integrity/integrity_audit.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/security/integrity/integrity_audit.c b/security/integrity/integrity_audit.c
index 2922005..0ec5e4c 100644
--- a/security/integrity/integrity_audit.c
+++ b/security/integrity/integrity_audit.c
@@ -45,6 +45,8 @@ void integrity_audit_message(int audit_msgno, struct inode *inode,
return;

ab = audit_log_start(audit_context(), GFP_KERNEL, audit_msgno);
+ if (!ab)
+ return;
audit_log_format(ab, "pid=%d uid=%u auid=%u ses=%u",
task_pid_nr(current),
from_kuid(&init_user_ns, current_uid()),
--

2022-01-14 23:13:07

by Paul Moore

Subject: Re: [PATCHv2] integrity: check the return value of audit_log_start()

On Thu, Jan 13, 2022 at 11:24 PM <[email protected]> wrote:
>
> From: Xiaoke Wang <[email protected]>
>
> audit_log_start() returns audit_buffer pointer on success or NULL on
> error, so it is better to check the return value of it.
>
> Signed-off-by: Xiaoke Wang <[email protected]>

Reviewed-by: Paul Moore <[email protected]>

> ---
> Changelogs: simplify the patch.
> Note: Take the suggestion from Paul Moore.
> security/integrity/integrity_audit.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/security/integrity/integrity_audit.c b/security/integrity/integrity_audit.c
> index 2922005..0ec5e4c 100644
> --- a/security/integrity/integrity_audit.c
> +++ b/security/integrity/integrity_audit.c
> @@ -45,6 +45,8 @@ void integrity_audit_message(int audit_msgno, struct inode *inode,
> return;
>
> ab = audit_log_start(audit_context(), GFP_KERNEL, audit_msgno);
> + if (!ab)
> + return;
> audit_log_format(ab, "pid=%d uid=%u auid=%u ses=%u",
> task_pid_nr(current),
> from_kuid(&init_user_ns, current_uid()),
> --

--
paul moore
http://www.paul-moore.com