2022-01-21 13:57:31

by Rob Herring (Arm)

[permalink] [raw]

Subject: [PATCH] dt-bindings: Drop unnecessary pinctrl properties

---

For a single pinctrl mode, it is not necessary to define pinctrl
properties as the tools always allow pinctrl properties.

Signed-off-by: Rob Herring <[email protected]>
---
.../display/rockchip/rockchip,rk3066-hdmi.yaml | 8 --------
Documentation/devicetree/bindings/input/gpio-keys.yaml | 6 ------
.../devicetree/bindings/pinctrl/cirrus,lochnagar.yaml | 9 ---------
.../devicetree/bindings/pinctrl/cirrus,madera.yaml | 10 ----------
.../devicetree/bindings/sound/samsung-i2s.yaml | 6 ------
5 files changed, 39 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3066-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3066-hdmi.yaml
index 008c144257cb..1a68a940d165 100644
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3066-hdmi.yaml
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3066-hdmi.yaml
@@ -26,14 +26,6 @@ properties:
clock-names:
const: hclk

- pinctrl-0:
- maxItems: 2
-
- pinctrl-names:
- const: default
- description:
- Switch the iomux for the HPD/I2C pins to HDMI function.
-
power-domains:
maxItems: 1

diff --git a/Documentation/devicetree/bindings/input/gpio-keys.yaml b/Documentation/devicetree/bindings/input/gpio-keys.yaml
index dbe7ecc19ccb..7fe1966ea28a 100644
--- a/Documentation/devicetree/bindings/input/gpio-keys.yaml
+++ b/Documentation/devicetree/bindings/input/gpio-keys.yaml
@@ -88,12 +88,6 @@ patternProperties:
which can be disabled to suppress events from the button.
type: boolean

- pinctrl-0:
- maxItems: 1
-
- pinctrl-names:
- maxItems: 1
-
required:
- linux,code

diff --git a/Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml b/Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml
index 80020539c3bb..5cd512b7d5ba 100644
--- a/Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml
@@ -51,15 +51,6 @@ properties:
appropriate of the LOCHNAGARx_PIN_NUM_GPIOS define, see [3].
maxItems: 1

- pinctrl-0:
- description:
- A phandle to the default pinctrl state.
-
- pinctrl-names:
- description:
- A pinctrl state named "default" must be defined.
- const: default
-
pin-settings:
type: object
patternProperties:
diff --git a/Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml b/Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml
index e50d7ad5c229..c85f759ae5a3 100644
--- a/Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/cirrus,madera.yaml
@@ -30,16 +30,6 @@ description: |
Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt

properties:
- pinctrl-0:
- description:
- A phandle to the node containing the subnodes containing default
- configurations.
-
- pinctrl-names:
- description:
- A pinctrl state named "default" must be defined.
- const: default
-
pin-settings:
description:
One subnode is required to contain the default settings. It
diff --git a/Documentation/devicetree/bindings/sound/samsung-i2s.yaml b/Documentation/devicetree/bindings/sound/samsung-i2s.yaml
index 2e3628ef48df..84c4d6cba521 100644
--- a/Documentation/devicetree/bindings/sound/samsung-i2s.yaml
+++ b/Documentation/devicetree/bindings/sound/samsung-i2s.yaml
@@ -110,12 +110,6 @@ properties:
Internal DMA register base address of the audio
subsystem (used in secondary sound source).

- pinctrl-0:
- description: Should specify pin control groups used for this controller.
-
- pinctrl-names:
- const: default
-
power-domains:
maxItems: 1

--
2.32.0

2022-01-21 18:34:48

by Krzysztof Kozlowski

[permalink] [raw]

Subject: Re: [PATCH] dt-bindings: Drop unnecessary pinctrl properties

---

On 19/01/2022 02:53, Rob Herring wrote:
> For a single pinctrl mode, it is not necessary to define pinctrl
> properties as the tools always allow pinctrl properties.
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> .../display/rockchip/rockchip,rk3066-hdmi.yaml | 8 --------
> Documentation/devicetree/bindings/input/gpio-keys.yaml | 6 ------
> .../devicetree/bindings/pinctrl/cirrus,lochnagar.yaml | 9 ---------
> .../devicetree/bindings/pinctrl/cirrus,madera.yaml | 10 ----------
> .../devicetree/bindings/sound/samsung-i2s.yaml | 6 ------
> 5 files changed, 39 deletions(-)
>


Acked-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-01-21 19:11:02

by Charles Keepax

[permalink] [raw]

Subject: Re: [PATCH] dt-bindings: Drop unnecessary pinctrl properties

---

On Tue, Jan 18, 2022 at 07:53:25PM -0600, Rob Herring wrote:
> For a single pinctrl mode, it is not necessary to define pinctrl
> properties as the tools always allow pinctrl properties.
>
> Signed-off-by: Rob Herring <[email protected]>
> ---

Acked-by: Charles Keepax <[email protected]>

Thanks,
Charles

2022-01-21 19:49:35

by Mark Brown

[permalink] [raw]

Subject: Re: [PATCH] dt-bindings: Drop unnecessary pinctrl properties

---

On Tue, Jan 18, 2022 at 07:53:25PM -0600, Rob Herring wrote:
> For a single pinctrl mode, it is not necessary to define pinctrl
> properties as the tools always allow pinctrl properties.

Acked-by: Mark Brown <[email protected]>

---

Attachments:

(No filename) (235.00 B)
signature.asc (499.00 B)
Download all attachments

2022-01-21 22:27:49

by Rob Herring (Arm)

[permalink] [raw]

Subject: Re: [PATCH] dt-bindings: Drop unnecessary pinctrl properties

---

On Tue, 18 Jan 2022 19:53:25 -0600, Rob Herring wrote:
> For a single pinctrl mode, it is not necessary to define pinctrl
> properties as the tools always allow pinctrl properties.
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> .../display/rockchip/rockchip,rk3066-hdmi.yaml | 8 --------
> Documentation/devicetree/bindings/input/gpio-keys.yaml | 6 ------
> .../devicetree/bindings/pinctrl/cirrus,lochnagar.yaml | 9 ---------
> .../devicetree/bindings/pinctrl/cirrus,madera.yaml | 10 ----------
> .../devicetree/bindings/sound/samsung-i2s.yaml | 6 ------
> 5 files changed, 39 deletions(-)
>

Applied, thanks!