2022-02-07 01:24:05

by Horatiu Vultur

Subject: [PATCH 1/2] dt-bindings: pinctrl: pinctrl-microchip-sgpio: Fix example

The blamed commit adds support for irq, but the reqisters for irq are
outside of the memory size. They are at address 0x108. Therefore update
the memory size to cover all the registers used by the device.

Fixes: 01a9350bdd49fb ("dt-bindings: pinctrl: pinctrl-microchip-sgpio: Add irq support")
Signed-off-by: Horatiu Vultur <[email protected]>
---
.../devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml b/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml
index cb554084bdf1..0df4e114fdd6 100644
--- a/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml
@@ -145,7 +145,7 @@ examples:
clocks = <&sys_clk>;
pinctrl-0 = <&sgpio2_pins>;
pinctrl-names = "default";
- reg = <0x1101059c 0x100>;
+ reg = <0x1101059c 0x118>;
microchip,sgpio-port-ranges = <0 0>, <16 18>, <28 31>;
bus-frequency = <25000000>;
sgpio_in2: gpio@0 {
--
2.33.0

2022-02-11 09:56:48

by Linus Walleij

Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: pinctrl-microchip-sgpio: Fix example

On Fri, Feb 4, 2022 at 4:33 PM Horatiu Vultur
<[email protected]> wrote:

> The blamed commit adds support for irq, but the reqisters for irq are
> outside of the memory size. They are at address 0x108. Therefore update
> the memory size to cover all the registers used by the device.
>
> Fixes: 01a9350bdd49fb ("dt-bindings: pinctrl: pinctrl-microchip-sgpio: Add irq support")
> Signed-off-by: Horatiu Vultur <[email protected]>

This patch (1) applied to the pinctrl tree.

Yours,
Linus Walleij