2000-11-17 05:46:44

by Frank Davis

[permalink] [raw]
Subject: 2.4.0-test11-pre6 ntfs compile error

Hello,
I just try to compile 2.4.0-test11-pre6, and received the following error (make modules):

inode.c:1054 conflicting types for 'new_inode'
/usr/src/liunux/include/linux/fs.h:1153 previous declaration of 'new_inode'

make[2]: ***[inode.o]Error 1
make[2]: Leaving directory '/usr/src/liunux/fs/ntfs'
...
make[1]: *** [modsubdir_ntfs] Error 2

Regards,
Frank



2000-11-17 06:09:12

by Alexander Viro

[permalink] [raw]
Subject: Re: 2.4.0-test11-pre6 ntfs compile error



On Fri, 17 Nov 2000, Frank Davis wrote:

> Hello,
> I just try to compile 2.4.0-test11-pre6, and received the following error (make modules):
>
> inode.c:1054 conflicting types for 'new_inode'
> /usr/src/liunux/include/linux/fs.h:1153 previous declaration of 'new_inode'

My fault. Hell knows how that part of patch didn't get into the posting
(damnit, it was described there)...

Fix:

ed fs/ntfs/inode.c <<EOF
%s/new_inode/ntfs_&/g
w
q
EOF

2000-11-17 10:53:36

by Anton Altaparmakov

[permalink] [raw]
Subject: Re: 2.4.0-test11-pre6 ntfs compile error

At 05:38 17/11/2000, Alexander Viro wrote:
>On Fri, 17 Nov 2000, Frank Davis wrote:
> > Hello,
> > I just try to compile 2.4.0-test11-pre6, and received the following
> error (make modules):
> >
> > inode.c:1054 conflicting types for 'new_inode'
> > /usr/src/liunux/include/linux/fs.h:1153 previous declaration of 'new_inode'
>
>My fault. Hell knows how that part of patch didn't get into the posting
>(damnit, it was described there)...
>
>Fix:
>
>ed fs/ntfs/inode.c <<EOF
>%s/new_inode/ntfs_&/g
>w
>q
>EOF

Not fix enough, I am afraid. You are forgetting fs/ntfs/fs.c. - See the
patch I just posted.

Anton


--
"Education is what remains after one has forgotten everything he
learned in school." - Albert Einstein
--
Anton Altaparmakov Voice: +44-(0)1223-333541(lab) / +44-(0)7712-632205(mobile)
Christ's College eMail: [email protected] / [email protected]
Cambridge CB2 3BU ICQ: 8561279
United Kingdom WWW: http://www-stu.christs.cam.ac.uk/~aia21/

2000-11-17 11:04:39

by Anton Altaparmakov

[permalink] [raw]
Subject: Re: 2.4.0-test11-pre6 ntfs compile error

At 10:23 17/11/2000, Anton Altaparmakov wrote:
>At 05:38 17/11/2000, Alexander Viro wrote:
>>On Fri, 17 Nov 2000, Frank Davis wrote:
>> > Hello,
>> > I just try to compile 2.4.0-test11-pre6, and received the following
>> error (make modules):
>> >
>> > inode.c:1054 conflicting types for 'new_inode'
>> > /usr/src/liunux/include/linux/fs.h:1153 previous declaration of
>> 'new_inode'
>>
>>My fault. Hell knows how that part of patch didn't get into the posting
>>(damnit, it was described there)...
>>
>>Fix:
>>
>>ed fs/ntfs/inode.c <<EOF
>>%s/new_inode/ntfs_&/g
>>w
>>q
>>EOF
>
>Not fix enough, I am afraid. You are forgetting fs/ntfs/fs.c. - See the
>patch I just posted.

Oops. My fault. I was wrong. Your patch is of course correct! fs/ntfs/fs.c
wants the real new_inode...

Apologies,

Anton


--
"Education is what remains after one has forgotten everything he
learned in school." - Albert Einstein
--
Anton Altaparmakov Voice: +44-(0)1223-333541(lab) / +44-(0)7712-632205(mobile)
Christ's College eMail: [email protected] / [email protected]
Cambridge CB2 3BU ICQ: 8561279
United Kingdom WWW: http://www-stu.christs.cam.ac.uk/~aia21/