2022-03-21 22:30:12

by Alexandre Belloni

Subject: [PATCH] clk: sunxi-ng: sun6i-rtc: include clk/sunxi-ng.h

This solves:
>> drivers/clk/sunxi-ng/ccu-sun6i-rtc.c:334:5: warning: no previous prototype for 'sun6i_rtc_ccu_probe' [-Wmissing-prototypes]
334 | int sun6i_rtc_ccu_probe(struct device *dev, void __iomem *reg)
| ^~~~~~~~~~~~~~~~~~~

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Alexandre Belloni <[email protected]>
---
drivers/clk/sunxi-ng/ccu-sun6i-rtc.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
index 712fda22efd5..8a10bade7e0d 100644
--- a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
+++ b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
@@ -9,6 +9,8 @@
#include <linux/module.h>
#include <linux/of_device.h>

+#include <linux/clk/sunxi-ng.h>
+
#include "ccu_common.h"

#include "ccu_div.h"
--
2.35.1

2022-03-21 22:42:11

by Jernej Škrabec

Subject: Re: [PATCH] clk: sunxi-ng: sun6i-rtc: include clk/sunxi-ng.h

Dne nedelja, 20. marec 2022 ob 22:09:04 CET je Alexandre Belloni napisal(a):
> This solves:
> >> drivers/clk/sunxi-ng/ccu-sun6i-rtc.c:334:5: warning: no previous
> >> prototype for 'sun6i_rtc_ccu_probe' [-Wmissing-prototypes]
> 334 | int sun6i_rtc_ccu_probe(struct device *dev, void __iomem *reg)
>
> | ^~~~~~~~~~~~~~~~~~~
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Alexandre Belloni <[email protected]>

Acked-by: Jernej Skrabec <[email protected]>

Best regards,
Jernej

> ---
> drivers/clk/sunxi-ng/ccu-sun6i-rtc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
> b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c index 712fda22efd5..8a10bade7e0d
> 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
> @@ -9,6 +9,8 @@
> #include <linux/module.h>
> #include <linux/of_device.h>
>
> +#include <linux/clk/sunxi-ng.h>
> +
> #include "ccu_common.h"
>
> #include "ccu_div.h"