2022-03-31 05:04:18

by Mathieu Desnoyers

[permalink] [raw]
Subject: [PATCH] tracing: do not export user_events uapi

In addition to mark the USER_EVENTS feature BROKEN until all interested
parties figure out the user-space API, do not install the uapi header.

This prevents situations where a non-final uapi header would end up
being installed into a distribution image and used to build user-space
programs that would then run against newer kernels that will implement
user events with a different ABI.

Link: https://lore.kernel.org/all/[email protected]

Signed-off-by: Mathieu Desnoyers <[email protected]>
---
include/uapi/Kbuild | 3 +++
1 file changed, 3 insertions(+)

diff --git a/include/uapi/Kbuild b/include/uapi/Kbuild
index 61ee6e59c930..425ea8769ddc 100644
--- a/include/uapi/Kbuild
+++ b/include/uapi/Kbuild
@@ -12,3 +12,6 @@ ifeq ($(wildcard $(objtree)/arch/$(SRCARCH)/include/generated/uapi/asm/kvm_para.
no-export-headers += linux/kvm_para.h
endif
endif
+
+# API is not finalized
+no-export-headers += linux/user_events.h
--
2.20.1


2022-03-31 20:36:11

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH] tracing: do not export user_events uapi

On Thu, 31 Mar 2022 23:41:34 +0900
Masahiro Yamada <[email protected]> wrote:

> Either 1 or 2 is OK
> if you are sure this will be fixed sooner or later.

Thanks,

Then I'll go and pull in Mathieu's patch.

I want this done too, and I believe Beau has a vested interest to get this
correctly done as well, thus it should be worked on and hopefully we will
have something solid by the next merge window.

-- Steve