Hi All,
This patch series adds trivial fixes to renesas mmc driver.
Cheers,
Prabhakar
Lad Prabhakar (2):
mmc: renesas_sdhi: Jump to error path instead of returning directly
mmc: renesas_internal_dmac: Fix typo's
drivers/mmc/host/renesas_sdhi_core.c | 6 ++++--
drivers/mmc/host/renesas_sdhi_internal_dmac.c | 4 ++--
2 files changed, 6 insertions(+), 4 deletions(-)
--
2.17.1
Jump to error path "edisclk" instead of returning directly in case of
devm_reset_control_get_optional_exclusive() failure.
Fixes: b4d86f37eacb7 ("mmc: renesas_sdhi: do hard reset if possible")
Reported-by: Pavel Machek <[email protected]>
Signed-off-by: Lad Prabhakar <[email protected]>
---
drivers/mmc/host/renesas_sdhi_core.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
index 2797a9c0f17d..cddb0185f5fb 100644
--- a/drivers/mmc/host/renesas_sdhi_core.c
+++ b/drivers/mmc/host/renesas_sdhi_core.c
@@ -1033,8 +1033,10 @@ int renesas_sdhi_probe(struct platform_device *pdev,
goto efree;
priv->rstc = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL);
- if (IS_ERR(priv->rstc))
- return PTR_ERR(priv->rstc);
+ if (IS_ERR(priv->rstc)) {
+ ret = PTR_ERR(priv->rstc);
+ goto edisclk;
+ }
ver = sd_ctrl_read16(host, CTL_VERSION);
/* GEN2_SDR104 is first known SDHI to use 32bit block count */
--
2.17.1
> This patch series adds trivial fixes to renesas mmc driver.
Did I miss if there is anything left to discuss for v2?
Hi Wolfram,
On Tue, Jun 21, 2022 at 2:35 PM Wolfram Sang
<[email protected]> wrote:
>
> > This patch series adds trivial fixes to renesas mmc driver.
>
> Did I miss if there is anything left to discuss for v2?
>
Sorry I missed to follow up. I'll send a v2 soon.
Cheers,
Prabhakar