2022-04-22 21:51:24

by baihaowen

Subject: [PATCH] drm/amd/display: Remove useless code

aux_rep only memset but no use at all, so we drop it.

Signed-off-by: Haowen Bai <[email protected]>
---
drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
index 8e814000db62..29e20d92b0bb 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
@@ -565,13 +565,11 @@ int dce_aux_transfer_raw(struct ddc_service *ddc,
struct ddc *ddc_pin = ddc->ddc_pin;
struct dce_aux *aux_engine;
struct aux_request_transaction_data aux_req;
- struct aux_reply_transaction_data aux_rep;
uint8_t returned_bytes = 0;
int res = -1;
uint32_t status;

memset(&aux_req, 0, sizeof(aux_req));
- memset(&aux_rep, 0, sizeof(aux_rep));

aux_engine = ddc->ctx->dc->res_pool->engines[ddc_pin->pin_data->en];
if (!acquire(aux_engine, ddc_pin)) {
--
2.7.4

2022-04-22 22:01:27

by Alex Deucher

Subject: Re: [PATCH] drm/amd/display: Remove useless code

Applied. Thanks!

Alex

On Thu, Apr 21, 2022 at 6:29 AM Haowen Bai <[email protected]> wrote:
>
> aux_rep only memset but no use at all, so we drop it.
>
> Signed-off-by: Haowen Bai <[email protected]>
> ---
> drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> index 8e814000db62..29e20d92b0bb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
> @@ -565,13 +565,11 @@ int dce_aux_transfer_raw(struct ddc_service *ddc,
> struct ddc *ddc_pin = ddc->ddc_pin;
> struct dce_aux *aux_engine;
> struct aux_request_transaction_data aux_req;
> - struct aux_reply_transaction_data aux_rep;
> uint8_t returned_bytes = 0;
> int res = -1;
> uint32_t status;
>
> memset(&aux_req, 0, sizeof(aux_req));
> - memset(&aux_rep, 0, sizeof(aux_rep));
>
> aux_engine = ddc->ctx->dc->res_pool->engines[ddc_pin->pin_data->en];
> if (!acquire(aux_engine, ddc_pin)) {
> --
> 2.7.4
>