2022-04-29 23:57:59

by Srinivas Kandagatla

Subject: [PATCH 0/1] slimbus: Fixes for 5.18

Hi Greg,

Here is one SLIMbus fix for 5.18.
Can you please queue this up for 5.18.

Thanks,
Srini

Miaoqian Lin (1):
slimbus: qcom: Fix IRQ check in qcom_slim_probe

drivers/slimbus/qcom-ctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--
2.21.0

2022-05-03 00:06:01

by Srinivas Kandagatla

Subject: [PATCH 1/1] slimbus: qcom: Fix IRQ check in qcom_slim_probe

From: Miaoqian Lin <[email protected]>

platform_get_irq() returns non-zero IRQ number on success,
negative error number on failure.
And the doc of platform_get_irq() provides a usage example:

int irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;

Fix the check of return value to catch errors correctly.

Cc: [email protected]
Fixes: ad7fcbc308b0 ("slimbus: qcom: Add Qualcomm Slimbus controller driver")
Signed-off-by: Miaoqian Lin <[email protected]>
Signed-off-by: Srinivas Kandagatla <[email protected]>
---
drivers/slimbus/qcom-ctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
index f04b961b96cd..ec58091fc948 100644
--- a/drivers/slimbus/qcom-ctrl.c
+++ b/drivers/slimbus/qcom-ctrl.c
@@ -510,9 +510,9 @@ static int qcom_slim_probe(struct platform_device *pdev)
}

ctrl->irq = platform_get_irq(pdev, 0);
- if (!ctrl->irq) {
+ if (ctrl->irq < 0) {
dev_err(&pdev->dev, "no slimbus IRQ\n");
- return -ENODEV;
+ return ctrl->irq;
}

sctrl = &ctrl->ctrl;
--
2.21.0