This patch allow users to enable "ELD Bypass" who don't
care anything from EDID Link Data.
Currently, this driver gets ELD(from EDID) to constraint
channels and rates.
Unfortunately, EDID is not always valid, maybe caused by
the fragile HDMI port or cable, in this situation, the max
features are limited to 48kHz stereo.
So, add this option to allow user to select the manual way
to output audio as expected. such as multi-channels LPCM(7.1),
or HBR bitstream for these sink devices.
Signed-off-by: Sugar Zhang <[email protected]>
---
sound/soc/codecs/hdmi-codec.c | 44 +++++++++++++++++++++++++++++++++++++++++--
1 file changed, 42 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c
index b07607a..3b78aa8 100644
--- a/sound/soc/codecs/hdmi-codec.c
+++ b/sound/soc/codecs/hdmi-codec.c
@@ -275,6 +275,7 @@ struct hdmi_codec_priv {
unsigned int chmap_idx;
struct mutex lock;
bool busy;
+ bool eld_bypass;
struct snd_soc_jack *jack;
unsigned int jack_status;
u8 iec_status[AES_IEC958_STATUS_SIZE];
@@ -427,6 +428,44 @@ static int hdmi_codec_iec958_mask_get(struct snd_kcontrol *kcontrol,
return 0;
}
+static int hdmi_codec_eld_bypass_info(struct snd_kcontrol *kcontrol,
+ struct snd_ctl_elem_info *uinfo)
+{
+ uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
+ uinfo->count = 1;
+ uinfo->value.integer.min = 0;
+ uinfo->value.integer.max = 1;
+
+ return 0;
+}
+
+static int hdmi_codec_eld_bypass_get(struct snd_kcontrol *kcontrol,
+ struct snd_ctl_elem_value *ucontrol)
+{
+ struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
+ struct hdmi_codec_priv *hcp = snd_soc_component_get_drvdata(component);
+
+ ucontrol->value.integer.value[0] = hcp->eld_bypass;
+
+ return 0;
+}
+
+static int hdmi_codec_eld_bypass_put(struct snd_kcontrol *kcontrol,
+ struct snd_ctl_elem_value *ucontrol)
+{
+ struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
+ struct hdmi_codec_priv *hcp = snd_soc_component_get_drvdata(component);
+
+ hcp->eld_bypass = ucontrol->value.integer.value[0];
+
+ return 0;
+}
+
+#define HDMI_CODEC_ELD_BYPASS_DECL(xname) \
+{ .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = xname, \
+ .info = hdmi_codec_eld_bypass_info, .get = hdmi_codec_eld_bypass_get, \
+ .put = hdmi_codec_eld_bypass_put, }
+
static int hdmi_codec_startup(struct snd_pcm_substream *substream,
struct snd_soc_dai *dai)
{
@@ -447,7 +486,7 @@ static int hdmi_codec_startup(struct snd_pcm_substream *substream,
goto err;
}
- if (tx && hcp->hcd.ops->get_eld) {
+ if (tx && !hcp->eld_bypass && hcp->hcd.ops->get_eld) {
ret = hcp->hcd.ops->get_eld(dai->dev->parent, hcp->hcd.data,
hcp->eld, sizeof(hcp->eld));
if (ret)
@@ -770,6 +809,7 @@ static struct snd_kcontrol_new hdmi_codec_controls[] = {
.info = hdmi_eld_ctl_info,
.get = hdmi_eld_ctl_get,
},
+ HDMI_CODEC_ELD_BYPASS_DECL("ELD Bypass"),
};
static int hdmi_codec_pcm_new(struct snd_soc_pcm_runtime *rtd,
@@ -854,7 +894,7 @@ static void plugged_cb(struct device *dev, bool plugged)
struct hdmi_codec_priv *hcp = dev_get_drvdata(dev);
if (plugged) {
- if (hcp->hcd.ops->get_eld) {
+ if (!hcp->eld_bypass && hcp->hcd.ops->get_eld) {
hcp->hcd.ops->get_eld(dev->parent, hcp->hcd.data,
hcp->eld, sizeof(hcp->eld));
}
--
2.7.4
On Fri, Apr 29, 2022 at 11:13:38PM +0800, Sugar Zhang wrote:
> So, add this option to allow user to select the manual way
> to output audio as expected. such as multi-channels LPCM(7.1),
> or HBR bitstream for these sink devices.
Please check this with mixer-test, it'll help validate that you've got
the control interface correct.
> .info = hdmi_eld_ctl_info,
> .get = hdmi_eld_ctl_get,
> },
> + HDMI_CODEC_ELD_BYPASS_DECL("ELD Bypass"),
This is a true/false value so the name should end with Switch.