2022-05-02 23:34:26

by Heikki Krogerus

[permalink] [raw]
Subject: [PATCH] serial: 8250: dw: Fix NULL pointer dereference

dw8250_platform_data is only used on DT platforms for now.

Fixes: 4a218b277fdb ("serial: 8250: dw: Create a generic platform data structure")
Signed-off-by: Heikki Krogerus <[email protected]>
---
Hi,

I'm sorry, I have to resend this (to you guys).
I left out the mailing lists.

Br,
---
drivers/tty/serial/8250/8250_dw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 0cf1a99dc1244..31422e44c64ff 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -433,9 +433,9 @@ static void dw8250_prepare_rx_dma(struct uart_8250_port *p)
static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data)
{
struct device_node *np = p->dev->of_node;
- unsigned int quirks = data->pdata->quirks;

if (np) {
+ unsigned int quirks = data->pdata->quirks;
int id;

/* get index of serial line, if found in DT aliases */
--
2.35.1