2022-05-06 21:36:04

by Jiapeng Chong

Subject: [PATCH] KVM: selftests: riscv: Remove unneeded semicolon

Fix the following coccicheck warnings:

./tools/testing/selftests/kvm/lib/riscv/processor.c:353:3-4: Unneeded
semicolon.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
tools/testing/selftests/kvm/lib/riscv/processor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/kvm/lib/riscv/processor.c b/tools/testing/selftests/kvm/lib/riscv/processor.c
index 3961487a4870..e17333518af2 100644
--- a/tools/testing/selftests/kvm/lib/riscv/processor.c
+++ b/tools/testing/selftests/kvm/lib/riscv/processor.c
@@ -350,7 +350,7 @@ void vcpu_args_set(struct kvm_vm *vm, uint32_t vcpuid, unsigned int num, ...)
case 7:
id = RISCV_CORE_REG(regs.a7);
break;
- };
+ }
set_reg(vm, vcpuid, id, va_arg(ap, uint64_t));
}

--
2.20.1.7.g153144c

2022-05-09 10:10:31

by Joe Perches

Subject: Re: [PATCH] KVM: selftests: riscv: Remove unneeded semicolon

On Mon, 2022-05-09 at 10:37 +0530, Anup Patel wrote:
> On Fri, May 6, 2022 at 3:15 PM Jiapeng Chong
> <[email protected]> wrote:
> >
> > Fix the following coccicheck warnings:
> >
> > ./tools/testing/selftests/kvm/lib/riscv/processor.c:353:3-4: Unneeded
> > semicolon.
> >
> > Reported-by: Abaci Robot <[email protected]>
> > Signed-off-by: Jiapeng Chong <[email protected]>
>
> In future, please CC [email protected] for KVM RISC-V related
> patches.

Perhaps add or update some MAINTAINERS entry as this list is not
currently specified by:

$ ./scripts/get_maintainer.pl -f tools/testing/selftests/kvm/lib/riscv/processor.c --nogit --nogit-fallback
Paolo Bonzini <[email protected]> (supporter:KERNEL VIRTUAL MACHINE (KVM))
Shuah Khan <[email protected]> (maintainer:KERNEL SELFTEST FRAMEWORK)
Paul Walmsley <[email protected]> (supporter:RISC-V ARCHITECTURE)
Palmer Dabbelt <[email protected]> (supporter:RISC-V ARCHITECTURE)
Albert Ou <[email protected]> (supporter:RISC-V ARCHITECTURE)
[email protected] (open list:KERNEL VIRTUAL MACHINE (KVM))
[email protected] (open list:KERNEL SELFTEST FRAMEWORK)
[email protected] (open list:RISC-V ARCHITECTURE)
[email protected] (open list)
$

2022-05-09 10:12:23

by Anup Patel

Subject: Re: [PATCH] KVM: selftests: riscv: Remove unneeded semicolon

On Mon, May 9, 2022 at 11:06 AM Joe Perches <[email protected]> wrote:
>
> On Mon, 2022-05-09 at 10:37 +0530, Anup Patel wrote:
> > On Fri, May 6, 2022 at 3:15 PM Jiapeng Chong
> > <[email protected]> wrote:
> > >
> > > Fix the following coccicheck warnings:
> > >
> > > ./tools/testing/selftests/kvm/lib/riscv/processor.c:353:3-4: Unneeded
> > > semicolon.
> > >
> > > Reported-by: Abaci Robot <[email protected]>
> > > Signed-off-by: Jiapeng Chong <[email protected]>
> >
> > In future, please CC [email protected] for KVM RISC-V related
> > patches.
>
> Perhaps add or update some MAINTAINERS entry as this list is not
> currently specified by:
>
> $ ./scripts/get_maintainer.pl -f tools/testing/selftests/kvm/lib/riscv/processor.c --nogit --nogit-fallback
> Paolo Bonzini <[email protected]> (supporter:KERNEL VIRTUAL MACHINE (KVM))
> Shuah Khan <[email protected]> (maintainer:KERNEL SELFTEST FRAMEWORK)
> Paul Walmsley <[email protected]> (supporter:RISC-V ARCHITECTURE)
> Palmer Dabbelt <[email protected]> (supporter:RISC-V ARCHITECTURE)
> Albert Ou <[email protected]> (supporter:RISC-V ARCHITECTURE)
> [email protected] (open list:KERNEL VIRTUAL MACHINE (KVM))
> [email protected] (open list:KERNEL SELFTEST FRAMEWORK)
> [email protected] (open list:RISC-V ARCHITECTURE)
> [email protected] (open list)
> $

Ahh, I see. I will certainly update the MAINTAINERS entry for
KVM RISC-V selftests.

Thanks,
Anup

>
>

2022-05-09 11:36:42

by Anup Patel

Subject: Re: [PATCH] KVM: selftests: riscv: Remove unneeded semicolon

On Fri, May 6, 2022 at 3:15 PM Jiapeng Chong
<[email protected]> wrote:
>
> Fix the following coccicheck warnings:
>
> ./tools/testing/selftests/kvm/lib/riscv/processor.c:353:3-4: Unneeded
> semicolon.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

In future, please CC [email protected] for KVM RISC-V related
patches.

I have queued this patch for 5.19

Thanks,
Anup

> ---
> tools/testing/selftests/kvm/lib/riscv/processor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/lib/riscv/processor.c b/tools/testing/selftests/kvm/lib/riscv/processor.c
> index 3961487a4870..e17333518af2 100644
> --- a/tools/testing/selftests/kvm/lib/riscv/processor.c
> +++ b/tools/testing/selftests/kvm/lib/riscv/processor.c
> @@ -350,7 +350,7 @@ void vcpu_args_set(struct kvm_vm *vm, uint32_t vcpuid, unsigned int num, ...)
> case 7:
> id = RISCV_CORE_REG(regs.a7);
> break;
> - };
> + }
> set_reg(vm, vcpuid, id, va_arg(ap, uint64_t));
> }
>
> --
> 2.20.1.7.g153144c
>