2022-05-09 01:22:20

by baihaowen

Subject: [PATCH] drm/rockchip: Remove unneeded semicolon

Fixes coccicheck warning:

drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:1476:2-3: Unneeded semicolon

Signed-off-by: Haowen Bai <[email protected]>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 0b49fed16535..7f9d88634a77 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -1473,7 +1473,7 @@ static void rk3568_set_intf_mux(struct vop2_video_port *vp, int id,
default:
drm_err(vop2->drm, "Invalid interface id %d on vp%d\n", id, vp->id);
return;
- };
+ }

dip |= RK3568_DSP_IF_POL__CFG_DONE_IMD;

--
2.7.4

2022-05-09 02:32:42

by Heiko Stuebner

Subject: Re: [PATCH] drm/rockchip: Remove unneeded semicolon

Am Freitag, 6. Mai 2022, 03:55:57 CEST schrieb Haowen Bai:
> Fixes coccicheck warning:
>
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:1476:2-3: Unneeded semicolon
>
> Signed-off-by: Haowen Bai <[email protected]>

Yang Li was slightly faster [0] than this patch, so I've picked that one.

[0] https://lore.kernel.org/r/[email protected]

> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> index 0b49fed16535..7f9d88634a77 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> @@ -1473,7 +1473,7 @@ static void rk3568_set_intf_mux(struct vop2_video_port *vp, int id,
> default:
> drm_err(vop2->drm, "Invalid interface id %d on vp%d\n", id, vp->id);
> return;
> - };
> + }
>
> dip |= RK3568_DSP_IF_POL__CFG_DONE_IMD;
>
>