This patch had been suggested by Indan Zupancic on May 13 but is not
in 2.6.22-rc2 so I'm re-sending it. Prior to Indan's e-mail, I had
sent the same patch to the kernel janitors list. I don't care whether
you credit the patch to me or Indan.
Denver
---------- Forwarded message ----------
From: Denver Gingerich <[email protected]>
Date: May 9, 2007 9:29 PM
Subject: [PATCH] fix compiler warning in dd.c
To: [email protected]
Correct the following compiler warning:
warning: 'device_probe_drivers' defined but not used
Verified that there are no device_probe_drivers() calls in the kernel tree.
Signed-off-by: Denver Gingerich <[email protected]>
---
--- linux-2.6.21/drivers/base/dd.c.000 2007-05-09 18:56:24.000000000 -0400
+++ linux-2.6.21/drivers/base/dd.c 2007-05-09 20:38:12.000000000 -0400
@@ -207,19 +207,6 @@ static int __device_attach(struct device
return driver_probe_device(drv, dev);
}
-static int device_probe_drivers(void *data)
-{
- struct device *dev = data;
- int ret = 0;
-
- if (dev->bus) {
- down(&dev->sem);
- ret = bus_for_each_drv(dev->bus, NULL, dev, __device_attach);
- up(&dev->sem);
- }
- return ret;
-}
-
/**
* device_attach - try to attach device to a driver.
* @dev: device.
On Sun, 20 May 2007 22:36:48 -0400,
"Denver Gingerich" <[email protected]> wrote:
> This patch had been suggested by Indan Zupancic on May 13 but is not
> in 2.6.22-rc2 so I'm re-sending it. Prior to Indan's e-mail, I had
> sent the same patch to the kernel janitors list. I don't care whether
> you credit the patch to me or Indan.
It seems you're about the fourth person to send that patch ;)
(Greg has driver-core-kill-unused-code.patch sitting in his tree, so I
guess he'll send this with his next round of patches.)