From: Peng Fan <[email protected]>
There is case that after remoteproc start remote processor[M4], the M4
runs slow and before M4 finish its own rpmsg framework initialization,
linux sends out vring kick message, then M4 firmware drops the kick
message. Some NXP released Cortex-M[x] images has such limitation that
it requires linux sends out vring kick message after M4 firmware finish
its rpmsg framework initialization.
The best case is to use a method to let M4 notify Linux that M4 has
finished initialization, but we could not patch released firmware,
then update driver to detect notification.
So add delay before linux send out vring kick message. It is not good to
use a fixed time delay in driver, so I choose to get that from device
tree.
Peng Fan (2):
dt-bindings: remoteproc: imx_rproc: add fsl,startup-delay-ms
remoteproc: imx_rproc: delay after kick remote processor
.../devicetree/bindings/remoteproc/fsl,imx-rproc.yaml | 4 ++++
drivers/remoteproc/imx_rproc.c | 9 +++++++++
2 files changed, 13 insertions(+)
--
2.25.1
From: Peng Fan <[email protected]>
add fsl,startup-delay-ms property indicating delay some time after just
kicks remote processor.
Signed-off-by: Peng Fan <[email protected]>
---
.../devicetree/bindings/remoteproc/fsl,imx-rproc.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
index 64e783234e38..56f3ed18c28c 100644
--- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
@@ -76,6 +76,10 @@ properties:
This property is to specify the resource id of the remote processor in SoC
which supports SCFW
+ fsl,startup-delay-ms:
+ $ref: "/schemas/types.yaml#/definitions/uint32"
+ description: Startup time that remote processor ready for communication
+
required:
- compatible
--
2.25.1
On Thu, Jun 09, 2022 at 08:34:59PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> add fsl,startup-delay-ms property indicating delay some time after just
> kicks remote processor.
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> .../devicetree/bindings/remoteproc/fsl,imx-rproc.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
What's the base? Doesn't apply to v5.19-rc1 for me.
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> index 64e783234e38..56f3ed18c28c 100644
> --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> @@ -76,6 +76,10 @@ properties:
> This property is to specify the resource id of the remote processor in SoC
> which supports SCFW
>
> + fsl,startup-delay-ms:
> + $ref: "/schemas/types.yaml#/definitions/uint32"
Standard unit types don't need a type. 'make dt_binding_check' should
have told you this.
> + description: Startup time that remote processor ready for communication
> +
> required:
> - compatible
>
> --
> 2.25.1
>
>
> Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: imx_rproc: add
> fsl,startup-delay-ms
>
> On Thu, Jun 09, 2022 at 08:34:59PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <[email protected]>
> >
> > add fsl,startup-delay-ms property indicating delay some time after
> > just kicks remote processor.
> >
> > Signed-off-by: Peng Fan <[email protected]>
> > ---
> > .../devicetree/bindings/remoteproc/fsl,imx-rproc.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> What's the base? Doesn't apply to v5.19-rc1 for me.
Sorry, I missed to mention that this patchset is based on the patchset
which support i.MX8QM/QXP:
https://patchwork.kernel.org/project/linux-remoteproc/cover/
[email protected]/
>
> >
> > diff --git
> > a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> > b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> > index 64e783234e38..56f3ed18c28c 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
> > @@ -76,6 +76,10 @@ properties:
> > This property is to specify the resource id of the remote processor in
> SoC
> > which supports SCFW
> >
> > + fsl,startup-delay-ms:
> > + $ref: "/schemas/types.yaml#/definitions/uint32"
>
> Standard unit types don't need a type. 'make dt_binding_check' should have
> told you this.
>
> > + description: Startup time that remote processor ready for
> > + communication
> > +
> > required:
> > - compatible
> >
> > --
> > 2.25.1
> >
> >