2022-06-13 01:51:26

by Yang Li

[permalink] [raw]
Subject: [PATCH -next] drm: Remove unnecessary print function dev_err()

The print function dev_err() is redundant because platform_get_irq()
already prints an error.

Eliminate the follow coccicheck warning:
./drivers/gpu/drm/logicvc/logicvc_drm.c:352:2-9: line 352 is redundant
because platform_get_irq() already prints an error

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/gpu/drm/logicvc/logicvc_drm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c
index df1805cf0f95..437b3011ae1e 100644
--- a/drivers/gpu/drm/logicvc/logicvc_drm.c
+++ b/drivers/gpu/drm/logicvc/logicvc_drm.c
@@ -349,7 +349,6 @@ static int logicvc_drm_probe(struct platform_device *pdev)

irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(dev, "Failed to get IRQ\n");
ret = -ENODEV;
goto error_reserved_mem;
}
--
2.20.1.7.g153144c


2022-06-24 15:40:43

by Paul Kocialkowski

[permalink] [raw]
Subject: Re: [PATCH -next] drm: Remove unnecessary print function dev_err()

Hi Yang,

On Mon 13 Jun 22, 09:26, Yang Li wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/gpu/drm/logicvc/logicvc_drm.c:352:2-9: line 352 is redundant
> because platform_get_irq() already prints an error
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Thanks for the patch!

Acked-by: Paul Kocialkowski <[email protected]>

Paul

> ---
> drivers/gpu/drm/logicvc/logicvc_drm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c
> index df1805cf0f95..437b3011ae1e 100644
> --- a/drivers/gpu/drm/logicvc/logicvc_drm.c
> +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c
> @@ -349,7 +349,6 @@ static int logicvc_drm_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(dev, "Failed to get IRQ\n");
> ret = -ENODEV;
> goto error_reserved_mem;
> }
> --
> 2.20.1.7.g153144c
>

--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Attachments:
(No filename) (1.21 kB)
 signature.asc (499.00 B)
 Download all attachments