2022-06-15 09:54:02

by Liang He

Subject: [PATCH] arch: arm: mach-versatile: Add missing of_node_put()

In vexpress_smp_dt_prepare_cpus(), of_find_matching_node() will
return a node pointer with refcount incremented. We should use
of_node_put() when it is not used anymore.

Signed-off-by: heliang <[email protected]>
---
arch/arm/mach-versatile/platsmp-vexpress.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-versatile/platsmp-vexpress.c b/arch/arm/mach-versatile/platsmp-vexpress.c
index 1ee3c45e71c9..459b5870de59 100644
--- a/arch/arm/mach-versatile/platsmp-vexpress.c
+++ b/arch/arm/mach-versatile/platsmp-vexpress.c
@@ -66,6 +66,8 @@ static void __init vexpress_smp_dt_prepare_cpus(unsigned int max_cpus)

if (scu)
scu_enable(of_iomap(scu, 0));
+
+ of_node_put(scu);

/*
* Write the address of secondary startup into the
--
2.25.1

2023-09-13 17:39:46

by Linus Walleij

Subject: Re: [PATCH] arch: arm: mach-versatile: Add missing of_node_put()

On Wed, Jun 15, 2022 at 11:31 AM heliang <[email protected]> wrote:

> In vexpress_smp_dt_prepare_cpus(), of_find_matching_node() will
> return a node pointer with refcount incremented. We should use
> of_node_put() when it is not used anymore.
>
> Signed-off-by: heliang <[email protected]>

Patch applied!

Yours,
Linus Walleij