2022-06-17 15:35:27

by Liang He

Subject: [PATCH] arm: mach-omap2: display: Fix refcount leak bug

In omapdss_init_fbdev(), of_find_node_by_name() will return a node
pointer with refcount incremented. We should use of_node_put() when
it is not used anymore.

Signed-off-by: Liang He <[email protected]>
---
arch/arm/mach-omap2/display.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c
index 21413a9b7b6c..eb09a25e3b45 100644
--- a/arch/arm/mach-omap2/display.c
+++ b/arch/arm/mach-omap2/display.c
@@ -211,6 +211,7 @@ static int __init omapdss_init_fbdev(void)
node = of_find_node_by_name(NULL, "omap4_padconf_global");
if (node)
omap4_dsi_mux_syscon = syscon_node_to_regmap(node);
+ of_node_put(node);

return 0;
}
--
2.25.1

2022-06-28 04:49:58

by Tony Lindgren

Subject: Re: [PATCH] arm: mach-omap2: display: Fix refcount leak bug

* Liang He <[email protected]> [220617 17:53]:
> In omapdss_init_fbdev(), of_find_node_by_name() will return a node
> pointer with refcount incremented. We should use of_node_put() when
> it is not used anymore.

Thanks applying into omap-for-v5.20/soc.

Tony