2022-06-18 02:14:32

by Liang He

Subject: [PATCH] arm: mach-omap2: pdata-quirks: Fix refcount leak bug

In pdata_quirks_init_clocks(), the loop contains
of_find_node_by_name() but without corresponding of_node_put().

Signed-off-by: Liang He <[email protected]>
---
arch/arm/mach-omap2/pdata-quirks.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2/pdata-quirks.c
index 13f1b89f74b8..5b99d602c87b 100644
--- a/arch/arm/mach-omap2/pdata-quirks.c
+++ b/arch/arm/mach-omap2/pdata-quirks.c
@@ -540,6 +540,8 @@ pdata_quirks_init_clocks(const struct of_device_id *omap_dt_match_table)

of_platform_populate(np, omap_dt_match_table,
omap_auxdata_lookup, NULL);
+
+ of_node_put(np);
}
}

--
2.25.1

2022-06-28 05:34:52

by Tony Lindgren

Subject: Re: [PATCH] arm: mach-omap2: pdata-quirks: Fix refcount leak bug

* Liang He <[email protected]> [220618 05:01]:
> In pdata_quirks_init_clocks(), the loop contains
> of_find_node_by_name() but without corresponding of_node_put().

Thanks applying into omap-for-v5.10/soc.

Tony