This is the first part for upstreaming Google's Cherry Tomato
Chromebook (Acer Chromebook Spin 513): in this series, we introduce
the devicetrees for the four revisions of this Chromebook and enable
every controller and feature that can be added as per the current
state of the main SoC devicetrees (mt8195.dtsi) and its PMIC
devicetree (mt6359.dtsi).
More parts will come as soon as more support will be added by
MediaTek in the mt8195 devicetree.
Note: This series will introduce a dtbs_check warning about a failure
to match compatible for 'mediatek,mt6359': that's expected, as
this is defined in devicetree/bindings/mfd/mt6397.txt (so there
is no schema, yet).
This series depends on the following fixes:
[1]: https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/
[2]: https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/
[3]: https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/
AngeloGioacchino Del Regno (11):
dt-bindings: arm: mediatek: Add MT8195 Cherry Tomato Chromebooks
arm64: dts: mediatek: Introduce MT8195 Cherry platform's Tomato
arm64: dts: mediatek: cherry: Assign interrupt line to MT6359 PMIC
arm64: dts: mediatek: cherry: Add platform regulators layout and
config
arm64: dts: mediatek: cherry: Add support for internal eMMC storage
arm64: dts: mediatek: cherry: Document gpios and add default pin
config
arm64: dts: mediatek: cherry: Enable I2C and SPI controllers
arm64: dts: mediatek: cherry: Enable T-PHYs and USB XHCI controllers
arm64: dts: mediatek: cherry: Enable MT6360 sub-pmic on I2C7
arm64: dts: mediatek: cherry: Enable support for the SPI NOR flash
arm64: dts: mediatek: cherry: Add I2C-HID touchscreen on I2C4
.../devicetree/bindings/arm/mediatek.yaml | 13 +
arch/arm64/boot/dts/mediatek/Makefile | 3 +
.../dts/mediatek/mt8195-cherry-tomato-r1.dts | 15 +
.../dts/mediatek/mt8195-cherry-tomato-r2.dts | 35 +
.../dts/mediatek/mt8195-cherry-tomato-r3.dts | 36 +
.../boot/dts/mediatek/mt8195-cherry.dtsi | 715 ++++++++++++++++++
6 files changed, 817 insertions(+)
create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
--
2.35.1
Document board compatibles for the MT8195 Cherry platform's
Tomato Chromebooks, at the time of writing composed of four
revisions (r0, r1, r2, r3-r4).
Signed-off-by: AngeloGioacchino Del Regno <[email protected]>
---
Documentation/devicetree/bindings/arm/mediatek.yaml | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index dd6c6e8011f9..3e0afa17ed2e 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -144,6 +144,19 @@ properties:
- const: google,spherion-rev0
- const: google,spherion
- const: mediatek,mt8192
+ - description: Google Tomato (Acer Chromebook Spin 513)
+ items:
+ - enum:
+ - google,tomato-rev2
+ - google,tomato-rev1
+ - const: google,tomato
+ - const: mediatek,mt8195
+ - description: Google Tomato (rev3 - 4)
+ items:
+ - const: google,tomato-rev4
+ - const: google,tomato-rev3
+ - const: google,tomato
+ - const: mediatek,mt8195
- items:
- enum:
- mediatek,mt8186-evb
--
2.35.1
On 30/06/2022 17:33, AngeloGioacchino Del Regno wrote:
> Document board compatibles for the MT8195 Cherry platform's
> Tomato Chromebooks, at the time of writing composed of four
> revisions (r0, r1, r2, r3-r4).
>
> Signed-off-by: AngeloGioacchino Del Regno <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On Thu, Jun 30, 2022 at 05:33:06PM +0200, AngeloGioacchino Del Regno wrote:
> Document board compatibles for the MT8195 Cherry platform's
> Tomato Chromebooks, at the time of writing composed of four
> revisions (r0, r1, r2, r3-r4).
>
> Signed-off-by: AngeloGioacchino Del Regno <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/mediatek.yaml | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index dd6c6e8011f9..3e0afa17ed2e 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -144,6 +144,19 @@ properties:
> - const: google,spherion-rev0
> - const: google,spherion
> - const: mediatek,mt8192
> + - description: Google Tomato (Acer Chromebook Spin 513)
Hi Angelo,
searching for "Acer Chromebook Spin 513" I found that there are two different
chromebooks:
https://www.acer.com/ac/en/US/content/series/acerchromebookspin513
https://www.acer.com/ac/en/GB/content/series/acerchromebookspin513cp5132h
The first one is a Qualcomm based one, while the second is mt8195-based, so I
assume that's Tomato.
They can be telled apart by the model name though: the Qualcomm one is
"CP513-1H", while Tomato is "CP513-2H". So I suggest to add the "CP513-2H" here
in the description, as well as in the cover letter, to avoid confusion between
the two.
Thanks,
N?colas
> + items:
> + - enum:
> + - google,tomato-rev2
> + - google,tomato-rev1
> + - const: google,tomato
> + - const: mediatek,mt8195
> + - description: Google Tomato (rev3 - 4)
> + items:
> + - const: google,tomato-rev4
> + - const: google,tomato-rev3
> + - const: google,tomato
> + - const: mediatek,mt8195
> - items:
> - enum:
> - mediatek,mt8186-evb
> --
> 2.35.1
>
On Thu, Jun 30, 2022 at 05:33:06PM +0200, AngeloGioacchino Del Regno wrote:
> Document board compatibles for the MT8195 Cherry platform's
> Tomato Chromebooks, at the time of writing composed of four
> revisions (r0, r1, r2, r3-r4).
Though r0 is not added in this series?
>
> Signed-off-by: AngeloGioacchino Del Regno <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/mediatek.yaml | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index dd6c6e8011f9..3e0afa17ed2e 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -144,6 +144,19 @@ properties:
> - const: google,spherion-rev0
> - const: google,spherion
> - const: mediatek,mt8192
Angelo, this patch is depending on the patch from the asurada-spherion series
[1] to apply. Since this isn't the case for patch 2 as well, I assume this was
a mistake. And it does seem better to keep them independent.
[1] https://lore.kernel.org/all/[email protected]/
Thanks,
N?colas
> + - description: Google Tomato (Acer Chromebook Spin 513)
> + items:
> + - enum:
> + - google,tomato-rev2
> + - google,tomato-rev1
> + - const: google,tomato
> + - const: mediatek,mt8195
> + - description: Google Tomato (rev3 - 4)
> + items:
> + - const: google,tomato-rev4
> + - const: google,tomato-rev3
> + - const: google,tomato
> + - const: mediatek,mt8195
> - items:
> - enum:
> - mediatek,mt8186-evb
> --
> 2.35.1
>
Il 02/07/22 00:04, Nícolas F. R. A. Prado ha scritto:
> On Thu, Jun 30, 2022 at 05:33:06PM +0200, AngeloGioacchino Del Regno wrote:
>> Document board compatibles for the MT8195 Cherry platform's
>> Tomato Chromebooks, at the time of writing composed of four
>> revisions (r0, r1, r2, r3-r4).
>
> Though r0 is not added in this series?
>
>>
>> Signed-off-by: AngeloGioacchino Del Regno <[email protected]>
>> ---
>> Documentation/devicetree/bindings/arm/mediatek.yaml | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
>> index dd6c6e8011f9..3e0afa17ed2e 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
>> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
>> @@ -144,6 +144,19 @@ properties:
>> - const: google,spherion-rev0
>> - const: google,spherion
>> - const: mediatek,mt8192
>
> Angelo, this patch is depending on the patch from the asurada-spherion series
> [1] to apply. Since this isn't the case for patch 2 as well, I assume this was
> a mistake. And it does seem better to keep them independent.
Yes, thanks for pointing that out - I forgot to advertise the dependency in the
cover letter.
Though, making this one independent from yours isn't really possible, as doing
that would ruin the ordering in mediatek.yaml.
I will advertise the dependency in v2.
Cheers,
Angelo
>
> [1] https://lore.kernel.org/all/[email protected]/
>
> Thanks,
> Nícolas
>
>> + - description: Google Tomato (Acer Chromebook Spin 513)
>> + items:
>> + - enum:
>> + - google,tomato-rev2
>> + - google,tomato-rev1
>> + - const: google,tomato
>> + - const: mediatek,mt8195
>> + - description: Google Tomato (rev3 - 4)
>> + items:
>> + - const: google,tomato-rev4
>> + - const: google,tomato-rev3
>> + - const: google,tomato
>> + - const: mediatek,mt8195
>> - items:
>> - enum:
>> - mediatek,mt8186-evb
>> --
>> 2.35.1
>>
Il 01/07/22 17:31, Nícolas F. R. A. Prado ha scritto:
> On Thu, Jun 30, 2022 at 05:33:06PM +0200, AngeloGioacchino Del Regno wrote:
>> Document board compatibles for the MT8195 Cherry platform's
>> Tomato Chromebooks, at the time of writing composed of four
>> revisions (r0, r1, r2, r3-r4).
>>
>> Signed-off-by: AngeloGioacchino Del Regno <[email protected]>
>> ---
>> Documentation/devicetree/bindings/arm/mediatek.yaml | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
>> index dd6c6e8011f9..3e0afa17ed2e 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
>> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
>> @@ -144,6 +144,19 @@ properties:
>> - const: google,spherion-rev0
>> - const: google,spherion
>> - const: mediatek,mt8192
>> + - description: Google Tomato (Acer Chromebook Spin 513)
>
> Hi Angelo,
>
> searching for "Acer Chromebook Spin 513" I found that there are two different
> chromebooks:
>
> https://www.acer.com/ac/en/US/content/series/acerchromebookspin513
> https://www.acer.com/ac/en/GB/content/series/acerchromebookspin513cp5132h
>
> The first one is a Qualcomm based one, while the second is mt8195-based, so I
> assume that's Tomato.
>
> They can be telled apart by the model name though: the Qualcomm one is
> "CP513-1H", while Tomato is "CP513-2H". So I suggest to add the "CP513-2H" here
> in the description, as well as in the cover letter, to avoid confusion between
> the two.
>
Hey Nicolas,
nice catch!
Even though it would be odd for someone to think that we refer to a Qualcomm
powered Chromebook while checking 'mediatek.yaml'... I agree with you, let's
specify the model clearly as 'CP513-2H': it fits, so why not!
I'll send a v2 soon.
Cheers!
> Thanks,
> Nícolas
>