2022-07-08 01:23:27

by sunliming

[permalink] [raw]
Subject: [PATCH RESEND] drm/msm/dsi: fix the inconsistent indenting

Fix the inconsistent indenting in function msm_dsi_dphy_timing_calc_v3().

Fix the following smatch warnings:

drivers/gpu/drm/msm/dsi/phy/dsi_phy.c:350 msm_dsi_dphy_timing_calc_v3() warn: inconsistent indenting

Reported-by: kernel test robot <[email protected]>
Signed-off-by: sunliming <[email protected]>
---
drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
index a39de3bdc7fa..56dfa2d24be1 100644
--- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
+++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
@@ -347,7 +347,7 @@ int msm_dsi_dphy_timing_calc_v3(struct msm_dsi_dphy_timing *timing,
} else {
timing->shared_timings.clk_pre =
linear_inter(tmax, tmin, pcnt2, 0, false);
- timing->shared_timings.clk_pre_inc_by_2 = 0;
+ timing->shared_timings.clk_pre_inc_by_2 = 0;
}

timing->ta_go = 3;
--
2.25.1


2022-07-08 16:16:47

by Abhinav Kumar

[permalink] [raw]
Subject: Re: [PATCH RESEND] drm/msm/dsi: fix the inconsistent indenting



On 7/7/2022 5:58 PM, sunliming wrote:
> Fix the inconsistent indenting in function msm_dsi_dphy_timing_calc_v3().
>
> Fix the following smatch warnings:
>
> drivers/gpu/drm/msm/dsi/phy/dsi_phy.c:350 msm_dsi_dphy_timing_calc_v3() warn: inconsistent indenting
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: sunliming <[email protected]>
Reviewed-by: Abhinav Kumar <[email protected]>
> ---
> drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
> index a39de3bdc7fa..56dfa2d24be1 100644
> --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
> +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
> @@ -347,7 +347,7 @@ int msm_dsi_dphy_timing_calc_v3(struct msm_dsi_dphy_timing *timing,
> } else {
> timing->shared_timings.clk_pre =
> linear_inter(tmax, tmin, pcnt2, 0, false);
> - timing->shared_timings.clk_pre_inc_by_2 = 0;
> + timing->shared_timings.clk_pre_inc_by_2 = 0;
> }
>
> timing->ta_go = 3;

2022-07-18 18:27:28

by Abhinav Kumar

[permalink] [raw]
Subject: Re: [Freedreno] [PATCH RESEND] drm/msm/dsi: fix the inconsistent indenting



On 7/8/2022 9:03 AM, Abhinav Kumar wrote:
>
>
> On 7/7/2022 5:58 PM, sunliming wrote:
>> Fix the inconsistent indenting in function msm_dsi_dphy_timing_calc_v3().
>>
>> Fix the following smatch warnings:
>>
>> drivers/gpu/drm/msm/dsi/phy/dsi_phy.c:350
>> msm_dsi_dphy_timing_calc_v3() warn: inconsistent indenting
>>
>> Reported-by: kernel test robot <[email protected]>
>> Signed-off-by: sunliming <[email protected]>
> Reviewed-by: Abhinav Kumar <[email protected]>
Fixes: f1fa7ff44056 ("drm/msm/dsi: implement auto PHY timing calculator
for 10nm PHY")
>> ---
>>   drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
>> b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
>> index a39de3bdc7fa..56dfa2d24be1 100644
>> --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
>> +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
>> @@ -347,7 +347,7 @@ int msm_dsi_dphy_timing_calc_v3(struct
>> msm_dsi_dphy_timing *timing,
>>       } else {
>>           timing->shared_timings.clk_pre =
>>               linear_inter(tmax, tmin, pcnt2, 0, false);
>> -            timing->shared_timings.clk_pre_inc_by_2 = 0;
>> +        timing->shared_timings.clk_pre_inc_by_2 = 0;
>>       }
>>       timing->ta_go = 3;