2022-07-19 13:55:16

by Jason Wang

Subject: [PATCH] scsi: message: fusion: Fix comment typo

The double `only' is duplicated in the comment, remove one.

Signed-off-by: Jason Wang <[email protected]>
---
drivers/message/fusion/mptbase.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
index 9b3ba2df71c7..86e7510d7614 100644
--- a/drivers/message/fusion/mptbase.c
+++ b/drivers/message/fusion/mptbase.c
@@ -518,7 +518,7 @@ mpt_reply(MPT_ADAPTER *ioc, u32 pa)

/* Map DMA address of reply header to cpu address.
* pa is 32 bits - but the dma address may be 32 or 64 bits
- * get offset based only only the low addresses
+ * get offset based only the low addresses
*/

reply_dma_low = (pa <<= 1);
--
2.35.1

2022-07-19 14:23:18

by James Bottomley

Subject: Re: [PATCH] scsi: message: fusion: Fix comment typo

On Sat, 2022-07-16 at 12:22 +0800, Jason Wang wrote:
> The double `only' is duplicated in the comment, remove one.
>
> Signed-off-by: Jason Wang <[email protected]>
> ---
> drivers/message/fusion/mptbase.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/message/fusion/mptbase.c
> b/drivers/message/fusion/mptbase.c
> index 9b3ba2df71c7..86e7510d7614 100644
> --- a/drivers/message/fusion/mptbase.c
> +++ b/drivers/message/fusion/mptbase.c
> @@ -518,7 +518,7 @@ mpt_reply(MPT_ADAPTER *ioc, u32 pa)
>
> /* Map DMA address of reply header to cpu address.
> * pa is 32 bits - but the dma address may be 32 or 64 bits
> - * get offset based only only the low addresses
> + * get offset based only the low addresses

What is the point of all this if you're not even going to read the
comment to make sure it makes grammatical sense? Neither the before
nor after versions do here.

James