2022-08-04 15:55:54

by Tomer Maimon

Subject: [PATCH v1] dt-binding: ipmi: add fallback to npcm845 compatible

Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible
string.

Signed-off-by: Tomer Maimon <[email protected]>
---
Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
index cbc10a68ddef..4fda76e63396 100644
--- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
+++ b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
@@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host.
Required properties:
- compatible : should be one of
"nuvoton,npcm750-kcs-bmc"
- "nuvoton,npcm845-kcs-bmc"
+ "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc"
- interrupts : interrupt generated by the controller
- kcs_chan : The KCS channel number in the controller

--
2.33.0

2022-08-04 15:58:16

by Krzysztof Kozlowski

Subject: Re: [PATCH v1] dt-binding: ipmi: add fallback to npcm845 compatible

On 04/08/2022 16:55, Tomer Maimon wrote:
> Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible
> string.

It's easily visible in the code what you are doing, so instead you must
explain why you are doing it.

Best regards,
Krzysztof