2022-08-11 23:18:16

by George G. Davis

Subject: [PATCH] arm64: enable kernel command line concatenation

From: "George G. Davis" <[email protected]>

Enable CONFIG_CMDLINE to extend the boot loader supplied cmdline. This
can then be used in config fragments to set command line arguments
specific to testing of different kernel config options.

Signed-off-by: George G. Davis <[email protected]>
---
arch/arm64/Kconfig | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 571cc234d0b3..cf4a44cde21b 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -2140,6 +2140,12 @@ config CMDLINE_FROM_BOOTLOADER
the boot loader doesn't provide any, the default kernel command
string provided in CMDLINE will be used.

+config CMDLINE_EXTEND
+ bool "Extend bootloader kernel arguments"
+ help
+ The command-line arguments provided by the boot loader will be
+ appended to the default kernel command string.
+
config CMDLINE_FORCE
bool "Always use the default kernel command string"
help
--
2.25.1

2022-08-12 09:18:59

by Will Deacon

Subject: Re: [PATCH] arm64: enable kernel command line concatenation

On Thu, Aug 11, 2022 at 07:11:27PM -0400, George G. Davis wrote:
> From: "George G. Davis" <[email protected]>
>
> Enable CONFIG_CMDLINE to extend the boot loader supplied cmdline. This
> can then be used in config fragments to set command line arguments
> specific to testing of different kernel config options.
>
> Signed-off-by: George G. Davis <[email protected]>
> ---
> arch/arm64/Kconfig | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 571cc234d0b3..cf4a44cde21b 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -2140,6 +2140,12 @@ config CMDLINE_FROM_BOOTLOADER
> the boot loader doesn't provide any, the default kernel command
> string provided in CMDLINE will be used.
>
> +config CMDLINE_EXTEND
> + bool "Extend bootloader kernel arguments"
> + help
> + The command-line arguments provided by the boot loader will be
> + appended to the default kernel command string.
> +

Please see cae118b6acc3 ("arm64: Drop support for CMDLINE_EXTEND") and the
Link tags in there for some background as to why we shouldn't just enable
this option.

Thanks,

Will