2022-08-29 17:37:19

by Rafael J. Wysocki

Subject: [PATCH v1] ACPI: property: Use acpi_dev_parent()

From: Rafael J. Wysocki <[email protected]>

After introducing acpi_dev_parent() in commit 62fcb99bdf10 ("ACPI: Drop
parent field from struct acpi_device"), it is better to use it instead
of accessing the dev.parent field in struct acpi_device directly.

Modify acpi_node_get_parent() accordingly.

Suggested-by: Andy Shevchenko <[email protected]>
Signed-off-by: Rafael J. Wysocki <[email protected]>
---
drivers/acpi/property.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

Index: linux-pm/drivers/acpi/property.c
===================================================================
--- linux-pm.orig/drivers/acpi/property.c
+++ linux-pm/drivers/acpi/property.c
@@ -1269,10 +1269,11 @@ acpi_node_get_parent(const struct fwnode
return to_acpi_data_node(fwnode)->parent;
}
if (is_acpi_device_node(fwnode)) {
- struct device *dev = to_acpi_device_node(fwnode)->dev.parent;
+ struct acpi_device *parent;

- if (dev)
- return acpi_fwnode_handle(to_acpi_device(dev));
+ parent = acpi_dev_parent(to_acpi_device_node(fwnode));
+ if (parent)
+ return acpi_fwnode_handle(parent);
}

return NULL;

2022-08-29 17:40:20

by Andy Shevchenko

Subject: Re: [PATCH v1] ACPI: property: Use acpi_dev_parent()

On Mon, Aug 29, 2022 at 06:12:33PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <[email protected]>
>
> After introducing acpi_dev_parent() in commit 62fcb99bdf10 ("ACPI: Drop
> parent field from struct acpi_device"), it is better to use it instead
> of accessing the dev.parent field in struct acpi_device directly.
>
> Modify acpi_node_get_parent() accordingly.

Reviewed-by: Andy Shevchenko <[email protected]>

Thanks!

> Suggested-by: Andy Shevchenko <[email protected]>
> Signed-off-by: Rafael J. Wysocki <[email protected]>
> ---
> drivers/acpi/property.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> Index: linux-pm/drivers/acpi/property.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/property.c
> +++ linux-pm/drivers/acpi/property.c
> @@ -1269,10 +1269,11 @@ acpi_node_get_parent(const struct fwnode
> return to_acpi_data_node(fwnode)->parent;
> }
> if (is_acpi_device_node(fwnode)) {
> - struct device *dev = to_acpi_device_node(fwnode)->dev.parent;
> + struct acpi_device *parent;
>
> - if (dev)
> - return acpi_fwnode_handle(to_acpi_device(dev));
> + parent = acpi_dev_parent(to_acpi_device_node(fwnode));
> + if (parent)
> + return acpi_fwnode_handle(parent);
> }
>
> return NULL;
>
>
>

--
With Best Regards,
Andy Shevchenko