2022-09-23 16:57:23

by Krzysztof Kozlowski

Subject: [PATCH 1/5] slimbus: stream: add checks for invalid unprepare/disable usage

slim_disable_stream() and slim_stream_unprepare() are exported, so add
sanity checks preventing unmatched/invalid calls.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/slimbus/stream.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/slimbus/stream.c b/drivers/slimbus/stream.c
index 75f87b3d8b95..7bb073ca6006 100644
--- a/drivers/slimbus/stream.c
+++ b/drivers/slimbus/stream.c
@@ -407,6 +407,9 @@ int slim_stream_disable(struct slim_stream_runtime *stream)
struct slim_controller *ctrl = stream->dev->ctrl;
int ret, i;

+ if (!stream->ports || !stream->num_ports)
+ return -EINVAL;
+
if (ctrl->disable_stream)
ctrl->disable_stream(stream);

@@ -438,6 +441,9 @@ int slim_stream_unprepare(struct slim_stream_runtime *stream)
{
int i;

+ if (!stream->ports || !stream->num_ports)
+ return -EINVAL;
+
for (i = 0; i < stream->num_ports; i++)
slim_disconnect_port(stream, &stream->ports[i]);

--
2.34.1

2022-10-26 16:41:51

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/5] slimbus: stream: add checks for invalid unprepare/disable usage

On 23/09/2022 11:57, Krzysztof Kozlowski wrote:
> slim_disable_stream() and slim_stream_unprepare() are exported, so add
> sanity checks preventing unmatched/invalid calls.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

Hi Srini,

This patchset is also waiting for a month without comments.

Best regards,
Krzysztof

2022-10-26 17:16:47

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/5] slimbus: stream: add checks for invalid unprepare/disable usage

On 23/09/2022 11:57, Krzysztof Kozlowski wrote:
> slim_disable_stream() and slim_stream_unprepare() are exported, so add
> sanity checks preventing unmatched/invalid calls.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/slimbus/stream.c | 6 ++++++


Hi Srini,

Any comments on these patches? Can they be picked up?

Best regards,
Krzysztof

2022-10-31 19:23:30

by Srinivas Kandagatla

Subject: Re: [PATCH 1/5] slimbus: stream: add checks for invalid unprepare/disable usage

On 23/09/2022 16:57, Krzysztof Kozlowski wrote:
> slim_disable_stream() and slim_stream_unprepare() are exported, so add
> sanity checks preventing unmatched/invalid calls.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

Applied all.
thanks,
--srini
> drivers/slimbus/stream.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/slimbus/stream.c b/drivers/slimbus/stream.c
> index 75f87b3d8b95..7bb073ca6006 100644
> --- a/drivers/slimbus/stream.c
> +++ b/drivers/slimbus/stream.c
> @@ -407,6 +407,9 @@ int slim_stream_disable(struct slim_stream_runtime *stream)
> struct slim_controller *ctrl = stream->dev->ctrl;
> int ret, i;
>
> + if (!stream->ports || !stream->num_ports)
> + return -EINVAL;
> +
> if (ctrl->disable_stream)
> ctrl->disable_stream(stream);
>
> @@ -438,6 +441,9 @@ int slim_stream_unprepare(struct slim_stream_runtime *stream)
> {
> int i;
>
> + if (!stream->ports || !stream->num_ports)
> + return -EINVAL;
> +
> for (i = 0; i < stream->num_ports; i++)
> slim_disconnect_port(stream, &stream->ports[i]);
>