2022-10-19 09:46:05

by Ilpo Järvinen

Subject: [PATCH 24/44] serial: mvebu-uart: Use uart_xmit_advance()

Take advantage of the new uart_xmit_advance() helper.

Signed-off-by: Ilpo Järvinen <[email protected]>
---
drivers/tty/serial/mvebu-uart.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c
index ba16e1da6bd3..ba9a6206daae 100644
--- a/drivers/tty/serial/mvebu-uart.c
+++ b/drivers/tty/serial/mvebu-uart.c
@@ -223,8 +223,7 @@ static void mvebu_uart_start_tx(struct uart_port *port)

if (IS_EXTENDED(port) && !uart_circ_empty(xmit)) {
writel(xmit->buf[xmit->tail], port->membase + UART_TSH(port));
- xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1);
- port->icount.tx++;
+ uart_xmit_advance(port, 1);
}

ctl = readl(port->membase + UART_INTR(port));
--
2.30.2

2022-10-20 20:27:40

by Pali Rohár

Subject: Re: [PATCH 24/44] serial: mvebu-uart: Use uart_xmit_advance()

On Wednesday 19 October 2022 12:11:31 Ilpo Järvinen wrote:
> Take advantage of the new uart_xmit_advance() helper.
>
> Signed-off-by: Ilpo Järvinen <[email protected]>

Reviewed-by: Pali Rohár <[email protected]>

> ---
> drivers/tty/serial/mvebu-uart.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c
> index ba16e1da6bd3..ba9a6206daae 100644
> --- a/drivers/tty/serial/mvebu-uart.c
> +++ b/drivers/tty/serial/mvebu-uart.c
> @@ -223,8 +223,7 @@ static void mvebu_uart_start_tx(struct uart_port *port)
>
> if (IS_EXTENDED(port) && !uart_circ_empty(xmit)) {
> writel(xmit->buf[xmit->tail], port->membase + UART_TSH(port));
> - xmit->tail = (xmit->tail + 1) & (UART_XMIT_SIZE - 1);
> - port->icount.tx++;
> + uart_xmit_advance(port, 1);
> }
>
> ctl = readl(port->membase + UART_INTR(port));
> --
> 2.30.2
>