2022-11-04 15:51:12

by Luca Weiss

Subject: [PATCH] soc: qcom: llcc: make irq truly optional

The function platform_get_irq prints an error message into the kernel
log when the irq isn't found.

Since the interrupt is actually optional and not provided by some SoCs,
use platform_get_irq_optional which does not print an error message.

Fixes: c081f3060fab ("soc: qcom: Add support to register LLCC EDAC driver")
Signed-off-by: Luca Weiss <[email protected]>
---
drivers/soc/qcom/llcc-qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index 8b7e8118f3ce..82c3cfdcc560 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -849,7 +849,7 @@ static int qcom_llcc_probe(struct platform_device *pdev)
if (ret)
goto err;

- drv_data->ecc_irq = platform_get_irq(pdev, 0);
+ drv_data->ecc_irq = platform_get_irq_optional(pdev, 0);
if (drv_data->ecc_irq >= 0) {
llcc_edac = platform_device_register_data(&pdev->dev,
"qcom_llcc_edac", -1, drv_data,
--
2.38.1

2022-11-07 03:24:15

by Bjorn Andersson

Subject: Re: [PATCH] soc: qcom: llcc: make irq truly optional

On Fri, 4 Nov 2022 16:30:41 +0100, Luca Weiss wrote:
> The function platform_get_irq prints an error message into the kernel
> log when the irq isn't found.
>
> Since the interrupt is actually optional and not provided by some SoCs,
> use platform_get_irq_optional which does not print an error message.
>
>
> [...]

Applied, thanks!

[1/1] soc: qcom: llcc: make irq truly optional
commit: c882c899ead3545102a4d71b5fbe73b9e4bc2657

Best regards,
--
Bjorn Andersson <[email protected]>