2022-11-04 17:02:59

by Miquel Raynal

Subject: [PATCH v3 1/6] dt-bindings: nvmem: Fix example

Despite not being listed nor required within the top level nvmem yaml
file, the "compatible" property is mandatory and is actually enforced by
all the nvmem provider bindings.

Unfortunately, the lack of compatible in the nvmem.yaml to level
description file lead to the example not matching anything and thus not
being checked at all.

Let's pick a compatible almost randomly (one which is already used with
the qfprom label) to make the example at least valid on a semantic
point of view and getting it checked.

Signed-off-by: Miquel Raynal <[email protected]>
---
Documentation/devicetree/bindings/nvmem/nvmem.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
index 1eb22dba364c..0455506fc30f 100644
--- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
+++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
@@ -67,6 +67,7 @@ examples:
#include <dt-bindings/gpio/gpio.h>

qfprom: eeprom@700000 {
+ compatible = "qcom,msm8974-qfprom", "qcom,qfprom";
#address-cells = <1>;
#size-cells = <1>;
reg = <0x00700000 0x100000>;
--
2.34.1

2022-11-10 04:10:37

by Rob Herring (Arm)

Subject: Re: [PATCH v3 1/6] dt-bindings: nvmem: Fix example

On Fri, 04 Nov 2022 17:38:28 +0100, Miquel Raynal wrote:
> Despite not being listed nor required within the top level nvmem yaml
> file, the "compatible" property is mandatory and is actually enforced by
> all the nvmem provider bindings.
>
> Unfortunately, the lack of compatible in the nvmem.yaml to level
> description file lead to the example not matching anything and thus not
> being checked at all.
>
> Let's pick a compatible almost randomly (one which is already used with
> the qfprom label) to make the example at least valid on a semantic
> point of view and getting it checked.
>
> Signed-off-by: Miquel Raynal <[email protected]>
> ---
> Documentation/devicetree/bindings/nvmem/nvmem.yaml | 1 +
> 1 file changed, 1 insertion(+)
>

Acked-by: Rob Herring <[email protected]>

2022-11-11 17:41:56

by Srinivas Kandagatla

Subject: Re: [PATCH v3 1/6] dt-bindings: nvmem: Fix example

On 04/11/2022 16:38, Miquel Raynal wrote:
> Despite not being listed nor required within the top level nvmem yaml
> file, the "compatible" property is mandatory and is actually enforced by
> all the nvmem provider bindings.
>
> Unfortunately, the lack of compatible in the nvmem.yaml to level
> description file lead to the example not matching anything and thus not
> being checked at all.
>
> Let's pick a compatible almost randomly (one which is already used with
> the qfprom label) to make the example at least valid on a semantic
> point of view and getting it checked.
>
> Signed-off-by: Miquel Raynal <[email protected]>

Applied thanks

--srini
> ---
> Documentation/devicetree/bindings/nvmem/nvmem.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> index 1eb22dba364c..0455506fc30f 100644
> --- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> @@ -67,6 +67,7 @@ examples:
> #include <dt-bindings/gpio/gpio.h>
>
> qfprom: eeprom@700000 {
> + compatible = "qcom,msm8974-qfprom", "qcom,qfprom";
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0x00700000 0x100000>;