2022-11-09 18:04:11

by Jeremy Linton

[permalink] [raw]
Subject: [PATCH] ACPI: Enable FPDT on arm64

FPDT provides some boot timing records useful for analyzing
parts of the UEFI boot stack. Given the existing code works
on arm64, and allows reading the values without utilizing
/dev/mem it seems like a good idea to turn it on.

Signed-off-by: Jeremy Linton <[email protected]>
---
Documentation/arm64/acpi_object_usage.rst | 2 +-
drivers/acpi/Kconfig | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/arm64/acpi_object_usage.rst b/Documentation/arm64/acpi_object_usage.rst
index 0609da73970b..484ef9676653 100644
--- a/Documentation/arm64/acpi_object_usage.rst
+++ b/Documentation/arm64/acpi_object_usage.rst
@@ -163,7 +163,7 @@ FPDT Section 5.2.23 (signature == "FPDT")

**Firmware Performance Data Table**

- Optional, not currently supported.
+ Optional, useful for boot performance profiling.

GTDT Section 5.2.24 (signature == "GTDT")

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 473241b5193f..1cc11d2a2a88 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -90,7 +90,7 @@ config ACPI_SPCR_TABLE

config ACPI_FPDT
bool "ACPI Firmware Performance Data Table (FPDT) support"
- depends on X86_64
+ depends on X86_64 || ARM64
help
Enable support for the Firmware Performance Data Table (FPDT).
This table provides information on the timing of the system
--
2.38.1



2022-11-14 16:25:21

by Sudeep Holla

[permalink] [raw]
Subject: Re: [PATCH] ACPI: Enable FPDT on arm64

On Wed, Nov 09, 2022 at 11:47:20AM -0600, Jeremy Linton wrote:
> FPDT provides some boot timing records useful for analyzing
> parts of the UEFI boot stack. Given the existing code works
> on arm64, and allows reading the values without utilizing
> /dev/mem it seems like a good idea to turn it on.
>

FWIW, this looks good to me.

Acked-by: Sudeep Holla <[email protected]>

Hi Rafael,

Just saw this marked as "Handled Elsewhere", do you prefer to be merged
via arm64 or other tree ? This doesn't have any arm64 changes, just Kconfig
and doc changes. Let us know.

--
Regards,
Sudeep

2022-11-14 16:56:52

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH] ACPI: Enable FPDT on arm64

On Mon, Nov 14, 2022 at 5:12 PM Sudeep Holla <[email protected]> wrote:
>
> On Wed, Nov 09, 2022 at 11:47:20AM -0600, Jeremy Linton wrote:
> > FPDT provides some boot timing records useful for analyzing
> > parts of the UEFI boot stack. Given the existing code works
> > on arm64, and allows reading the values without utilizing
> > /dev/mem it seems like a good idea to turn it on.
> >
>
> FWIW, this looks good to me.
>
> Acked-by: Sudeep Holla <[email protected]>
>
> Hi Rafael,
>
> Just saw this marked as "Handled Elsewhere", do you prefer to be merged
> via arm64 or other tree ? This doesn't have any arm64 changes, just Kconfig
> and doc changes. Let us know.

There is arm64 in the subject, though, so I think it belongs there.

2022-11-14 18:48:54

by Will Deacon

[permalink] [raw]
Subject: Re: [PATCH] ACPI: Enable FPDT on arm64

On Mon, Nov 14, 2022 at 05:16:59PM +0100, Rafael J. Wysocki wrote:
> On Mon, Nov 14, 2022 at 5:12 PM Sudeep Holla <[email protected]> wrote:
> >
> > On Wed, Nov 09, 2022 at 11:47:20AM -0600, Jeremy Linton wrote:
> > > FPDT provides some boot timing records useful for analyzing
> > > parts of the UEFI boot stack. Given the existing code works
> > > on arm64, and allows reading the values without utilizing
> > > /dev/mem it seems like a good idea to turn it on.
> > >
> >
> > FWIW, this looks good to me.
> >
> > Acked-by: Sudeep Holla <[email protected]>
> >
> > Hi Rafael,
> >
> > Just saw this marked as "Handled Elsewhere", do you prefer to be merged
> > via arm64 or other tree ? This doesn't have any arm64 changes, just Kconfig
> > and doc changes. Let us know.
>
> There is arm64 in the subject, though, so I think it belongs there.

Okey doke, I'll grab 'em.

Cheers!

Will

2022-11-14 20:35:10

by Will Deacon

[permalink] [raw]
Subject: Re: [PATCH] ACPI: Enable FPDT on arm64

On Wed, 9 Nov 2022 11:47:20 -0600, Jeremy Linton wrote:
> FPDT provides some boot timing records useful for analyzing
> parts of the UEFI boot stack. Given the existing code works
> on arm64, and allows reading the values without utilizing
> /dev/mem it seems like a good idea to turn it on.
>
>

Applied to arm64 (for-next/acpi), thanks!

[1/1] ACPI: Enable FPDT on arm64
https://git.kernel.org/arm64/c/c2465f95c4e7

Cheers,
--
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev