2007-08-09 02:23:19

by Miao Xie

Subject: [PATCH] timer:Remove clockevents_unregister_notifier

Hi everyone,

I find a function(clockevents_unregister_notifier) which is not
called by anything in tree.

Signed-off-by: Miao Xie <[email protected]>

diff -urN linux-2.6.23-rc2.orig/kernel/time/clockevents.c linux-2.6.23-rc2/kernel/time/clockevents.c
--- linux-2.6.23-rc2.orig/kernel/time/clockevents.c 2007-08-08 13:20:38.000000000 +0800
+++ linux-2.6.23-rc2/kernel/time/clockevents.c 2007-08-08 13:45:31.000000000 +0800
@@ -113,16 +113,6 @@
return ret;
}

-/**
- * clockevents_unregister_notifier - unregister a clock events change listener
- */
-void clockevents_unregister_notifier(struct notifier_block *nb)
-{
- spin_lock(&clockevents_lock);
- raw_notifier_chain_unregister(&clockevents_chain, nb);
- spin_unlock(&clockevents_lock);
-}
-
/*
* Notify about a clock event change. Called with clockevents_lock
* held.

diff -urN linux-2.6.23-rc2.orig/include/linux/clockchips.h linux-2.6.23-rc2/include/linux/clockchips.h
--- linux-2.6.23-rc2.orig/include/linux/clockchips.h 2007-08-08 13:20:29.000000000 +0800
+++ linux-2.6.23-rc2/include/linux/clockchips.h 2007-08-08 13:46:06.000000000 +0800
@@ -123,7 +123,6 @@
extern void clockevents_set_mode(struct clock_event_device *dev,
enum clock_event_mode mode);
extern int clockevents_register_notifier(struct notifier_block *nb);
-extern void clockevents_unregister_notifier(struct notifier_block *nb);
extern int clockevents_program_event(struct clock_event_device *dev,
ktime_t expires, ktime_t now);

2007-08-09 07:05:51

by Thomas Gleixner

Subject: Re: [PATCH] timer:Remove clockevents_unregister_notifier

On Thu, 2007-08-09 at 11:23 +0900, Miao Xie wrote:
> Hi everyone,
>
> I find a function(clockevents_unregister_notifier) which is not
> called by anything in tree.
>
> Signed-off-by: Miao Xie <[email protected]>

Acked-by: Thomas Gleixner <[email protected]>