by Johan Jonker

[permalink] [raw]

Subject: Re: [PATCHv3 3/9] arm64: dts: rockchip: Add base DT for rk3588 SoC

Hi,

Some more things to fix...

On 11/21/22 18:58, Sebastian Reichel wrote:
> From: Kever Yang <[email protected]>
>
> This initial version supports (single core) CPU, dma, interrupts, timers,
> UART and SDHCI. In short - everything necessary to boot Linux on this
> system on chip.
>
> The DT is split into rk3588 and rk3588s, which is a reduced version
> (i.e. with less peripherals) of the former.
>
> Signed-off-by: Yifeng Zhao <[email protected]>
> Signed-off-by: Elaine Zhang <[email protected]>
> Signed-off-by: Sugar Zhang <[email protected]>
> Signed-off-by: Kever Yang <[email protected]>
> [rebase, squash and reword commit message]
> Signed-off-by: Sebastian Reichel <[email protected]>
> ---
> arch/arm64/boot/dts/rockchip/rk3588.dtsi | 62 +
> arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 1722 +++++++++++++++++++++
> 2 files changed, 1784 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3588.dtsi
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s.dtsi
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588.dtsi b/arch/arm64/boot/dts/rockchip/rk3588.dtsi
> new file mode 100644
> index 000000000000..dd1b66176e53
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588.dtsi
> @@ -0,0 +1,62 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2021 Rockchip Electronics Co., Ltd.
> + */
> +
> +#include "rk3588s.dtsi"
> +#include "rk3588-pinctrl.dtsi"
> +
> +/ {

> + aliases {
> + ethernet0 = &gmac0;
> + };

remove

> +
> + gmac0: ethernet@fe1b0000 {
> + compatible = "rockchip,rk3588-gmac", "snps,dwmac-4.20a";
> + reg = <0x0 0xfe1b0000 0x0 0x10000>;
> + interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "macirq", "eth_wake_irq";
> + clocks = <&cru CLK_GMAC_125M>, <&cru CLK_GMAC_50M>,
> + <&cru PCLK_GMAC0>, <&cru ACLK_GMAC0>,
> + <&cru CLK_GMAC0_PTP_REF>;
> + clock-names = "stmmaceth", "clk_mac_ref",
> + "pclk_mac", "aclk_mac",
> + "ptp_ref";
> + power-domains = <&power RK3588_PD_GMAC>;
> + resets = <&cru SRST_A_GMAC0>;
> + reset-names = "stmmaceth";
> + rockchip,grf = <&sys_grf>;
> + rockchip,php-grf = <&php_grf>;
> + snps,axi-config = <&gmac0_stmmac_axi_setup>;
> + snps,mixed-burst;
> + snps,mtl-rx-config = <&gmac0_mtl_rx_setup>;
> + snps,mtl-tx-config = <&gmac0_mtl_tx_setup>;
> + snps,tso;
> + status = "disabled";
> +
> + mdio0: mdio {
> + compatible = "snps,dwmac-mdio";
> + #address-cells = <0x1>;
> + #size-cells = <0x0>;
> + };
> +
> + gmac0_stmmac_axi_setup: stmmac-axi-config {
> + snps,blen = <0 0 0 0 16 8 4>;
> + snps,wr_osr_lmt = <4>;
> + snps,rd_osr_lmt = <8>;
> + };
> +
> + gmac0_mtl_rx_setup: rx-queues-config {
> + snps,rx-queues-to-use = <2>;
> + queue0 {};
> + queue1 {};
> + };
> +
> + gmac0_mtl_tx_setup: tx-queues-config {
> + snps,tx-queues-to-use = <2>;
> + queue0 {};
> + queue1 {};
> + };
> + };
> +};
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> new file mode 100644
> index 000000000000..a2918a460112
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> @@ -0,0 +1,1722 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2021 Rockchip Electronics Co., Ltd.
> + */
> +
> +#include <dt-bindings/clock/rockchip,rk3588-cru.h>
> +#include <dt-bindings/reset/rockchip,rk3588-cru.h>
> +#include <dt-bindings/power/rk3588-power.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +

Sort includes.

> +/ {
> + compatible = "rockchip,rk3588";
> +
> + interrupt-parent = <&gic>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> +

> + aliases {
> + ethernet1 = &gmac1;
> + gpio0 = &gpio0;
> + gpio1 = &gpio1;
> + gpio2 = &gpio2;
> + gpio3 = &gpio3;
> + gpio4 = &gpio4;
> + i2c0 = &i2c0;
> + i2c1 = &i2c1;
> + i2c2 = &i2c2;
> + i2c3 = &i2c3;
> + i2c4 = &i2c4;
> + i2c5 = &i2c5;
> + i2c6 = &i2c6;
> + i2c7 = &i2c7;
> + i2c8 = &i2c8;
> + serial0 = &uart0;
> + serial1 = &uart1;
> + serial2 = &uart2;
> + serial3 = &uart3;
> + serial4 = &uart4;
> + serial5 = &uart5;
> + serial6 = &uart6;
> + serial7 = &uart7;
> + serial8 = &uart8;
> + serial9 = &uart9;
> + spi0 = &spi0;
> + spi1 = &spi1;
> + spi2 = &spi2;
> + spi3 = &spi3;
> + spi4 = &spi4;
> + pwm0 = &pwm0;
> + pwm1 = &pwm1;
> + pwm2 = &pwm2;
> + pwm3 = &pwm3;
> + pwm4 = &pwm4;
> + pwm5 = &pwm5;
> + pwm6 = &pwm6;
> + pwm7 = &pwm7;
> + pwm8 = &pwm8;
> + pwm9 = &pwm9;
> + pwm10 = &pwm10;
> + pwm11 = &pwm11;
> + pwm12 = &pwm12;
> + pwm13 = &pwm13;
> + pwm14 = &pwm14;
> + pwm15 = &pwm15;

REMOVE ALL ALIASES FROM THIS DTSI FILE!

===

Bus aliases are board specific and represent what is actually available
on headers/pins etc. These do not belong to SoC DTSI.

Comment by Krzysztof:
https://lore.kernel.org/all/[email protected]/

No, not only mmc. UART, I2C, SPI - all of these should go to the board.

Comment by Arnd:
https://lore.kernel.org/linux-rockchip/CAK8P3a25iYksubCnQb1-e5yj=crEsK37RB9Hn4ZGZMwcVVrG7g@mail.gmail.com/

Each board should have its own aliases node that describes
exactly which of the devices are wired up on that board, and
in which order. If there are connectors on the board that
are labeled in some form, then the aliases are meant to
match what is written on the board or in its documentation.

> + };
> +

> + spll: clock-0 {
> + compatible = "fixed-clock";

> + #clock-cells = <0>;

Things that start with # are only needed to interpretate the DT file, so we put them down the list as possible unless they related to a perticular property.

> + clock-frequency = <702000000>;
> + clock-output-names = "spll";
> + };
> +
> + xin24m: clock-1 {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <24000000>;
> + clock-output-names = "xin24m";
> + };
> +
> + xin32k: clock-2 {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <32768>;
> + clock-output-names = "xin32k";
> + };

Sort nodes without reg property in alfabetical order (including label) below somewhere near the timer node.

> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + cpu-map {
> + cluster0 {
> + core0 {
> + cpu = <&cpu_l0>;
> + };
> + core1 {
> + cpu = <&cpu_l1>;
> + };
> + core2 {
> + cpu = <&cpu_l2>;
> + };
> + core3 {
> + cpu = <&cpu_l3>;
> + };
> + };
> + cluster1 {
> + core0 {
> + cpu = <&cpu_b0>;
> + };
> + core1 {
> + cpu = <&cpu_b1>;
> + };
> + };
> + cluster2 {
> + core0 {
> + cpu = <&cpu_b2>;
> + };
> + core1 {
> + cpu = <&cpu_b3>;
> + };
> + };
> + };
> +
> + cpu_l0: cpu@0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a55";
> + reg = <0x0>;
> + enable-method = "psci";
> + capacity-dmips-mhz = <530>;
> + clocks = <&scmi_clk SCMI_CLK_CPUL>;
> + cpu-idle-states = <&CPU_SLEEP>;
> + i-cache-size = <32768>;
> + i-cache-line-size = <64>;
> + i-cache-sets = <128>;
> + d-cache-size = <32768>;
> + d-cache-line-size = <64>;
> + d-cache-sets = <128>;

> + next-level-cache = <&l2_cache_l0>;
> + #cooling-cells = <2>;
> + dynamic-power-coefficient = <228>;

When cpus can be power and thermal trottled then add the properties needed to all cpu nodes in that group and not just to "@0".

> + };
> +
> + cpu_l1: cpu@100 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a55";
> + reg = <0x100>;
> + enable-method = "psci";
> + capacity-dmips-mhz = <530>;
> + clocks = <&scmi_clk SCMI_CLK_CPUL>;
> + cpu-idle-states = <&CPU_SLEEP>;
> + i-cache-size = <32768>;
> + i-cache-line-size = <64>;
> + i-cache-sets = <128>;
> + d-cache-size = <32768>;
> + d-cache-line-size = <64>;
> + d-cache-sets = <128>;
> + next-level-cache = <&l2_cache_l1>;
> + };
> +
> + cpu_l2: cpu@200 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a55";
> + reg = <0x200>;
> + enable-method = "psci";
> + capacity-dmips-mhz = <530>;
> + clocks = <&scmi_clk SCMI_CLK_CPUL>;
> + cpu-idle-states = <&CPU_SLEEP>;
> + i-cache-size = <32768>;
> + i-cache-line-size = <64>;
> + i-cache-sets = <128>;
> + d-cache-size = <32768>;
> + d-cache-line-size = <64>;
> + d-cache-sets = <128>;
> + next-level-cache = <&l2_cache_l2>;
> + };
> +
> + cpu_l3: cpu@300 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a55";
> + reg = <0x300>;
> + enable-method = "psci";
> + capacity-dmips-mhz = <530>;
> + clocks = <&scmi_clk SCMI_CLK_CPUL>;
> + cpu-idle-states = <&CPU_SLEEP>;
> + i-cache-size = <32768>;
> + i-cache-line-size = <64>;
> + i-cache-sets = <128>;
> + d-cache-size = <32768>;
> + d-cache-line-size = <64>;
> + d-cache-sets = <128>;
> + next-level-cache = <&l2_cache_l3>;
> + };
> +
> + cpu_b0: cpu@400 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a76";
> + reg = <0x400>;
> + enable-method = "psci";
> + capacity-dmips-mhz = <1024>;
> + clocks = <&scmi_clk SCMI_CLK_CPUB01>;
> + cpu-idle-states = <&CPU_SLEEP>;
> + i-cache-size = <65536>;
> + i-cache-line-size = <64>;
> + i-cache-sets = <256>;
> + d-cache-size = <65536>;
> + d-cache-line-size = <64>;
> + d-cache-sets = <256>;
> + next-level-cache = <&l2_cache_b0>;
> + #cooling-cells = <2>;
> + dynamic-power-coefficient = <416>;
> + };
> +
> + cpu_b1: cpu@500 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a76";
> + reg = <0x500>;
> + enable-method = "psci";
> + capacity-dmips-mhz = <1024>;
> + clocks = <&scmi_clk SCMI_CLK_CPUB01>;
> + cpu-idle-states = <&CPU_SLEEP>;
> + i-cache-size = <65536>;
> + i-cache-line-size = <64>;
> + i-cache-sets = <256>;
> + d-cache-size = <65536>;
> + d-cache-line-size = <64>;
> + d-cache-sets = <256>;
> + next-level-cache = <&l2_cache_b1>;
> + };
> +
> + cpu_b2: cpu@600 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a76";
> + reg = <0x600>;
> + enable-method = "psci";
> + capacity-dmips-mhz = <1024>;
> + clocks = <&scmi_clk SCMI_CLK_CPUB23>;
> + cpu-idle-states = <&CPU_SLEEP>;
> + i-cache-size = <65536>;
> + i-cache-line-size = <64>;
> + i-cache-sets = <256>;
> + d-cache-size = <65536>;
> + d-cache-line-size = <64>;
> + d-cache-sets = <256>;
> + next-level-cache = <&l2_cache_b2>;
> + #cooling-cells = <2>;
> + dynamic-power-coefficient = <416>;
> + };
> +
> + cpu_b3: cpu@700 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a76";
> + reg = <0x700>;
> + enable-method = "psci";
> + capacity-dmips-mhz = <1024>;
> + clocks = <&scmi_clk SCMI_CLK_CPUB23>;
> + cpu-idle-states = <&CPU_SLEEP>;
> + i-cache-size = <65536>;
> + i-cache-line-size = <64>;
> + i-cache-sets = <256>;
> + d-cache-size = <65536>;
> + d-cache-line-size = <64>;
> + d-cache-sets = <256>;
> + next-level-cache = <&l2_cache_b3>;
> + };
> +
> + idle-states {
> + entry-method = "psci";
> + CPU_SLEEP: cpu-sleep {
> + compatible = "arm,idle-state";
> + local-timer-stop;
> + arm,psci-suspend-param = <0x0010000>;
> + entry-latency-us = <100>;
> + exit-latency-us = <120>;
> + min-residency-us = <1000>;
> + };
> + };
> +
> + l2_cache_l0: l2-cache-l0 {
> + compatible = "cache";
> + cache-size = <131072>;
> + cache-line-size = <64>;
> + cache-sets = <512>;
> + next-level-cache = <&l3_cache>;
> + };
> +
> + l2_cache_l1: l2-cache-l1 {
> + compatible = "cache";
> + cache-size = <131072>;
> + cache-line-size = <64>;
> + cache-sets = <512>;
> + next-level-cache = <&l3_cache>;
> + };
> +
> + l2_cache_l2: l2-cache-l2 {
> + compatible = "cache";
> + cache-size = <131072>;
> + cache-line-size = <64>;
> + cache-sets = <512>;
> + next-level-cache = <&l3_cache>;
> + };
> +
> + l2_cache_l3: l2-cache-l3 {
> + compatible = "cache";
> + cache-size = <131072>;
> + cache-line-size = <64>;
> + cache-sets = <512>;
> + next-level-cache = <&l3_cache>;
> + };
> +
> + l2_cache_b0: l2-cache-b0 {
> + compatible = "cache";
> + cache-size = <524288>;
> + cache-line-size = <64>;
> + cache-sets = <1024>;
> + next-level-cache = <&l3_cache>;
> + };
> +
> + l2_cache_b1: l2-cache-b1 {
> + compatible = "cache";
> + cache-size = <524288>;
> + cache-line-size = <64>;
> + cache-sets = <1024>;
> + next-level-cache = <&l3_cache>;
> + };
> +
> + l2_cache_b2: l2-cache-b2 {
> + compatible = "cache";
> + cache-size = <524288>;
> + cache-line-size = <64>;
> + cache-sets = <1024>;
> + next-level-cache = <&l3_cache>;
> + };
> +
> + l2_cache_b3: l2-cache-b3 {
> + compatible = "cache";
> + cache-size = <524288>;
> + cache-line-size = <64>;
> + cache-sets = <1024>;
> + next-level-cache = <&l3_cache>;
> + };
> +
> + l3_cache: l3-cache {
> + compatible = "cache";
> + cache-size = <3145728>;
> + cache-line-size = <64>;
> + cache-sets = <4096>;
> + };
> + };
> +
> + pmu-a55 {
> + compatible = "arm,cortex-a55-pmu";
> + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> + pmu-a76 {
> + compatible = "arm,cortex-a76-pmu";
> + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> + firmware {
> + optee: optee {
> + compatible = "linaro,optee-tz";
> + method = "smc";
> + };
> +
> + scmi: scmi {
> + compatible = "arm,scmi-smc";
> + arm,smc-id = <0x82000010>;
> + shmem = <&scmi_shmem>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + scmi_clk: protocol@14 {
> + reg = <0x14>;
> + #clock-cells = <1>;

> +

Remove empty line.

> + assigned-clocks = <&scmi_clk SCMI_CLK_CPUB01>,
> + <&scmi_clk SCMI_CLK_CPUB23>;
> + assigned-clock-rates = <1200000000>,
> + <1200000000>;
> + };
> +
> + scmi_reset: protocol@16 {
> + reg = <0x16>;
> + #reset-cells = <1>;
> + };
> + };
> + };
> +
> + psci {
> + compatible = "arm,psci-1.0";
> + method = "smc";
> + };
> +
> + timer {
> + compatible = "arm,armv8-timer";
> + interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_PPI 14 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_PPI 11 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_PPI 10 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +

> + sram@10f000 {

add label

> + compatible = "mmio-sram";
> + reg = <0x0 0x0010f000 0x0 0x100>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0 0x0 0x0010f000 0x100>;
> +
> + scmi_shmem: sram@0 {
> + compatible = "arm,scmi-shmem";
> + reg = <0x0 0x100>;
> + };
> + };
> +
> + sys_grf: syscon@fd58c000 {
> + compatible = "rockchip,rk3588-sys-grf", "syscon";
> + reg = <0x0 0xfd58c000 0x0 0x1000>;
> + };
> +
> + php_grf: syscon@fd5b0000 {
> + compatible = "rockchip,rk3588-php-grf", "syscon";
> + reg = <0x0 0xfd5b0000 0x0 0x1000>;
> + };
> +
> + ioc: syscon@fd5f0000 {
> + compatible = "rockchip,rk3588-ioc", "syscon";
> + reg = <0x0 0xfd5f0000 0x0 0x10000>;
> + };
> +

> + syssram: sram@fd600000 {

sys_ram:

> + compatible = "mmio-sram";
> + reg = <0x0 0xfd600000 0x0 0x100000>;
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x0 0xfd600000 0x100000>;
> + };
> +
> + cru: clock-controller@fd7c0000 {
> + compatible = "rockchip,rk3588-cru";
> + reg = <0x0 0xfd7c0000 0x0 0x5c000>;
> + #clock-cells = <1>;
> + #reset-cells = <1>;
> + assigned-clocks =
> + <&cru PLL_PPLL>, <&cru PLL_AUPLL>,
> + <&cru PLL_NPLL>, <&cru PLL_GPLL>,
> + <&cru ACLK_CENTER_ROOT>,
> + <&cru HCLK_CENTER_ROOT>, <&cru ACLK_CENTER_LOW_ROOT>,
> + <&cru ACLK_TOP_ROOT>, <&cru PCLK_TOP_ROOT>,
> + <&cru ACLK_LOW_TOP_ROOT>, <&cru PCLK_PMU0_ROOT>,
> + <&cru HCLK_PMU_CM0_ROOT>, <&cru ACLK_VOP>,
> + <&cru ACLK_BUS_ROOT>, <&cru CLK_150M_SRC>,
> + <&cru CLK_GPU>;
> + assigned-clock-rates =
> + <100000000>, <786432000>,
> + <850000000>, <1188000000>,
> + <702000000>,
> + <400000000>, <500000000>,
> + <800000000>, <100000000>,
> + <400000000>, <100000000>,
> + <200000000>, <500000000>,
> + <375000000>, <150000000>,
> + <200000000>;
> + rockchip,grf = <&php_grf>;
> + };
> +
> + i2c0: i2c@fd880000 {
> + compatible = "rockchip,rk3588-i2c", "rockchip,rk3399-i2c";
> + reg = <0x0 0xfd880000 0x0 0x1000>;
> + interrupts = <GIC_SPI 317 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru CLK_I2C0>, <&cru PCLK_I2C0>;
> + clock-names = "i2c", "pclk";
> + pinctrl-0 = <&i2c0m0_xfer>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + uart0: serial@fd890000 {
> + compatible = "rockchip,rk3588-uart", "snps,dw-apb-uart";
> + reg = <0x0 0xfd890000 0x0 0x100>;
> + interrupts = <GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru SCLK_UART0>, <&cru PCLK_UART0>;
> + clock-names = "baudclk", "apb_pclk";
> + dmas = <&dmac0 6>, <&dmac0 7>;

dma-names = "tx", "rx";

Add dma-names for 2 or more channels with different functionality in all uart nodes.
Regardless the implementation by a Linux driver.
Similair to clock-names.

> + pinctrl-0 = <&uart0m1_xfer>;
> + pinctrl-names = "default";

> + reg-shift = <2>;
> + reg-io-width = <4>;

Sort these properties in all uart nodes.

> + status = "disabled";
> + };
> +
> + pwm0: pwm@fd8b0000 {
> + compatible = "rockchip,rk3588-pwm", "rockchip,rk3328-pwm";
> + reg = <0x0 0xfd8b0000 0x0 0x10>;
> + clocks = <&cru CLK_PMU1PWM>, <&cru PCLK_PMU1PWM>;
> + clock-names = "pwm", "pclk";
> + pinctrl-0 = <&pwm0m0_pins>;
> + pinctrl-names = "active";
> + #pwm-cells = <3>;
> + status = "disabled";
> + };
> +
> + pwm1: pwm@fd8b0010 {
> + compatible = "rockchip,rk3588-pwm", "rockchip,rk3328-pwm";
> + reg = <0x0 0xfd8b0010 0x0 0x10>;
> + clocks = <&cru CLK_PMU1PWM>, <&cru PCLK_PMU1PWM>;
> + clock-names = "pwm", "pclk";
> + pinctrl-0 = <&pwm1m0_pins>;
> + pinctrl-names = "active";
> + #pwm-cells = <3>;
> + status = "disabled";
> + };
> +
> + pwm2: pwm@fd8b0020 {
> + compatible = "rockchip,rk3588-pwm", "rockchip,rk3328-pwm";
> + reg = <0x0 0xfd8b0020 0x0 0x10>;
> + clocks = <&cru CLK_PMU1PWM>, <&cru PCLK_PMU1PWM>;
> + clock-names = "pwm", "pclk";
> + pinctrl-0 = <&pwm2m0_pins>;
> + pinctrl-names = "active";
> + #pwm-cells = <3>;
> + status = "disabled";
> + };
> +
> + pwm3: pwm@fd8b0030 {
> + compatible = "rockchip,rk3588-pwm", "rockchip,rk3328-pwm";
> + reg = <0x0 0xfd8b0030 0x0 0x10>;
> + clocks = <&cru CLK_PMU1PWM>, <&cru PCLK_PMU1PWM>;
> + clock-names = "pwm", "pclk";
> + pinctrl-0 = <&pwm3m0_pins>;
> + pinctrl-names = "active";
> + #pwm-cells = <3>;
> + status = "disabled";
> + };
> +
> + pmu: power-management@fd8d8000 {
> + compatible = "rockchip,rk3588-pmu", "syscon", "simple-mfd";
> + reg = <0x0 0xfd8d8000 0x0 0x400>;
> +
> + power: power-controller {
> + compatible = "rockchip,rk3588-power-controller";
> + #power-domain-cells = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "okay";
> +
> + /* These power domains are grouped by VD_NPU */
> + power-domain@RK3588_PD_NPU {
> + reg = <RK3588_PD_NPU>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + #power-domain-cells = <0>;
> +
> + power-domain@RK3588_PD_NPUTOP {
> + reg = <RK3588_PD_NPUTOP>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&cru HCLK_NPU_ROOT>,
> + <&cru PCLK_NPU_ROOT>,
> + <&cru CLK_NPU_DSU0>,
> + <&cru HCLK_NPU_CM0_ROOT>;
> + pm_qos = <&qos_npu0_mwr>,
> + <&qos_npu0_mro>,
> + <&qos_mcu_npu>;
> + #power-domain-cells = <0>;
> +
> + power-domain@RK3588_PD_NPU1 {
> + reg = <RK3588_PD_NPU1>;
> + clocks = <&cru HCLK_NPU_ROOT>,
> + <&cru PCLK_NPU_ROOT>,
> + <&cru CLK_NPU_DSU0>;
> + pm_qos = <&qos_npu1>;
> + #power-domain-cells = <0>;
> + };
> + power-domain@RK3588_PD_NPU2 {
> + reg = <RK3588_PD_NPU2>;
> + clocks = <&cru HCLK_NPU_ROOT>,
> + <&cru PCLK_NPU_ROOT>,
> + <&cru CLK_NPU_DSU0>;
> + pm_qos = <&qos_npu2>;
> + #power-domain-cells = <0>;
> + };
> + };
> + };
> + /* These power domains are grouped by VD_GPU */
> + power-domain@RK3588_PD_GPU {
> + reg = <RK3588_PD_GPU>;
> + clocks = <&cru CLK_GPU>,
> + <&cru CLK_GPU_COREGROUP>,
> + <&cru CLK_GPU_STACKS>;
> + pm_qos = <&qos_gpu_m0>,
> + <&qos_gpu_m1>,
> + <&qos_gpu_m2>,
> + <&qos_gpu_m3>;
> + #power-domain-cells = <0>;
> + };
> + /* These power domains are grouped by VD_VCODEC */
> + power-domain@RK3588_PD_VCODEC {
> + reg = <RK3588_PD_VCODEC>;
> + #address-cells = <1>;
> + #size-cells = <0>;

> + #power-domain-cells = <0>;

From rockchip,power-controller.yaml:
"#power-domain-cells":
enum: [0, 1]
description:
Must be 0 for nodes representing a single PM domain and 1 for nodes
providing multiple PM domains.

Fix all #power-domain-cells properties.

> +
> + power-domain@RK3588_PD_RKVDEC0 {
> + reg = <RK3588_PD_RKVDEC0>;
> + clocks = <&cru HCLK_RKVDEC0>,
> + <&cru HCLK_VDPU_ROOT>,
> + <&cru ACLK_VDPU_ROOT>,
> + <&cru ACLK_RKVDEC0>,
> + <&cru ACLK_RKVDEC_CCU>;
> + pm_qos = <&qos_rkvdec0>;
> + #power-domain-cells = <0>;
> + };
> + power-domain@RK3588_PD_RKVDEC1 {
> + reg = <RK3588_PD_RKVDEC1>;
> + clocks = <&cru HCLK_RKVDEC1>,
> + <&cru HCLK_VDPU_ROOT>,
> + <&cru ACLK_VDPU_ROOT>,
> + <&cru ACLK_RKVDEC1>;
> + pm_qos = <&qos_rkvdec1>;
> + #power-domain-cells = <0>;
> + };
> + power-domain@RK3588_PD_VENC0 {
> + reg = <RK3588_PD_VENC0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&cru HCLK_RKVENC0>,
> + <&cru ACLK_RKVENC0>;
> + pm_qos = <&qos_rkvenc0_m0ro>,
> + <&qos_rkvenc0_m1ro>,
> + <&qos_rkvenc0_m2wo>;
> + #power-domain-cells = <0>;
> +
> + power-domain@RK3588_PD_VENC1 {
> + reg = <RK3588_PD_VENC1>;
> + clocks = <&cru HCLK_RKVENC1>,
> + <&cru HCLK_RKVENC0>,
> + <&cru ACLK_RKVENC0>,
> + <&cru ACLK_RKVENC1>;
> + pm_qos = <&qos_rkvenc1_m0ro>,
> + <&qos_rkvenc1_m1ro>,
> + <&qos_rkvenc1_m2wo>;
> + #power-domain-cells = <0>;
> + };
> + };
> + };
> + /* These power domains are grouped by VD_LOGIC */
> + power-domain@RK3588_PD_VDPU {
> + reg = <RK3588_PD_VDPU>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&cru HCLK_VDPU_ROOT>,
> + <&cru ACLK_VDPU_LOW_ROOT>,
> + <&cru ACLK_VDPU_ROOT>,
> + <&cru ACLK_JPEG_DECODER_ROOT>,
> + <&cru ACLK_IEP2P0>,
> + <&cru HCLK_IEP2P0>,
> + <&cru ACLK_JPEG_ENCODER0>,
> + <&cru HCLK_JPEG_ENCODER0>,
> + <&cru ACLK_JPEG_ENCODER1>,
> + <&cru HCLK_JPEG_ENCODER1>,
> + <&cru ACLK_JPEG_ENCODER2>,
> + <&cru HCLK_JPEG_ENCODER2>,
> + <&cru ACLK_JPEG_ENCODER3>,
> + <&cru HCLK_JPEG_ENCODER3>,
> + <&cru ACLK_JPEG_DECODER>,
> + <&cru HCLK_JPEG_DECODER>,
> + <&cru ACLK_RGA2>,
> + <&cru HCLK_RGA2>;
> + pm_qos = <&qos_iep>,
> + <&qos_jpeg_dec>,
> + <&qos_jpeg_enc0>,
> + <&qos_jpeg_enc1>,
> + <&qos_jpeg_enc2>,
> + <&qos_jpeg_enc3>,
> + <&qos_rga2_mro>,
> + <&qos_rga2_mwo>;
> + #power-domain-cells = <0>;
> +
> + power-domain@RK3588_PD_AV1 {
> + reg = <RK3588_PD_AV1>;
> + clocks = <&cru PCLK_AV1>,
> + <&cru ACLK_AV1>,
> + <&cru HCLK_VDPU_ROOT>;
> + pm_qos = <&qos_av1>;
> + #power-domain-cells = <0>;
> + };
> + power-domain@RK3588_PD_RKVDEC0 {
> + reg = <RK3588_PD_RKVDEC0>;
> + clocks = <&cru HCLK_RKVDEC0>,
> + <&cru HCLK_VDPU_ROOT>,
> + <&cru ACLK_VDPU_ROOT>,
> + <&cru ACLK_RKVDEC0>;
> + pm_qos = <&qos_rkvdec0>;
> + #power-domain-cells = <0>;
> + };
> + power-domain@RK3588_PD_RKVDEC1 {
> + reg = <RK3588_PD_RKVDEC1>;
> + clocks = <&cru HCLK_RKVDEC1>,
> + <&cru HCLK_VDPU_ROOT>,
> + <&cru ACLK_VDPU_ROOT>;
> + pm_qos = <&qos_rkvdec1>;
> + #power-domain-cells = <0>;
> + };
> + power-domain@RK3588_PD_RGA30 {
> + reg = <RK3588_PD_RGA30>;
> + clocks = <&cru ACLK_RGA3_0>,
> + <&cru HCLK_RGA3_0>;
> + pm_qos = <&qos_rga3_0>;
> + #power-domain-cells = <0>;
> + };
> + };
> + power-domain@RK3588_PD_VOP {
> + reg = <RK3588_PD_VOP>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&cru PCLK_VOP_ROOT>,
> + <&cru HCLK_VOP_ROOT>,
> + <&cru ACLK_VOP>;
> + pm_qos = <&qos_vop_m0>,
> + <&qos_vop_m1>;
> + #power-domain-cells = <0>;
> +
> + power-domain@RK3588_PD_VO0 {
> + reg = <RK3588_PD_VO0>;
> + clocks = <&cru PCLK_VO0_ROOT>,
> + <&cru PCLK_VO0_S_ROOT>,
> + <&cru HCLK_VO0_S_ROOT>,
> + <&cru ACLK_VO0_ROOT>,
> + <&cru HCLK_HDCP0>,
> + <&cru ACLK_HDCP0>,
> + <&cru HCLK_VOP_ROOT>;
> + pm_qos = <&qos_hdcp0>;
> + #power-domain-cells = <0>;
> + };
> + };
> + power-domain@RK3588_PD_VO1 {
> + reg = <RK3588_PD_VO1>;
> + clocks = <&cru PCLK_VO1_ROOT>,
> + <&cru PCLK_VO1_S_ROOT>,
> + <&cru HCLK_VO1_S_ROOT>,
> + <&cru HCLK_HDCP1>,
> + <&cru ACLK_HDCP1>,
> + <&cru ACLK_HDMIRX_ROOT>,
> + <&cru HCLK_VO1USB_TOP_ROOT>;
> + pm_qos = <&qos_hdcp1>,
> + <&qos_hdmirx>;
> + #power-domain-cells = <0>;
> + };
> + power-domain@RK3588_PD_VI {
> + reg = <RK3588_PD_VI>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&cru HCLK_VI_ROOT>,
> + <&cru PCLK_VI_ROOT>,
> + <&cru HCLK_ISP0>,
> + <&cru ACLK_ISP0>,
> + <&cru HCLK_VICAP>,
> + <&cru ACLK_VICAP>;
> + pm_qos = <&qos_isp0_mro>,
> + <&qos_isp0_mwo>,
> + <&qos_vicap_m0>,
> + <&qos_vicap_m1>;
> + #power-domain-cells = <0>;
> +
> + power-domain@RK3588_PD_ISP1 {
> + reg = <RK3588_PD_ISP1>;
> + clocks = <&cru HCLK_ISP1>,
> + <&cru ACLK_ISP1>,
> + <&cru HCLK_VI_ROOT>,
> + <&cru PCLK_VI_ROOT>;
> + pm_qos = <&qos_isp1_mwo>,
> + <&qos_isp1_mro>;
> + #power-domain-cells = <0>;
> + };
> + power-domain@RK3588_PD_FEC {
> + reg = <RK3588_PD_FEC>;
> + clocks = <&cru HCLK_FISHEYE0>,
> + <&cru ACLK_FISHEYE0>,
> + <&cru HCLK_FISHEYE1>,
> + <&cru ACLK_FISHEYE1>,
> + <&cru PCLK_VI_ROOT>;
> + pm_qos = <&qos_fisheye0>,
> + <&qos_fisheye1>;
> + #power-domain-cells = <0>;
> + };
> + };
> + power-domain@RK3588_PD_RGA31 {
> + reg = <RK3588_PD_RGA31>;
> + clocks = <&cru HCLK_RGA3_1>,
> + <&cru ACLK_RGA3_1>;
> + pm_qos = <&qos_rga3_1>;
> + #power-domain-cells = <0>;
> + };
> + power-domain@RK3588_PD_USB {
> + reg = <RK3588_PD_USB>;
> + clocks = <&cru PCLK_PHP_ROOT>,
> + <&cru ACLK_USB_ROOT>,
> + <&cru HCLK_USB_ROOT>,
> + <&cru HCLK_HOST0>,
> + <&cru HCLK_HOST_ARB0>,
> + <&cru HCLK_HOST1>,
> + <&cru HCLK_HOST_ARB1>;
> + pm_qos = <&qos_usb3_0>,
> + <&qos_usb3_1>,
> + <&qos_usb2host_0>,
> + <&qos_usb2host_1>;
> + #power-domain-cells = <0>;
> + };
> + power-domain@RK3588_PD_GMAC {
> + reg = <RK3588_PD_GMAC>;
> + clocks = <&cru PCLK_PHP_ROOT>,
> + <&cru ACLK_PCIE_ROOT>,
> + <&cru ACLK_PHP_ROOT>;
> + #power-domain-cells = <0>;
> + };
> + power-domain@RK3588_PD_PCIE {
> + reg = <RK3588_PD_PCIE>;
> + clocks = <&cru PCLK_PHP_ROOT>,
> + <&cru ACLK_PCIE_ROOT>,
> + <&cru ACLK_PHP_ROOT>;
> + #power-domain-cells = <0>;
> + };
> + power-domain@RK3588_PD_SDIO {
> + reg = <RK3588_PD_SDIO>;
> + clocks = <&cru HCLK_SDIO>,
> + <&cru HCLK_NVM_ROOT>;
> + pm_qos = <&qos_sdio>;
> + #power-domain-cells = <0>;
> + };
> + power-domain@RK3588_PD_AUDIO {
> + reg = <RK3588_PD_AUDIO>;
> + clocks = <&cru HCLK_AUDIO_ROOT>,
> + <&cru PCLK_AUDIO_ROOT>;
> + #power-domain-cells = <0>;
> + };
> + power-domain@RK3588_PD_SDMMC {
> + reg = <RK3588_PD_SDMMC>;
> + pm_qos = <&qos_sdmmc>;
> + #power-domain-cells = <0>;
> + };
> + };
> + };
> +
> + qos_gpu_m0: qos@fdf35000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf35000 0x0 0x20>;
> + };
> +
> + qos_gpu_m1: qos@fdf35200 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf35200 0x0 0x20>;
> + };
> +
> + qos_gpu_m2: qos@fdf35400 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf35400 0x0 0x20>;
> + };
> +
> + qos_gpu_m3: qos@fdf35600 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf35600 0x0 0x20>;
> + };
> +
> + qos_rga3_1: qos@fdf36000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf36000 0x0 0x20>;
> + };
> +
> + qos_sdio: qos@fdf39000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf39000 0x0 0x20>;
> + };
> +
> + qos_sdmmc: qos@fdf3d800 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf3d800 0x0 0x20>;
> + };
> +
> + qos_usb3_1: qos@fdf3e000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf3e000 0x0 0x20>;
> + };
> +
> + qos_usb3_0: qos@fdf3e200 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf3e200 0x0 0x20>;
> + };
> +
> + qos_usb2host_0: qos@fdf3e400 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf3e400 0x0 0x20>;
> + };
> +
> + qos_usb2host_1: qos@fdf3e600 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf3e600 0x0 0x20>;
> + };
> +
> + qos_fisheye0: qos@fdf40000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf40000 0x0 0x20>;
> + };
> +
> + qos_fisheye1: qos@fdf40200 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf40200 0x0 0x20>;
> + };
> +
> + qos_isp0_mro: qos@fdf40400 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf40400 0x0 0x20>;
> + };
> +
> + qos_isp0_mwo: qos@fdf40500 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf40500 0x0 0x20>;
> + };
> +
> + qos_vicap_m0: qos@fdf40600 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf40600 0x0 0x20>;
> + };
> +
> + qos_vicap_m1: qos@fdf40800 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf40800 0x0 0x20>;
> + };
> +
> + qos_isp1_mwo: qos@fdf41000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf41000 0x0 0x20>;
> + };
> +
> + qos_isp1_mro: qos@fdf41100 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf41100 0x0 0x20>;
> + };
> +
> + qos_rkvenc0_m0ro: qos@fdf60000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf60000 0x0 0x20>;
> + };
> +
> + qos_rkvenc0_m1ro: qos@fdf60200 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf60200 0x0 0x20>;
> + };
> +
> + qos_rkvenc0_m2wo: qos@fdf60400 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf60400 0x0 0x20>;
> + };
> +
> + qos_rkvenc1_m0ro: qos@fdf61000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf61000 0x0 0x20>;
> + };
> +
> + qos_rkvenc1_m1ro: qos@fdf61200 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf61200 0x0 0x20>;
> + };
> +
> + qos_rkvenc1_m2wo: qos@fdf61400 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf61400 0x0 0x20>;
> + };
> +
> + qos_rkvdec0: qos@fdf62000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf62000 0x0 0x20>;
> + };
> +
> + qos_rkvdec1: qos@fdf63000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf63000 0x0 0x20>;
> + };
> +
> + qos_av1: qos@fdf64000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf64000 0x0 0x20>;
> + };
> +
> + qos_iep: qos@fdf66000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf66000 0x0 0x20>;
> + };
> +
> + qos_jpeg_dec: qos@fdf66200 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf66200 0x0 0x20>;
> + };
> +
> + qos_jpeg_enc0: qos@fdf66400 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf66400 0x0 0x20>;
> + };
> +
> + qos_jpeg_enc1: qos@fdf66600 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf66600 0x0 0x20>;
> + };
> +
> + qos_jpeg_enc2: qos@fdf66800 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf66800 0x0 0x20>;
> + };
> +
> + qos_jpeg_enc3: qos@fdf66a00 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf66a00 0x0 0x20>;
> + };
> +
> + qos_rga2_mro: qos@fdf66c00 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf66c00 0x0 0x20>;
> + };
> +
> + qos_rga2_mwo: qos@fdf66e00 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf66e00 0x0 0x20>;
> + };
> +
> + qos_rga3_0: qos@fdf67000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf67000 0x0 0x20>;
> + };
> +
> + qos_vdpu: qos@fdf67200 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf67200 0x0 0x20>;
> + };
> +
> + qos_npu1: qos@fdf70000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf70000 0x0 0x20>;
> + };
> +
> + qos_npu2: qos@fdf71000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf71000 0x0 0x20>;
> + };
> +
> + qos_npu0_mwr: qos@fdf72000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf72000 0x0 0x20>;
> + };
> +
> + qos_npu0_mro: qos@fdf72200 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf72200 0x0 0x20>;
> + };
> +
> + qos_mcu_npu: qos@fdf72400 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf72400 0x0 0x20>;
> + };
> +
> + qos_hdcp0: qos@fdf80000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf80000 0x0 0x20>;
> + };
> +
> + qos_hdcp1: qos@fdf81000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf81000 0x0 0x20>;
> + };
> +
> + qos_hdmirx: qos@fdf81200 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf81200 0x0 0x20>;
> + };
> +
> + qos_vop_m0: qos@fdf82000 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf82000 0x0 0x20>;
> + };
> +
> + qos_vop_m1: qos@fdf82200 {
> + compatible = "rockchip,rk3588-qos", "syscon";
> + reg = <0x0 0xfdf82200 0x0 0x20>;
> + };
> +
> + gmac1: ethernet@fe1c0000 {
> + compatible = "rockchip,rk3588-gmac", "snps,dwmac-4.20a";
> + reg = <0x0 0xfe1c0000 0x0 0x10000>;
> + interrupts = <GIC_SPI 234 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 233 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "macirq", "eth_wake_irq";
> + clocks = <&cru CLK_GMAC_125M>, <&cru CLK_GMAC_50M>,
> + <&cru PCLK_GMAC1>, <&cru ACLK_GMAC1>,
> + <&cru CLK_GMAC1_PTP_REF>;
> + clock-names = "stmmaceth", "clk_mac_ref",
> + "pclk_mac", "aclk_mac",
> + "ptp_ref";
> + power-domains = <&power RK3588_PD_GMAC>;
> + resets = <&cru SRST_A_GMAC1>;
> + reset-names = "stmmaceth";
> + rockchip,grf = <&sys_grf>;
> + rockchip,php-grf = <&php_grf>;
> + snps,axi-config = <&gmac1_stmmac_axi_setup>;
> + snps,mixed-burst;
> + snps,mtl-rx-config = <&gmac1_mtl_rx_setup>;
> + snps,mtl-tx-config = <&gmac1_mtl_tx_setup>;
> + snps,tso;
> + status = "disabled";
> +
> + mdio1: mdio {
> + compatible = "snps,dwmac-mdio";
> + #address-cells = <0x1>;
> + #size-cells = <0x0>;
> + };
> +
> + gmac1_stmmac_axi_setup: stmmac-axi-config {
> + snps,blen = <0 0 0 0 16 8 4>;
> + snps,wr_osr_lmt = <4>;
> + snps,rd_osr_lmt = <8>;
> + };
> +
> + gmac1_mtl_rx_setup: rx-queues-config {
> + snps,rx-queues-to-use = <2>;
> + queue0 {};
> + queue1 {};
> + };
> +
> + gmac1_mtl_tx_setup: tx-queues-config {
> + snps,tx-queues-to-use = <2>;
> + queue0 {};
> + queue1 {};
> + };
> + };
> +
> + sdhci: mmc@fe2e0000 {
> + compatible = "rockchip,rk3588-dwcmshc";
> + reg = <0x0 0xfe2e0000 0x0 0x10000>;
> + interrupts = <GIC_SPI 205 IRQ_TYPE_LEVEL_HIGH>;
> + assigned-clocks = <&cru BCLK_EMMC>, <&cru TMCLK_EMMC>, <&cru CCLK_EMMC>;
> + assigned-clock-rates = <200000000>, <24000000>, <200000000>;
> + clocks = <&cru CCLK_EMMC>, <&cru HCLK_EMMC>,
> + <&cru ACLK_EMMC>, <&cru BCLK_EMMC>,
> + <&cru TMCLK_EMMC>;
> + clock-names = "core", "bus", "axi", "block", "timer";
> + max-frequency = <200000000>;
> + resets = <&cru SRST_C_EMMC>, <&cru SRST_H_EMMC>,
> + <&cru SRST_A_EMMC>, <&cru SRST_B_EMMC>,
> + <&cru SRST_T_EMMC>;
> + reset-names = "core", "bus", "axi", "block", "timer";
> + status = "disabled";
> + };
> +
> + gic: interrupt-controller@fe600000 {
> + compatible = "arm,gic-v3";
> + reg = <0x0 0xfe600000 0 0x10000>, /* GICD */
> + <0x0 0xfe680000 0 0x100000>; /* GICR */
> + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-controller;
> + #interrupt-cells = <3>;
> + mbi-alias = <0x0 0xfe610000>;
> + mbi-ranges = <424 56>;
> + msi-controller;
> +
> + ppi-partitions {
> + interrupt-partition-0 {
> + affinity = <
> + &cpu_l0 &cpu_l1 &cpu_l2 &cpu_l3
> + &cpu_b0 &cpu_b1 &cpu_b2 &cpu_b3
> + >;
> + };
> + };
> + };
> +
> + dmac0: dma-controller@fea10000 {
> + compatible = "arm,pl330", "arm,primecell";
> + reg = <0x0 0xfea10000 0x0 0x4000>;
> + interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;

> + clocks = <&cru ACLK_DMAC0>;
> + clock-names = "apb_pclk";
> + #dma-cells = <1>;
> + arm,pl330-periph-burst;

Sort all dma nodes.

> + };
> +
> + dmac1: dma-controller@fea30000 {
> + compatible = "arm,pl330", "arm,primecell";
> + reg = <0x0 0xfea30000 0x0 0x4000>;
> + interrupts = <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru ACLK_DMAC1>;
> + clock-names = "apb_pclk";
> + #dma-cells = <1>;
> + arm,pl330-periph-burst;
> + };
> +
> + i2c1: i2c@fea90000 {
> + compatible = "rockchip,rk3588-i2c", "rockchip,rk3399-i2c";
> + reg = <0x0 0xfea90000 0x0 0x1000>;
> + clocks = <&cru CLK_I2C1>, <&cru PCLK_I2C1>;
> + clock-names = "i2c", "pclk";
> + interrupts = <GIC_SPI 318 IRQ_TYPE_LEVEL_HIGH>;
> + pinctrl-0 = <&i2c1m0_xfer>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + i2c2: i2c@feaa0000 {
> + compatible = "rockchip,rk3588-i2c", "rockchip,rk3399-i2c";
> + reg = <0x0 0xfeaa0000 0x0 0x1000>;
> + clocks = <&cru CLK_I2C2>, <&cru PCLK_I2C2>;
> + clock-names = "i2c", "pclk";
> + interrupts = <GIC_SPI 319 IRQ_TYPE_LEVEL_HIGH>;
> + pinctrl-0 = <&i2c2m0_xfer>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + i2c3: i2c@feab0000 {
> + compatible = "rockchip,rk3588-i2c", "rockchip,rk3399-i2c";
> + reg = <0x0 0xfeab0000 0x0 0x1000>;
> + clocks = <&cru CLK_I2C3>, <&cru PCLK_I2C3>;
> + clock-names = "i2c", "pclk";
> + interrupts = <GIC_SPI 320 IRQ_TYPE_LEVEL_HIGH>;
> + pinctrl-0 = <&i2c3m0_xfer>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + i2c4: i2c@feac0000 {
> + compatible = "rockchip,rk3588-i2c", "rockchip,rk3399-i2c";
> + reg = <0x0 0xfeac0000 0x0 0x1000>;
> + clocks = <&cru CLK_I2C4>, <&cru PCLK_I2C4>;
> + clock-names = "i2c", "pclk";
> + interrupts = <GIC_SPI 321 IRQ_TYPE_LEVEL_HIGH>;
> + pinctrl-0 = <&i2c4m0_xfer>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + i2c5: i2c@fead0000 {
> + compatible = "rockchip,rk3588-i2c", "rockchip,rk3399-i2c";
> + reg = <0x0 0xfead0000 0x0 0x1000>;
> + clocks = <&cru CLK_I2C5>, <&cru PCLK_I2C5>;
> + clock-names = "i2c", "pclk";
> + interrupts = <GIC_SPI 322 IRQ_TYPE_LEVEL_HIGH>;
> + pinctrl-0 = <&i2c5m0_xfer>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + spi0: spi@feb00000 {
> + compatible = "rockchip,rk3588-spi", "rockchip,rk3066-spi";
> + reg = <0x0 0xfeb00000 0x0 0x1000>;
> + interrupts = <GIC_SPI 326 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru CLK_SPI0>, <&cru PCLK_SPI0>;
> + clock-names = "spiclk", "apb_pclk";
> + dmas = <&dmac0 14>, <&dmac0 15>;
> + dma-names = "tx", "rx";
> + num-cs = <2>;
> + pinctrl-0 = <&spi0m0_cs0 &spi0m0_cs1 &spi0m0_pins>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + spi1: spi@feb10000 {
> + compatible = "rockchip,rk3588-spi", "rockchip,rk3066-spi";
> + reg = <0x0 0xfeb10000 0x0 0x1000>;
> + interrupts = <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru CLK_SPI1>, <&cru PCLK_SPI1>;
> + clock-names = "spiclk", "apb_pclk";
> + dmas = <&dmac0 16>, <&dmac0 17>;
> + dma-names = "tx", "rx";
> + num-cs = <2>;
> + pinctrl-0 = <&spi1m1_cs0 &spi1m1_cs1 &spi1m1_pins>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + spi2: spi@feb20000 {
> + compatible = "rockchip,rk3588-spi", "rockchip,rk3066-spi";
> + reg = <0x0 0xfeb20000 0x0 0x1000>;
> + interrupts = <GIC_SPI 328 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru CLK_SPI2>, <&cru PCLK_SPI2>;
> + clock-names = "spiclk", "apb_pclk";
> + dmas = <&dmac1 15>, <&dmac1 16>;
> + dma-names = "tx", "rx";
> + num-cs = <2>;
> + pinctrl-0 = <&spi2m2_cs0 &spi2m2_cs1 &spi2m2_pins>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + spi3: spi@feb30000 {
> + compatible = "rockchip,rk3588-spi", "rockchip,rk3066-spi";
> + reg = <0x0 0xfeb30000 0x0 0x1000>;
> + interrupts = <GIC_SPI 329 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru CLK_SPI3>, <&cru PCLK_SPI3>;
> + clock-names = "spiclk", "apb_pclk";
> + dmas = <&dmac1 17>, <&dmac1 18>;
> + dma-names = "tx", "rx";
> + num-cs = <2>;
> + pinctrl-0 = <&spi3m1_cs0 &spi3m1_cs1 &spi3m1_pins>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + uart1: serial@feb40000 {
> + compatible = "rockchip,rk3588-uart", "snps,dw-apb-uart";
> + reg = <0x0 0xfeb40000 0x0 0x100>;
> + interrupts = <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru SCLK_UART1>, <&cru PCLK_UART1>;
> + clock-names = "baudclk", "apb_pclk";
> + dmas = <&dmac0 8>, <&dmac0 9>;
> + pinctrl-0 = <&uart1m1_xfer>;
> + pinctrl-names = "default";
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + status = "disabled";
> + };
> +
> + uart2: serial@feb50000 {
> + compatible = "rockchip,rk3588-uart", "snps,dw-apb-uart";
> + reg = <0x0 0xfeb50000 0x0 0x100>;
> + interrupts = <GIC_SPI 333 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru SCLK_UART2>, <&cru PCLK_UART2>;
> + clock-names = "baudclk", "apb_pclk";
> + dmas = <&dmac0 10>, <&dmac0 11>;
> + pinctrl-0 = <&uart2m1_xfer>;
> + pinctrl-names = "default";
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + status = "disabled";
> + };
> +
> + uart3: serial@feb60000 {
> + compatible = "rockchip,rk3588-uart", "snps,dw-apb-uart";
> + reg = <0x0 0xfeb60000 0x0 0x100>;
> + interrupts = <GIC_SPI 334 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru SCLK_UART3>, <&cru PCLK_UART3>;
> + clock-names = "baudclk", "apb_pclk";
> + dmas = <&dmac0 12>, <&dmac0 13>;
> + pinctrl-0 = <&uart3m1_xfer>;
> + pinctrl-names = "default";
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + status = "disabled";
> + };
> +
> + uart4: serial@feb70000 {
> + compatible = "rockchip,rk3588-uart", "snps,dw-apb-uart";
> + reg = <0x0 0xfeb70000 0x0 0x100>;
> + interrupts = <GIC_SPI 335 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru SCLK_UART4>, <&cru PCLK_UART4>;
> + clock-names = "baudclk", "apb_pclk";
> + dmas = <&dmac1 9>, <&dmac1 10>;
> + pinctrl-0 = <&uart4m1_xfer>;
> + pinctrl-names = "default";
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + status = "disabled";
> + };
> +
> + uart5: serial@feb80000 {
> + compatible = "rockchip,rk3588-uart", "snps,dw-apb-uart";
> + reg = <0x0 0xfeb80000 0x0 0x100>;
> + interrupts = <GIC_SPI 336 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru SCLK_UART5>, <&cru PCLK_UART5>;
> + clock-names = "baudclk", "apb_pclk";
> + dmas = <&dmac1 11>, <&dmac1 12>;
> + pinctrl-0 = <&uart5m1_xfer>;
> + pinctrl-names = "default";
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + status = "disabled";
> + };
> +
> + uart6: serial@feb90000 {
> + compatible = "rockchip,rk3588-uart", "snps,dw-apb-uart";
> + reg = <0x0 0xfeb90000 0x0 0x100>;
> + interrupts = <GIC_SPI 337 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru SCLK_UART6>, <&cru PCLK_UART6>;
> + clock-names = "baudclk", "apb_pclk";
> + dmas = <&dmac1 13>, <&dmac1 14>;
> + pinctrl-0 = <&uart6m1_xfer>;
> + pinctrl-names = "default";
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + status = "disabled";
> + };
> +
> + uart7: serial@feba0000 {
> + compatible = "rockchip,rk3588-uart", "snps,dw-apb-uart";
> + reg = <0x0 0xfeba0000 0x0 0x100>;
> + interrupts = <GIC_SPI 338 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru SCLK_UART7>, <&cru PCLK_UART7>;
> + clock-names = "baudclk", "apb_pclk";
> + dmas = <&dmac2 7>, <&dmac2 8>;
> + pinctrl-0 = <&uart7m1_xfer>;
> + pinctrl-names = "default";
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + status = "disabled";
> + };
> +
> + uart8: serial@febb0000 {
> + compatible = "rockchip,rk3588-uart", "snps,dw-apb-uart";
> + reg = <0x0 0xfebb0000 0x0 0x100>;
> + interrupts = <GIC_SPI 339 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru SCLK_UART8>, <&cru PCLK_UART8>;
> + clock-names = "baudclk", "apb_pclk";
> + dmas = <&dmac2 9>, <&dmac2 10>;
> + pinctrl-0 = <&uart8m1_xfer>;
> + pinctrl-names = "default";
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + status = "disabled";
> + };
> +
> + uart9: serial@febc0000 {
> + compatible = "rockchip,rk3588-uart", "snps,dw-apb-uart";
> + reg = <0x0 0xfebc0000 0x0 0x100>;
> + interrupts = <GIC_SPI 340 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru SCLK_UART9>, <&cru PCLK_UART9>;
> + clock-names = "baudclk", "apb_pclk";
> + dmas = <&dmac2 11>, <&dmac2 12>;
> + pinctrl-0 = <&uart9m1_xfer>;
> + pinctrl-names = "default";
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + status = "disabled";
> + };
> +
> + pwm4: pwm@febd0000 {
> + compatible = "rockchip,rk3588-pwm", "rockchip,rk3328-pwm";
> + reg = <0x0 0xfebd0000 0x0 0x10>;
> + clocks = <&cru CLK_PWM1>, <&cru PCLK_PWM1>;
> + clock-names = "pwm", "pclk";
> + pinctrl-0 = <&pwm4m0_pins>;
> + pinctrl-names = "active";
> + #pwm-cells = <3>;
> + status = "disabled";
> + };
> +
> + pwm5: pwm@febd0010 {
> + compatible = "rockchip,rk3588-pwm", "rockchip,rk3328-pwm";
> + reg = <0x0 0xfebd0010 0x0 0x10>;
> + clocks = <&cru CLK_PWM1>, <&cru PCLK_PWM1>;
> + clock-names = "pwm", "pclk";
> + pinctrl-0 = <&pwm5m0_pins>;
> + pinctrl-names = "active";
> + #pwm-cells = <3>;
> + status = "disabled";
> + };
> +
> + pwm6: pwm@febd0020 {
> + compatible = "rockchip,rk3588-pwm", "rockchip,rk3328-pwm";
> + reg = <0x0 0xfebd0020 0x0 0x10>;
> + clocks = <&cru CLK_PWM1>, <&cru PCLK_PWM1>;
> + clock-names = "pwm", "pclk";
> + pinctrl-0 = <&pwm6m0_pins>;
> + pinctrl-names = "active";
> + #pwm-cells = <3>;
> + status = "disabled";
> + };
> +
> + pwm7: pwm@febd0030 {
> + compatible = "rockchip,rk3588-pwm", "rockchip,rk3328-pwm";
> + reg = <0x0 0xfebd0030 0x0 0x10>;
> + clocks = <&cru CLK_PWM1>, <&cru PCLK_PWM1>;
> + clock-names = "pwm", "pclk";
> + pinctrl-0 = <&pwm7m0_pins>;
> + pinctrl-names = "active";
> + #pwm-cells = <3>;
> + status = "disabled";
> + };
> +
> + pwm8: pwm@febe0000 {
> + compatible = "rockchip,rk3588-pwm", "rockchip,rk3328-pwm";
> + reg = <0x0 0xfebe0000 0x0 0x10>;
> + clocks = <&cru CLK_PWM2>, <&cru PCLK_PWM2>;
> + clock-names = "pwm", "pclk";
> + pinctrl-0 = <&pwm8m0_pins>;
> + pinctrl-names = "active";
> + #pwm-cells = <3>;
> + status = "disabled";
> + };
> +
> + pwm9: pwm@febe0010 {
> + compatible = "rockchip,rk3588-pwm", "rockchip,rk3328-pwm";
> + reg = <0x0 0xfebe0010 0x0 0x10>;
> + clocks = <&cru CLK_PWM2>, <&cru PCLK_PWM2>;
> + clock-names = "pwm", "pclk";
> + pinctrl-0 = <&pwm9m0_pins>;
> + pinctrl-names = "active";
> + #pwm-cells = <3>;
> + status = "disabled";
> + };
> +
> + pwm10: pwm@febe0020 {
> + compatible = "rockchip,rk3588-pwm", "rockchip,rk3328-pwm";
> + reg = <0x0 0xfebe0020 0x0 0x10>;
> + clocks = <&cru CLK_PWM2>, <&cru PCLK_PWM2>;
> + clock-names = "pwm", "pclk";
> + pinctrl-0 = <&pwm10m0_pins>;
> + pinctrl-names = "active";
> + #pwm-cells = <3>;
> + status = "disabled";
> + };
> +
> + pwm11: pwm@febe0030 {
> + compatible = "rockchip,rk3588-pwm", "rockchip,rk3328-pwm";
> + reg = <0x0 0xfebe0030 0x0 0x10>;

> + #pwm-cells = <3>;
> + pinctrl-names = "active";
> + pinctrl-0 = <&pwm11m0_pins>;
> + clocks = <&cru CLK_PWM2>, <&cru PCLK_PWM2>;
> + clock-names = "pwm", "pclk";

Sort pwm11 properties just like all all other pwm nodes.

> + status = "disabled";
> + };
> +
> + pwm12: pwm@febf0000 {
> + compatible = "rockchip,rk3588-pwm", "rockchip,rk3328-pwm";
> + reg = <0x0 0xfebf0000 0x0 0x10>;
> + clocks = <&cru CLK_PWM3>, <&cru PCLK_PWM3>;
> + clock-names = "pwm", "pclk";
> + pinctrl-0 = <&pwm12m0_pins>;
> + pinctrl-names = "active";
> + #pwm-cells = <3>;
> + status = "disabled";
> + };
> +
> + pwm13: pwm@febf0010 {
> + compatible = "rockchip,rk3588-pwm", "rockchip,rk3328-pwm";
> + reg = <0x0 0xfebf0010 0x0 0x10>;
> + clocks = <&cru CLK_PWM3>, <&cru PCLK_PWM3>;
> + clock-names = "pwm", "pclk";
> + pinctrl-0 = <&pwm13m0_pins>;
> + pinctrl-names = "active";
> + #pwm-cells = <3>;
> + status = "disabled";
> + };
> +
> + pwm14: pwm@febf0020 {
> + compatible = "rockchip,rk3588-pwm", "rockchip,rk3328-pwm";
> + reg = <0x0 0xfebf0020 0x0 0x10>;
> + clocks = <&cru CLK_PWM3>, <&cru PCLK_PWM3>;
> + clock-names = "pwm", "pclk";
> + pinctrl-0 = <&pwm14m0_pins>;
> + pinctrl-names = "active";
> + #pwm-cells = <3>;
> + status = "disabled";
> + };
> +
> + pwm15: pwm@febf0030 {
> + compatible = "rockchip,rk3588-pwm", "rockchip,rk3328-pwm";
> + reg = <0x0 0xfebf0030 0x0 0x10>;
> + clocks = <&cru CLK_PWM3>, <&cru PCLK_PWM3>;
> + clock-names = "pwm", "pclk";
> + pinctrl-0 = <&pwm15m0_pins>;
> + pinctrl-names = "active";
> + #pwm-cells = <3>;
> + status = "disabled";
> + };
> +
> + i2c6: i2c@fec80000 {
> + compatible = "rockchip,rk3588-i2c", "rockchip,rk3399-i2c";
> + reg = <0x0 0xfec80000 0x0 0x1000>;
> + clocks = <&cru CLK_I2C6>, <&cru PCLK_I2C6>;
> + clock-names = "i2c", "pclk";
> + interrupts = <GIC_SPI 323 IRQ_TYPE_LEVEL_HIGH>;
> + pinctrl-0 = <&i2c6m0_xfer>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + i2c7: i2c@fec90000 {
> + compatible = "rockchip,rk3588-i2c", "rockchip,rk3399-i2c";
> + reg = <0x0 0xfec90000 0x0 0x1000>;
> + clocks = <&cru CLK_I2C7>, <&cru PCLK_I2C7>;
> + clock-names = "i2c", "pclk";
> + interrupts = <GIC_SPI 324 IRQ_TYPE_LEVEL_HIGH>;
> + pinctrl-0 = <&i2c7m0_xfer>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + i2c8: i2c@feca0000 {
> + compatible = "rockchip,rk3588-i2c", "rockchip,rk3399-i2c";
> + reg = <0x0 0xfeca0000 0x0 0x1000>;
> + clocks = <&cru CLK_I2C8>, <&cru PCLK_I2C8>;
> + clock-names = "i2c", "pclk";
> + interrupts = <GIC_SPI 325 IRQ_TYPE_LEVEL_HIGH>;
> + pinctrl-0 = <&i2c8m0_xfer>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + spi4: spi@fecb0000 {
> + compatible = "rockchip,rk3588-spi", "rockchip,rk3066-spi";
> + reg = <0x0 0xfecb0000 0x0 0x1000>;
> + interrupts = <GIC_SPI 330 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru CLK_SPI4>, <&cru PCLK_SPI4>;
> + clock-names = "spiclk", "apb_pclk";
> + dmas = <&dmac2 13>, <&dmac2 14>;
> + dma-names = "tx", "rx";
> + num-cs = <2>;
> + pinctrl-0 = <&spi4m0_cs0 &spi4m0_cs1 &spi4m0_pins>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
> +
> + dmac2: dma-controller@fed10000 {
> + compatible = "arm,pl330", "arm,primecell";
> + reg = <0x0 0xfed10000 0x0 0x4000>;
> + interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru ACLK_DMAC2>;
> + clock-names = "apb_pclk";
> + #dma-cells = <1>;
> + arm,pl330-periph-burst;
> + };
> +
> + pinctrl: pinctrl {
> + compatible = "rockchip,rk3588-pinctrl";
> + rockchip,grf = <&ioc>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + gpio0: gpio@fd8a0000 {
> + compatible = "rockchip,gpio-bank";
> + reg = <0x0 0xfd8a0000 0x0 0x100>;
> + interrupts = <GIC_SPI 277 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru PCLK_GPIO0>, <&cru DBCLK_GPIO0>;
> + gpio-controller;
> + gpio-ranges = <&pinctrl 0 0 32>;
> + interrupt-controller;
> + #gpio-cells = <2>;
> + #interrupt-cells = <2>;
> + };
> +
> + gpio1: gpio@fec20000 {
> + compatible = "rockchip,gpio-bank";
> + reg = <0x0 0xfec20000 0x0 0x100>;
> + interrupts = <GIC_SPI 278 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru PCLK_GPIO1>, <&cru DBCLK_GPIO1>;
> + gpio-controller;
> + gpio-ranges = <&pinctrl 0 32 32>;
> + interrupt-controller;
> + #gpio-cells = <2>;
> + #interrupt-cells = <2>;
> + };
> +
> + gpio2: gpio@fec30000 {
> + compatible = "rockchip,gpio-bank";
> + reg = <0x0 0xfec30000 0x0 0x100>;
> + interrupts = <GIC_SPI 279 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru PCLK_GPIO2>, <&cru DBCLK_GPIO2>;
> + gpio-controller;
> + gpio-ranges = <&pinctrl 0 64 32>;
> + interrupt-controller;
> + #gpio-cells = <2>;
> + #interrupt-cells = <2>;
> + };
> +
> + gpio3: gpio@fec40000 {
> + compatible = "rockchip,gpio-bank";
> + reg = <0x0 0xfec40000 0x0 0x100>;
> + interrupts = <GIC_SPI 280 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru PCLK_GPIO3>, <&cru DBCLK_GPIO3>;
> + gpio-controller;
> + gpio-ranges = <&pinctrl 0 96 32>;
> + interrupt-controller;
> + #gpio-cells = <2>;
> + #interrupt-cells = <2>;
> + };
+
> + gpio4: gpio@fec50000 {
> + compatible = "rockchip,gpio-bank";
> + reg = <0x0 0xfec50000 0x0 0x100>;
> + interrupts = <GIC_SPI 281 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru PCLK_GPIO4>, <&cru DBCLK_GPIO4>;
> + gpio-controller;
> + gpio-ranges = <&pinctrl 0 128 32>;
> + interrupt-controller;
> + #gpio-cells = <2>;
> + #interrupt-cells = <2>;
> + };
> + };
> +};
> +
> +#include "rk3588s-pinctrl.dtsi"

2022-11-23 10:04:42

by Michael Riesch

[permalink] [raw]

Subject: Re: [PATCHv3 7/9] arm64: dts: rockchip: Add rk3588-evb1 board

Hi Sebastian,

On 11/21/22 18:58, Sebastian Reichel wrote:
> From: Kever Yang <[email protected]>
>
> Add board file for the RK3588 evaluation board. While the hardware
> offers plenty of peripherals and connectivity this basic implementation
> just handles things required to successfully boot Linux from eMMC,
> connect via UART or Ethernet.
>
> Signed-off-by: Kever Yang <[email protected]>
> [rebase, update commit message, use EVB1 for SoC bringup]
> Signed-off-by: Sebastian Reichel <[email protected]>
> ---
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../boot/dts/rockchip/rk3588-evb1-v10.dts | 159 ++++++++++++++++++
> 2 files changed, 160 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index 8c15593c0ca4..12ed53de11eb 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -72,3 +72,4 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-rock-3a.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-evb1-v10.dtb
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> new file mode 100644
> index 000000000000..e6c5df2163ba
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> @@ -0,0 +1,159 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2021 Rockchip Electronics Co., Ltd.
> + *
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/pinctrl/rockchip.h>
> +#include "rk3588.dtsi"
> +
> +/ {
> + model = "Rockchip RK3588 EVB1 V10 Board";
> + compatible = "rockchip,rk3588-evb1-v10", "rockchip,rk3588";
> +
> + aliases {
> + mmc0 = &sdhci;
> + };
> +
> + chosen {
> + stdout-path = "serial2:1500000n8";
> + };
> +
> + vcc12v_dcin: regulator-vcc12v-dcin {

I believe new regulator node names should have a "-regulator" suffix.

This comment also holds for the rock-5b patch.

> + compatible = "regulator-fixed";
> + regulator-name = "vcc12v_dcin";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <12000000>;
> + regulator-max-microvolt = <12000000>;
> + };
> +
> + vcc5v0_sys: regulator-vcc5v0-sys {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc5v0_sys";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + vin-supply = <&vcc12v_dcin>;
> + };
> +
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + brightness-levels = <
> + 0 20 20 21 21 22 22 23
> + 23 24 24 25 25 26 26 27
> + 27 28 28 29 29 30 30 31
> + 31 32 32 33 33 34 34 35
> + 35 36 36 37 37 38 38 39
> + 40 41 42 43 44 45 46 47
> + 48 49 50 51 52 53 54 55
> + 56 57 58 59 60 61 62 63
> + 64 65 66 67 68 69 70 71
> + 72 73 74 75 76 77 78 79
> + 80 81 82 83 84 85 86 87
> + 88 89 90 91 92 93 94 95
> + 96 97 98 99 100 101 102 103
> + 104 105 106 107 108 109 110 111
> + 112 113 114 115 116 117 118 119
> + 120 121 122 123 124 125 126 127
> + 128 129 130 131 132 133 134 135
> + 136 137 138 139 140 141 142 143
> + 144 145 146 147 148 149 150 151
> + 152 153 154 155 156 157 158 159
> + 160 161 162 163 164 165 166 167
> + 168 169 170 171 172 173 174 175
> + 176 177 178 179 180 181 182 183
> + 184 185 186 187 188 189 190 191
> + 192 193 194 195 196 197 198 199
> + 200 201 202 203 204 205 206 207
> + 208 209 210 211 212 213 214 215
> + 216 217 218 219 220 221 222 223
> + 224 225 226 227 228 229 230 231
> + 232 233 234 235 236 237 238 239
> + 240 241 242 243 244 245 246 247
> + 248 249 250 251 252 253 254 255
> + >;
> + default-brightness-level = <200>;
> +
> + pwms = <&pwm2 0 25000 0>;
> + power-supply = <&vcc12v_dcin>;
> + };
> +};
> +
> +&gmac0 {
> + phy-mode = "rgmii-rxid";
> + clock_in_out = "output";
> +
> + snps,reset-gpio = <&gpio4 RK_PB3 GPIO_ACTIVE_LOW>;
> + snps,reset-active-low;
> + /* Reset time is 20ms, 100ms for rtl8211f */
> + snps,reset-delays-us = <0 20000 100000>;

These three properties are deprecated according to snps,dwmac.yaml ->
the reset GPIO should be implemented in the Ethernet PHY node.

This comment also holds for the rock-5a patch.

Best regards,
Michael

> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&gmac0_miim
> + &gmac0_tx_bus2
> + &gmac0_rx_bus2
> + &gmac0_rgmii_clk
> + &gmac0_rgmii_bus>;
> +
> + tx_delay = <0x43>;
> + rx_delay = <0x00>;
> +
> + phy-handle = <&rgmii_phy>;
> + status = "okay";
> +};
> +
> +&i2c2 {
> + status = "okay";
> +
> + hym8563: rtc@51 {
> + compatible = "haoyu,hym8563";
> + reg = <0x51>;
> + #clock-cells = <0>;
> + clock-output-names = "hym8563";
> + pinctrl-names = "default";
> + pinctrl-0 = <&hym8563_int>;
> + interrupt-parent = <&gpio0>;
> + interrupts = <RK_PD4 IRQ_TYPE_LEVEL_LOW>;
> + wakeup-source;
> + };
> +};
> +
> +&mdio0 {
> + rgmii_phy: ethernet-phy@1 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0x1>;
> + };
> +};
> +
> +&pinctrl {
> + hym8563 {
> + hym8563_int: hym8563-int {
> + rockchip,pins = <0 RK_PD4 RK_FUNC_GPIO &pcfg_pull_up>;
> + };
> + };
> +};
> +
> +&pwm2 {
> + status = "okay";
> +};
> +
> +&sdhci {
> + bus-width = <8>;
> + no-sdio;
> + no-sd;
> + non-removable;
> + max-frequency = <200000000>;
> + mmc-hs400-1_8v;
> + mmc-hs400-enhanced-strobe;
> + status = "okay";
> +};
> +
> +&uart2 {
> + pinctrl-0 = <&uart2m0_xfer>;
> + status = "okay";
> +};