2022-12-06 17:18:28

by Dario Binacchi

Subject: [PATCH] ARM: BCM63xx: remove useless goto statement

Between the 'goto out' statement and the 'out' label there are no other
statements, so it is useless to check the return value of the
bcm63xx_pmb_power_on_cpu() function. Then, let's remove the statements
that are unnecessarily executed.

Signed-off-by: Dario Binacchi <[email protected]>

---

arch/arm/mach-bcm/bcm63xx_smp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/mach-bcm/bcm63xx_smp.c b/arch/arm/mach-bcm/bcm63xx_smp.c
index 641e1f8fcf5e..18d0ffc621aa 100644
--- a/arch/arm/mach-bcm/bcm63xx_smp.c
+++ b/arch/arm/mach-bcm/bcm63xx_smp.c
@@ -142,8 +142,7 @@ static int bcm63138_smp_boot_secondary(unsigned int cpu,
*/
ret = bcm63xx_pmb_power_on_cpu(dn);
of_node_put(dn);
- if (ret)
- goto out;
+
out:
iounmap(bootlut_base);

--
2.32.0

2022-12-12 23:45:28

by Florian Fainelli

Subject: Re: [PATCH] ARM: BCM63xx: remove useless goto statement

On Tue, 6 Dec 2022 18:09:13 +0100, Dario Binacchi <[email protected]> wrote:
> Between the 'goto out' statement and the 'out' label there are no other
> statements, so it is useless to check the return value of the
> bcm63xx_pmb_power_on_cpu() function. Then, let's remove the statements
> that are unnecessarily executed.
>
> Signed-off-by: Dario Binacchi <[email protected]>
>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/soc/next, thanks!
--
Florian