2022-12-07 10:01:09

by Guo Ren

Subject: [PATCH] riscv: Fixup compile error with !MMU

From: Guo Ren <[email protected]>

Current nommu_virt_defconfig can't compile:

In file included from
arch/riscv/kernel/crash_core.c:3:
arch/riscv/kernel/crash_core.c:
In function 'arch_crash_save_vmcoreinfo':
arch/riscv/kernel/crash_core.c:8:27:
error: 'VA_BITS' undeclared (first use in this function)
8 | VMCOREINFO_NUMBER(VA_BITS);
| ^~~~~~~

Add MMU dependency for KEXEC_FILE.

Fixes: 6261586e0c91 ("RISC-V: Add kexec_file support")
Reported-by: Conor Dooley <[email protected]>
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Guo Ren <[email protected]>
Signed-off-by: Guo Ren <[email protected]>
---
arch/riscv/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
index ef8d66de5f38..91319044fd13 100644
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -496,7 +496,7 @@ config KEXEC_FILE
select KEXEC_CORE
select KEXEC_ELF
select HAVE_IMA_KEXEC if IMA
- depends on 64BIT
+ depends on 64BIT && MMU
help
This is new version of kexec system call. This system call is
file based and takes file descriptors as system call argument
--
2.36.1

2022-12-13 17:58:52

by patchwork-bot+linux-riscv

Subject: Re: [PATCH] riscv: Fixup compile error with !MMU

Hello:

This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <[email protected]>:

On Wed, 7 Dec 2022 04:11:12 -0500 you wrote:
> From: Guo Ren <[email protected]>
>
> Current nommu_virt_defconfig can't compile:
>
> In file included from
> arch/riscv/kernel/crash_core.c:3:
> arch/riscv/kernel/crash_core.c:
> In function 'arch_crash_save_vmcoreinfo':
> arch/riscv/kernel/crash_core.c:8:27:
> error: 'VA_BITS' undeclared (first use in this function)
> 8 | VMCOREINFO_NUMBER(VA_BITS);
> | ^~~~~~~
>
> [...]

Here is the summary with links:
- riscv: Fixup compile error with !MMU
https://git.kernel.org/riscv/c/c528ef0888b7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

2022-12-13 18:01:11

by Palmer Dabbelt

Subject: Re: [PATCH] riscv: Fixup compile error with !MMU

On Wed, 7 Dec 2022 04:11:12 -0500, [email protected] wrote:
> From: Guo Ren <[email protected]>
>
> Current nommu_virt_defconfig can't compile:
>
> In file included from
> arch/riscv/kernel/crash_core.c:3:
> arch/riscv/kernel/crash_core.c:
> In function 'arch_crash_save_vmcoreinfo':
> arch/riscv/kernel/crash_core.c:8:27:
> error: 'VA_BITS' undeclared (first use in this function)
> 8 | VMCOREINFO_NUMBER(VA_BITS);
> | ^~~~~~~
>
> [...]

Applied, thanks!

[1/1] riscv: Fixup compile error with !MMU
https://git.kernel.org/palmer/c/c528ef0888b7

Best regards,
--
Palmer Dabbelt <[email protected]>