2022-12-13 10:06:24

by Jiapeng Chong

Subject: [PATCH] drm/i915/gt: Modify mismatched function name

No functional modification involved.

drivers/gpu/drm/i915/gt/intel_engine_cs.c:1306: warning: expecting prototype for intel_engines_init_common(). Prototype was for engine_init_common() instead.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3442
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
index c33e0d72d670..dfcd3a91fbe7 100644
--- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
+++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
@@ -1292,7 +1292,7 @@ create_kernel_context(struct intel_engine_cs *engine)
}

/**
- * intel_engines_init_common - initialize cengine state which might require hw access
+ * engine_init_common - initialize cengine state which might require hw access
* @engine: Engine to initialize.
*
* Initializes @engine@ structure members shared between legacy and execlists
--
2.20.1.7.g153144c

2022-12-13 11:25:52

by Upadhyay, Tejas

Subject: RE: [Intel-gfx] [PATCH] drm/i915/gt: Modify mismatched function name

Indeed looks like miss. Thanks for the patch.

Reviewed-by: Tejas Upadhyay <[email protected]>

> -----Original Message-----
> From: Intel-gfx <[email protected]> On Behalf Of
> Jiapeng Chong
> Sent: Tuesday, December 13, 2022 3:22 PM
> To: [email protected]
> Cc: Jiapeng Chong <[email protected]>; intel-
> [email protected]; Abaci Robot <[email protected]>; linux-
> [email protected]; [email protected]; [email protected];
> Vivi, Rodrigo <[email protected]>; [email protected]
> Subject: [Intel-gfx] [PATCH] drm/i915/gt: Modify mismatched function name
>
> No functional modification involved.
>
> drivers/gpu/drm/i915/gt/intel_engine_cs.c:1306: warning: expecting
> prototype for intel_engines_init_common(). Prototype was for
> engine_init_common() instead.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3442
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> index c33e0d72d670..dfcd3a91fbe7 100644
> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> @@ -1292,7 +1292,7 @@ create_kernel_context(struct intel_engine_cs
> *engine) }
>
> /**
> - * intel_engines_init_common - initialize cengine state which might require
> hw access
> + * engine_init_common - initialize cengine state which might require hw
> + access
> * @engine: Engine to initialize.
> *
> * Initializes @engine@ structure members shared between legacy and
> execlists
> --
> 2.20.1.7.g153144c