2022-12-17 12:06:58

by Gou Hao

Subject: [PATCH] mm/slab: remove unused slab_early_init

From: Gou Hao <[email protected]>

'slab_early_init' was introduced by 'commit e0a42726794f
("[PATCH] mm/slab.c: fix early init assumption")', this
flag was used to prevented off-slab caches being created
so early during bootup.

The only user of 'slab_early_init' was removed in commit
'3217fd9bdf00 ("mm/slab: make criteria for off slab
determination robust and simple")'.

Signed-off-by: Gou Hao <[email protected]>
---
mm/slab.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/mm/slab.c b/mm/slab.c
index 7a269db050ee..ede1f29fd81c 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -220,7 +220,6 @@ static inline void fixup_objfreelist_debug(struct kmem_cache *cachep,
static inline void fixup_slab_list(struct kmem_cache *cachep,
struct kmem_cache_node *n, struct slab *slab,
void **list);
-static int slab_early_init = 1;

#define INDEX_NODE kmalloc_index(sizeof(struct kmem_cache_node))

@@ -1249,8 +1248,6 @@ void __init kmem_cache_init(void)
slab_state = PARTIAL_NODE;
setup_kmalloc_cache_index_table();

- slab_early_init = 0;
-
/* 5) Replace the bootstrap kmem_cache_node */
{
int nid;
--
2.20.1

2022-12-18 02:39:11

by Hyeonggon Yoo

Subject: Re: [PATCH] mm/slab: remove unused slab_early_init

On Sat, Dec 17, 2022 at 07:30:45PM +0800, [email protected] wrote:
> From: Gou Hao <[email protected]>
>
> 'slab_early_init' was introduced by 'commit e0a42726794f
> ("[PATCH] mm/slab.c: fix early init assumption")', this
> flag was used to prevented off-slab caches being created

s/prevented/prevent

> so early during bootup.
>
> The only user of 'slab_early_init' was removed in commit
> '3217fd9bdf00 ("mm/slab: make criteria for off slab
> determination robust and simple")'.
>
> Signed-off-by: Gou Hao <[email protected]>
> ---
> mm/slab.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/slab.c b/mm/slab.c
> index 7a269db050ee..ede1f29fd81c 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -220,7 +220,6 @@ static inline void fixup_objfreelist_debug(struct kmem_cache *cachep,
> static inline void fixup_slab_list(struct kmem_cache *cachep,
> struct kmem_cache_node *n, struct slab *slab,
> void **list);
> -static int slab_early_init = 1;
>
> #define INDEX_NODE kmalloc_index(sizeof(struct kmem_cache_node))
>
> @@ -1249,8 +1248,6 @@ void __init kmem_cache_init(void)
> slab_state = PARTIAL_NODE;
> setup_kmalloc_cache_index_table();
>
> - slab_early_init = 0;
> -
> /* 5) Replace the bootstrap kmem_cache_node */
> {
> int nid;
> --
> 2.20.1

Nice cleanup, thanks!

Acked-by: Hyeonggon Yoo <[email protected]>

--
Thanks,
Hyeonggon

2022-12-18 13:11:18

by Gou Hao

Subject: Re: [PATCH] mm/slab: remove unused slab_early_init

Thanks for your review, i will fix it in next version patch. :)


Thanks,
Gou Hao
>
> > so early during bootup.
> >
> > The only user of 'slab_early_init' was removed in commit
> > '3217fd9bdf00 ("mm/slab: make criteria for off slab
> > determination robust and simple")'.
> >
> > Signed-off-by: Gou Hao <[email protected]>
> > ---
> > mm/slab.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/mm/slab.c b/mm/slab.c
> > index 7a269db050ee..ede1f29fd81c 100644
> > --- a/mm/slab.c
> > +++ b/mm/slab.c
> > @@ -220,7 +220,6 @@ static inline void fixup_objfreelist_debug(struct kmem_cache *cachep,
> > static inline void fixup_slab_list(struct kmem_cache *cachep,
> > struct kmem_cache_node *n, struct slab *slab,
> > void **list);
> > -static int slab_early_init = 1;
> >
> > #define INDEX_NODE kmalloc_index(sizeof(struct kmem_cache_node))
> >
> > @@ -1249,8 +1248,6 @@ void __init kmem_cache_init(void)
> > slab_state = PARTIAL_NODE;
> > setup_kmalloc_cache_index_table();
> >
> > - slab_early_init = 0;
> > -
> > /* 5) Replace the bootstrap kmem_cache_node */
> > {
> > int nid;
> > --
> > 2.20.1
>
> Nice cleanup, thanks!
>
> Acked-by: Hyeonggon Yoo <[email protected]>