On Fri, Dec 30, 2022 at 12:55:07PM -0500, Tom Rix wrote:
> The clang build reports this error
> error: unknown warning option '-Wmaybe-uninitialized'; did you mean '-Wuninitialized'? [-Werror,-Wunknown-warning-option]
> make[3]: *** [scripts/Makefile.build:252: fs/btrfs/super.o] Error 1
>
> -Wmaybe-uninitialized is a gcc only flag. Move to setting with cc-option.
>
> Fixes: 1b19c4c249a1 ("btrfs: turn on -Wmaybe-uninitialized")
> Signed-off-by: Tom Rix <[email protected]>
Thanks for the patch! Looks like I forgot to double back to this...
https://lore.kernel.org/[email protected]/
Reviewed-by: Nathan Chancellor <[email protected]>
> ---
> fs/btrfs/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/Makefile b/fs/btrfs/Makefile
> index eca995abccdf..460eced3f5bd 100644
> --- a/fs/btrfs/Makefile
> +++ b/fs/btrfs/Makefile
> @@ -7,12 +7,12 @@ subdir-ccflags-y += -Wmissing-format-attribute
> subdir-ccflags-y += -Wmissing-prototypes
> subdir-ccflags-y += -Wold-style-definition
> subdir-ccflags-y += -Wmissing-include-dirs
> -subdir-ccflags-y += -Wmaybe-uninitialized
> condflags := \
> $(call cc-option, -Wunused-but-set-variable) \
> $(call cc-option, -Wunused-const-variable) \
> $(call cc-option, -Wpacked-not-aligned) \
> - $(call cc-option, -Wstringop-truncation)
> + $(call cc-option, -Wstringop-truncation) \
> + $(call cc-option, -Wmaybe-uninitialized)
> subdir-ccflags-y += $(condflags)
> # The following turn off the warnings enabled by -Wextra
> subdir-ccflags-y += -Wno-missing-field-initializers
> --
> 2.27.0
>