2023-01-16 17:55:29

by Johan Hovold

[permalink] [raw]
Subject: [PATCH RESEND] dt-bindings: ufs: qcom: allow 'dma-coherent' property

UFS controllers may be cache coherent and must be marked as such in the
devicetree to avoid data corruption.

This is specifically needed on recent Qualcomm platforms like SC8280XP.

Reviewed-by: Rob Herring <[email protected]>
Reviewed-by: Bjorn Andersson <[email protected]>
Signed-off-by: Johan Hovold <[email protected]>
---

James and Martin,

I'm resending as reminder in case you missed the first submission which
included an arm64 dts update and also did not have you on CC as I was
following scripts/get_maintainer.pl too literally:

https://lore.kernel.org/all/[email protected]/

I've added Rob and Bjorn's Reviewed-by tags from the above thread.

Could you take this one through the scsi tree?

Johan


Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index f2d6298d926c..1f1d286749c0 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -44,6 +44,8 @@ properties:
minItems: 8
maxItems: 11

+ dma-coherent: true
+
interconnects:
minItems: 2
maxItems: 2
--
2.38.2


2023-01-19 00:41:46

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH RESEND] dt-bindings: ufs: qcom: allow 'dma-coherent' property


Johan,

> UFS controllers may be cache coherent and must be marked as such in the
> devicetree to avoid data corruption.

Applied to 6.3/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2023-01-27 03:23:34

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH RESEND] dt-bindings: ufs: qcom: allow 'dma-coherent' property

On Mon, 16 Jan 2023 17:42:36 +0100, Johan Hovold wrote:

> UFS controllers may be cache coherent and must be marked as such in the
> devicetree to avoid data corruption.
>
> This is specifically needed on recent Qualcomm platforms like SC8280XP.
>
>

Applied to 6.3/scsi-queue, thanks!

[1/1] dt-bindings: ufs: qcom: allow 'dma-coherent' property
https://git.kernel.org/mkp/scsi/c/85e182b48a33

--
Martin K. Petersen Oracle Linux Engineering