2023-01-17 17:52:53

by Arnd Bergmann

Subject: [PATCH] clk: qcom: rpmh: remove duplicate IPA clock reference

From: Arnd Bergmann <[email protected]>

One of the ones that were recently added was already there:

drivers/clk/qcom/clk-rpmh.c:578:35: error: initialized field overwritten [-Werror=override-init]
578 | [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,

Fixes: aa055bf158cd ("clk: qcom: rpmh: define IPA clocks where required")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/clk/qcom/clk-rpmh.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
index 393b83f6020e..45ee370f3307 100644
--- a/drivers/clk/qcom/clk-rpmh.c
+++ b/drivers/clk/qcom/clk-rpmh.c
@@ -575,7 +575,6 @@ static struct clk_hw *sc8280xp_rpmh_clocks[] = {
[RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
[RPMH_PKA_CLK] = &clk_rpmh_pka.hw,
[RPMH_HWKM_CLK] = &clk_rpmh_hwkm.hw,
- [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
};

static const struct clk_rpmh_desc clk_rpmh_sc8280xp = {
--
2.39.0

2023-01-17 20:45:27

by Bjorn Andersson

Subject: Re: [PATCH] clk: qcom: rpmh: remove duplicate IPA clock reference

On Tue, 17 Jan 2023 18:02:09 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> One of the ones that were recently added was already there:
>
> drivers/clk/qcom/clk-rpmh.c:578:35: error: initialized field overwritten [-Werror=override-init]
> 578 | [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
>
> [...]

Applied, thanks!

[1/1] clk: qcom: rpmh: remove duplicate IPA clock reference
commit: 19aeacf505a08ae8fc1e087f9d85b7caf29b09b4

Best regards,
--
Bjorn Andersson <[email protected]>

2023-01-18 14:29:21

by Konrad Dybcio

Subject: Re: [PATCH] clk: qcom: rpmh: remove duplicate IPA clock reference

On 17.01.2023 18:02, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> One of the ones that were recently added was already there:
>
> drivers/clk/qcom/clk-rpmh.c:578:35: error: initialized field overwritten [-Werror=override-init]
> 578 | [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
>
> Fixes: aa055bf158cd ("clk: qcom: rpmh: define IPA clocks where required")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> drivers/clk/qcom/clk-rpmh.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> index 393b83f6020e..45ee370f3307 100644
> --- a/drivers/clk/qcom/clk-rpmh.c
> +++ b/drivers/clk/qcom/clk-rpmh.c
> @@ -575,7 +575,6 @@ static struct clk_hw *sc8280xp_rpmh_clocks[] = {
> [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
> [RPMH_PKA_CLK] = &clk_rpmh_pka.hw,
> [RPMH_HWKM_CLK] = &clk_rpmh_hwkm.hw,
> - [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
> };
>
> static const struct clk_rpmh_desc clk_rpmh_sc8280xp = {