2023-01-19 14:28:59

by Gal Pressman

Subject: .clang-format vs. checkpatch: Lines should not end with a '('

Hey,

I use clang-format to automatically format my patches, but checkpatch
likes to complain about:
CHECK: Lines should not end with a '('

I thought maybe adding a 'AllowAllArgumentsOnNextLine: false' would make
it happy but that didn't really seem to work.

Anyone else a bit annoyed by this? Maybe there's another solution I'm
failing to see?

Thanks

2023-01-19 18:05:36

by David Laight

Subject: RE: .clang-format vs. checkpatch: Lines should not end with a '('

From: Gal Pressman
> Sent: 19 January 2023 14:17
>
> I use clang-format to automatically format my patches, but checkpatch
> likes to complain about:
> CHECK: Lines should not end with a '('
>
> I thought maybe adding a 'AllowAllArgumentsOnNextLine: false' would make
> it happy but that didn't really seem to work.
>
> Anyone else a bit annoyed by this? Maybe there's another solution I'm
> failing to see?

Reduce the length of very long names and refactor the code to
remove the massive number of indents and you won't have a problem :-)

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)

2023-01-22 07:30:59

by Gal Pressman

Subject: Re: .clang-format vs. checkpatch: Lines should not end with a '('

On 19/01/2023 18:57, David Laight wrote:
> From: Gal Pressman
>> Sent: 19 January 2023 14:17
>>
>> I use clang-format to automatically format my patches, but checkpatch
>> likes to complain about:
>> CHECK: Lines should not end with a '('
>>
>> I thought maybe adding a 'AllowAllArgumentsOnNextLine: false' would make
>> it happy but that didn't really seem to work.
>>
>> Anyone else a bit annoyed by this? Maybe there's another solution I'm
>> failing to see?
>
> Reduce the length of very long names and refactor the code to
> remove the massive number of indents and you won't have a problem :-)

That's one way to do it :), thanks for the response!