2023-02-01 04:04:41

by Ratheesh Kannoth

Subject: [net-next PATCH v1] octeontx2-af: Removed unnecessary debug messages.

From: Sunil Goutham <[email protected]>

NPC exact match feature is supported only on one silicon
variant, removed debug messages which print that this
feature is not available on all other silicon variants.

Signed-off-by: Sunil Goutham <[email protected]>
Signed-off-by: Ratheesh Kannoth <[email protected]>
---
.../marvell/octeontx2/af/rvu_npc_hash.c | 18 ++++--------------
1 file changed, 4 insertions(+), 14 deletions(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
index f69102d20c90..20ebb9c95c73 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c
@@ -200,10 +200,8 @@ void npc_config_secret_key(struct rvu *rvu, int blkaddr)
struct rvu_hwinfo *hw = rvu->hw;
u8 intf;

- if (!hwcap->npc_hash_extract) {
- dev_info(rvu->dev, "HW does not support secret key configuration\n");
+ if (!hwcap->npc_hash_extract)
return;
- }

for (intf = 0; intf < hw->npc_intfs; intf++) {
rvu_write64(rvu, blkaddr, NPC_AF_INTFX_SECRET_KEY0(intf),
@@ -221,10 +219,8 @@ void npc_program_mkex_hash(struct rvu *rvu, int blkaddr)
struct rvu_hwinfo *hw = rvu->hw;
u8 intf;

- if (!hwcap->npc_hash_extract) {
- dev_dbg(rvu->dev, "Field hash extract feature is not supported\n");
+ if (!hwcap->npc_hash_extract)
return;
- }

for (intf = 0; intf < hw->npc_intfs; intf++) {
npc_program_mkex_hash_rx(rvu, blkaddr, intf);
@@ -1853,19 +1849,13 @@ int rvu_npc_exact_init(struct rvu *rvu)

/* Check exact match feature is supported */
npc_const3 = rvu_read64(rvu, blkaddr, NPC_AF_CONST3);
- if (!(npc_const3 & BIT_ULL(62))) {
- dev_info(rvu->dev, "%s: No support for exact match support\n",
- __func__);
+ if (!(npc_const3 & BIT_ULL(62)))
return 0;
- }

/* Check if kex profile has enabled EXACT match nibble */
cfg = rvu_read64(rvu, blkaddr, NPC_AF_INTFX_KEX_CFG(NIX_INTF_RX));
- if (!(cfg & NPC_EXACT_NIBBLE_HIT)) {
- dev_info(rvu->dev, "%s: NPC exact match nibble not enabled in KEX profile\n",
- __func__);
+ if (!(cfg & NPC_EXACT_NIBBLE_HIT))
return 0;
- }

/* Set capability to true */
rvu->hw->cap.npc_exact_match_enabled = true;
--
2.25.1

2023-02-01 10:15:15

by Leon Romanovsky

Subject: Re: [net-next PATCH v1] octeontx2-af: Removed unnecessary debug messages.

On Wed, Feb 01, 2023 at 09:33:01AM +0530, Ratheesh Kannoth wrote:
> From: Sunil Goutham <[email protected]>
>
> NPC exact match feature is supported only on one silicon
> variant, removed debug messages which print that this
> feature is not available on all other silicon variants.
>
> Signed-off-by: Sunil Goutham <[email protected]>
> Signed-off-by: Ratheesh Kannoth <[email protected]>
> ---
> .../marvell/octeontx2/af/rvu_npc_hash.c | 18 ++++--------------
> 1 file changed, 4 insertions(+), 14 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <[email protected]>

2023-02-02 06:20:55

by patchwork-bot+netdevbpf

Subject: Re: [net-next PATCH v1] octeontx2-af: Removed unnecessary debug messages.

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Wed, 1 Feb 2023 09:33:01 +0530 you wrote:
> From: Sunil Goutham <[email protected]>
>
> NPC exact match feature is supported only on one silicon
> variant, removed debug messages which print that this
> feature is not available on all other silicon variants.
>
> Signed-off-by: Sunil Goutham <[email protected]>
> Signed-off-by: Ratheesh Kannoth <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next,v1] octeontx2-af: Removed unnecessary debug messages.
https://git.kernel.org/netdev/net-next/c/609aa68d6096

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html