2023-02-03 18:31:36

by Elliot Berman

[permalink] [raw]
Subject: [PATCH] MAINTAINERS: Add include/linux/qcom* to ARM/QUALCOMM

ARM/QUALCOMM support currently includes include/linux/*/qcom* but is
missing a few Qualcomm headers directly in include/linux/.

This effectively adds following headers directly under ARM/QUALCOMM.
- include/linux/qcom-geni-se.h
- include/linux/qcom_scm.h

Signed-off-by: Elliot Berman <[email protected]>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index f2c3d471fe8f..752cddd73bf8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2724,6 +2724,7 @@ F: drivers/spi/spi-qup.c
F: drivers/tty/serial/msm_serial.c
F: drivers/usb/dwc3/dwc3-qcom.c
F: include/dt-bindings/*/qcom*
+F: include/linux/qcom*
F: include/linux/*/qcom*
F: include/linux/soc/qcom/


base-commit: 3866989ec2c319341e2cf69ec6116269b634a271
--
2.39.1



2023-02-03 19:25:20

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: Add include/linux/qcom* to ARM/QUALCOMM

On Fri, Feb 03, 2023 at 10:31:14AM -0800, Elliot Berman wrote:
> ARM/QUALCOMM support currently includes include/linux/*/qcom* but is
> missing a few Qualcomm headers directly in include/linux/.
>
> This effectively adds following headers directly under ARM/QUALCOMM.
> - include/linux/qcom-geni-se.h
> - include/linux/qcom_scm.h
>

Seems odd to have these lone files here...

Would you be willing to push these two files into
include/linux/firmware/qcom/ and include/linux/soc/qcom/ instead?

Regards,
Bjorn

> Signed-off-by: Elliot Berman <[email protected]>
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f2c3d471fe8f..752cddd73bf8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2724,6 +2724,7 @@ F: drivers/spi/spi-qup.c
> F: drivers/tty/serial/msm_serial.c
> F: drivers/usb/dwc3/dwc3-qcom.c
> F: include/dt-bindings/*/qcom*
> +F: include/linux/qcom*
> F: include/linux/*/qcom*
> F: include/linux/soc/qcom/
>
>
> base-commit: 3866989ec2c319341e2cf69ec6116269b634a271
> --
> 2.39.1
>

2023-02-03 21:10:57

by Elliot Berman

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: Add include/linux/qcom* to ARM/QUALCOMM



On 2/3/2023 11:27 AM, Bjorn Andersson wrote:
> On Fri, Feb 03, 2023 at 10:31:14AM -0800, Elliot Berman wrote:
>> ARM/QUALCOMM support currently includes include/linux/*/qcom* but is
>> missing a few Qualcomm headers directly in include/linux/.
>>
>> This effectively adds following headers directly under ARM/QUALCOMM.
>> - include/linux/qcom-geni-se.h
>> - include/linux/qcom_scm.h
>>
>
> Seems odd to have these lone files here...
>
> Would you be willing to push these two files into
> include/linux/firmware/qcom/ and include/linux/soc/qcom/ instead?
>

Sure, this is also good approach to me.

qcom-geni-se.h:
https://lore.kernel.org/all/[email protected]/

qcom_scm.h:
https://lore.kernel.org/all/[email protected]/

Thanks,
Elliot