2023-02-15 01:05:26

by Thomas Weißschuh

Subject: [PATCH] drm/nouveau/led: explicitly include linux/leds.h

Instead of relying on an accidental, transitive inclusion of linux/leds.h
use it directly.

Also drop the forware definition of struct led_classdev that is now
provided by linux/leds.h.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
drivers/gpu/drm/nouveau/nouveau_led.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_led.h b/drivers/gpu/drm/nouveau/nouveau_led.h
index 21a5775028cc..bc9bc7208da3 100644
--- a/drivers/gpu/drm/nouveau/nouveau_led.h
+++ b/drivers/gpu/drm/nouveau/nouveau_led.h
@@ -27,7 +27,7 @@

#include "nouveau_drv.h"

-struct led_classdev;
+#include <linux/leds.h>

struct nouveau_led {
struct drm_device *dev;

---
base-commit: e1c04510f521e853019afeca2a5991a5ef8d6a5b
change-id: 20230215-power_supply-leds-nouveau-ff4995ba0794

Best regards,
--
Thomas Weißschuh <[email protected]>

2023-02-15 23:02:25

by Lyude Paul

Subject: Re: [PATCH] drm/nouveau/led: explicitly include linux/leds.h

Reviewed-by: Lyude Paul <[email protected]>

Will push to drm-misc-next in a moment

On Wed, 2023-02-15 at 01:04 +0000, Thomas Weißschuh wrote:
> Instead of relying on an accidental, transitive inclusion of linux/leds.h
> use it directly.
>
> Also drop the forware definition of struct led_classdev that is now
> provided by linux/leds.h.
>
> Signed-off-by: Thomas Weißschuh <[email protected]>
> ---
> drivers/gpu/drm/nouveau/nouveau_led.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_led.h b/drivers/gpu/drm/nouveau/nouveau_led.h
> index 21a5775028cc..bc9bc7208da3 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_led.h
> +++ b/drivers/gpu/drm/nouveau/nouveau_led.h
> @@ -27,7 +27,7 @@
>
> #include "nouveau_drv.h"
>
> -struct led_classdev;
> +#include <linux/leds.h>
>
> struct nouveau_led {
> struct drm_device *dev;
>
> ---
> base-commit: e1c04510f521e853019afeca2a5991a5ef8d6a5b
> change-id: 20230215-power_supply-leds-nouveau-ff4995ba0794
>
> Best regards,

--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat