2023-02-18 12:39:36

by Lorenz Brun

[permalink] [raw]
Subject: [PATCH] mt76: mt7915: expose device tree match table

On MT7986 the WiFi driver currently does not get automatically loaded,
requiring manual modprobing because the device tree compatibles are not
exported into metadata.

Add the missing MODULE_DEVICE_TABLE macro to fix this.

Fixes: 99ad32a4ca3a2 ("mt76: mt7915: add support for MT7986")
Signed-off-by: Lorenz Brun <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7915/soc.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/soc.c b/drivers/net/wireless/mediatek/mt76/mt7915/soc.c
index 2ac0a0f2859cb..32c137066e7f7 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/soc.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/soc.c
@@ -1239,6 +1239,8 @@ static const struct of_device_id mt7986_wmac_of_match[] = {
{},
};

+MODULE_DEVICE_TABLE(of, mt7986_wmac_of_match);
+
struct platform_driver mt7986_wmac_driver = {
.driver = {
.name = "mt7986-wmac",
--
2.39.1



Subject: Re: [PATCH] mt76: mt7915: expose device tree match table

Il 18/02/23 12:29, Lorenz Brun ha scritto:
> On MT7986 the WiFi driver currently does not get automatically loaded,
> requiring manual modprobing because the device tree compatibles are not
> exported into metadata.
>
> Add the missing MODULE_DEVICE_TABLE macro to fix this.
>
> Fixes: 99ad32a4ca3a2 ("mt76: mt7915: add support for MT7986")
> Signed-off-by: Lorenz Brun <[email protected]>

I don't think that this commit needs a Fixes tag, as you're only adding (good)
auto-load commodity.

Regardless of that:

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>