2023-02-21 03:52:10

by Li zeming

Subject: [PATCH] tty: tty_ldisc: Remove the ret variable

The int variable ret does not receive the return value in this function.
It should be removed and returned 0 directly.

Signed-off-by: Li zeming <[email protected]>
---
drivers/tty/tty_ldisc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c
index e758f44729e7..3f68e213df1f 100644
--- a/drivers/tty/tty_ldisc.c
+++ b/drivers/tty/tty_ldisc.c
@@ -58,7 +58,6 @@ static struct tty_ldisc_ops *tty_ldiscs[NR_LDISCS];
int tty_register_ldisc(struct tty_ldisc_ops *new_ldisc)
{
unsigned long flags;
- int ret = 0;

if (new_ldisc->num < N_TTY || new_ldisc->num >= NR_LDISCS)
return -EINVAL;
@@ -67,7 +66,7 @@ int tty_register_ldisc(struct tty_ldisc_ops *new_ldisc)
tty_ldiscs[new_ldisc->num] = new_ldisc;
raw_spin_unlock_irqrestore(&tty_ldiscs_lock, flags);

- return ret;
+ return 0;
}
EXPORT_SYMBOL(tty_register_ldisc);

--
2.18.2

2023-02-22 07:30:41

by Jiri Slaby

Subject: Re: [PATCH] tty: tty_ldisc: Remove the ret variable

On 22. 02. 23, 21:23, Li zeming wrote:
> The int variable ret does not receive the return value in this function.
> It should be removed and returned 0 directly.
>
> Signed-off-by: Li zeming <[email protected]>

Reviewed-by: Jiri Slaby <[email protected]>

--
js
suse labs