2023-02-22 00:46:23

by Sangmoon Kim

Subject: [PATCH] docs: kbuild: remove description of KBUILD_LDS_MODULE

Commit 596b0474d3d9 ("kbuild: preprocess module linker script")
has removed KBUILD_LDS_MODULE variable.

The KBUILD_LDS_MODULE variable is no longer available, so this patch
removes it from the document.

Signed-off-by: Sangmoon Kim <[email protected]>
---
Documentation/kbuild/makefiles.rst | 5 -----
1 file changed, 5 deletions(-)

diff --git a/Documentation/kbuild/makefiles.rst b/Documentation/kbuild/makefiles.rst
index 38bc74eaa547..468e7830c1c3 100644
--- a/Documentation/kbuild/makefiles.rst
+++ b/Documentation/kbuild/makefiles.rst
@@ -1250,11 +1250,6 @@ When kbuild executes, the following steps are followed (roughly):

The linker script with full path. Assigned by the top-level Makefile.

- KBUILD_LDS_MODULE
-
- The module linker script with full path. Assigned by the top-level
- Makefile and additionally by the arch Makefile.
-
KBUILD_VMLINUX_OBJS

All object files for vmlinux. They are linked to vmlinux in the same
--
2.17.1

2023-02-22 07:34:03

by Bagas Sanjaya

Subject: Re: [PATCH] docs: kbuild: remove description of KBUILD_LDS_MODULE

On 2/22/23 07:45, Sangmoon Kim wrote:
> Commit 596b0474d3d9 ("kbuild: preprocess module linker script")
> has removed KBUILD_LDS_MODULE variable.
>
> The KBUILD_LDS_MODULE variable is no longer available, so this patch
> removes it from the document.
>

What about "Commit <commit> removes KBUILD_LDS_MODULE, yet the variable
is still mentioned in kbuild documentation. Remove the reference to
the now-nonexistent variable."?

--
An old man doll... just what I always wanted! - Clara

2023-02-22 10:49:06

by Sangmoon Kim

Subject: [PATCH v2] docs: kbuild: remove description of KBUILD_LDS_MODULE

Commit 596b0474d3d9 ("kbuild: preprocess module linker script")
removes KBUILD_LDS_MODULE, yet the variable is still mentioned in
kbuild documentation. Remove the reference to the now-nonexistent
variable.

Signed-off-by: Sangmoon Kim <[email protected]>
---
Thank you for your review.

Changes in v2:
- Update the commit message.

Documentation/kbuild/makefiles.rst | 5 -----
1 file changed, 5 deletions(-)

diff --git a/Documentation/kbuild/makefiles.rst b/Documentation/kbuild/makefiles.rst
index 38bc74eaa547..468e7830c1c3 100644
--- a/Documentation/kbuild/makefiles.rst
+++ b/Documentation/kbuild/makefiles.rst
@@ -1250,11 +1250,6 @@ When kbuild executes, the following steps are followed (roughly):

The linker script with full path. Assigned by the top-level Makefile.

- KBUILD_LDS_MODULE
-
- The module linker script with full path. Assigned by the top-level
- Makefile and additionally by the arch Makefile.
-
KBUILD_VMLINUX_OBJS

All object files for vmlinux. They are linked to vmlinux in the same
--
2.17.1

2023-02-22 16:21:12

by Nathan Chancellor

Subject: Re: [PATCH v2] docs: kbuild: remove description of KBUILD_LDS_MODULE

On Wed, Feb 22, 2023 at 07:47:19PM +0900, Sangmoon Kim wrote:
> Commit 596b0474d3d9 ("kbuild: preprocess module linker script")
> removes KBUILD_LDS_MODULE, yet the variable is still mentioned in
> kbuild documentation. Remove the reference to the now-nonexistent
> variable.
>
> Signed-off-by: Sangmoon Kim <[email protected]>

Reviewed-by: Nathan Chancellor <[email protected]>

> ---
> Thank you for your review.
>
> Changes in v2:
> - Update the commit message.
>
> Documentation/kbuild/makefiles.rst | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/Documentation/kbuild/makefiles.rst b/Documentation/kbuild/makefiles.rst
> index 38bc74eaa547..468e7830c1c3 100644
> --- a/Documentation/kbuild/makefiles.rst
> +++ b/Documentation/kbuild/makefiles.rst
> @@ -1250,11 +1250,6 @@ When kbuild executes, the following steps are followed (roughly):
>
> The linker script with full path. Assigned by the top-level Makefile.
>
> - KBUILD_LDS_MODULE
> -
> - The module linker script with full path. Assigned by the top-level
> - Makefile and additionally by the arch Makefile.
> -
> KBUILD_VMLINUX_OBJS
>
> All object files for vmlinux. They are linked to vmlinux in the same
> --
> 2.17.1
>

2023-02-25 08:42:03

by Masahiro Yamada

Subject: Re: [PATCH v2] docs: kbuild: remove description of KBUILD_LDS_MODULE

On Wed, Feb 22, 2023 at 7:49 PM Sangmoon Kim <[email protected]> wrote:
>
> Commit 596b0474d3d9 ("kbuild: preprocess module linker script")
> removes KBUILD_LDS_MODULE, yet the variable is still mentioned in
> kbuild documentation. Remove the reference to the now-nonexistent
> variable.
>
> Signed-off-by: Sangmoon Kim <[email protected]>
> ---
> Thank you for your review.
>
> Changes in v2:
> - Update the commit message.
>
> Documentation/kbuild/makefiles.rst | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/Documentation/kbuild/makefiles.rst b/Documentation/kbuild/makefiles.rst
> index 38bc74eaa547..468e7830c1c3 100644
> --- a/Documentation/kbuild/makefiles.rst
> +++ b/Documentation/kbuild/makefiles.rst
> @@ -1250,11 +1250,6 @@ When kbuild executes, the following steps are followed (roughly):
>
> The linker script with full path. Assigned by the top-level Makefile.
>
> - KBUILD_LDS_MODULE
> -
> - The module linker script with full path. Assigned by the top-level
> - Makefile and additionally by the arch Makefile.
> -
> KBUILD_VMLINUX_OBJS
>
> All object files for vmlinux. They are linked to vmlinux in the same
> --
> 2.17.1
>

Applied to linux-kbuild.
Thanks.


--
Best Regards
Masahiro Yamada