2023-03-17 06:22:01

by Jiapeng Chong

Subject: [PATCH] clk: qcom: Remove the unused variables

Variable gpucc_parent_map_2 and gpucc_parent_data_2 is not effectively
used, so delete it.

drivers/clk/qcom/gpucc-sm6375.c:145:37: warning: unused variable 'gpucc_parent_data_2'.
drivers/clk/qcom/gpucc-sm6375.c:139:32: warning: unused variable 'gpucc_parent_map_2'.

Reported-by: Abaci Robot <[email protected]>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4555
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/clk/qcom/gpucc-sm6375.c | 12 ------------
1 file changed, 12 deletions(-)

diff --git a/drivers/clk/qcom/gpucc-sm6375.c b/drivers/clk/qcom/gpucc-sm6375.c
index eb9ffa956950..d8f4c4b59f1b 100644
--- a/drivers/clk/qcom/gpucc-sm6375.c
+++ b/drivers/clk/qcom/gpucc-sm6375.c
@@ -136,18 +136,6 @@ static const struct clk_parent_data gpucc_parent_data_1[] = {
{ .index = DT_GCC_GPU_GPLL0_CLK_SRC },
};

-static const struct parent_map gpucc_parent_map_2[] = {
- { P_BI_TCXO, 0 },
- { P_GCC_GPU_GPLL0_CLK_SRC, 5 },
- { P_GCC_GPU_GPLL0_DIV_CLK_SRC, 6 },
-};
-
-static const struct clk_parent_data gpucc_parent_data_2[] = {
- { .index = P_BI_TCXO },
- { .index = DT_GCC_GPU_GPLL0_CLK_SRC },
- { .index = DT_GCC_GPU_GPLL0_DIV_CLK_SRC },
-};
-
static const struct freq_tbl ftbl_gpucc_gmu_clk_src[] = {
F(200000000, P_GCC_GPU_GPLL0_DIV_CLK_SRC, 1.5, 0, 0),
{ }
--
2.20.1.7.g153144c

2023-03-17 12:14:04

by Konrad Dybcio

Subject: Re: [PATCH] clk: qcom: Remove the unused variables

On 17.03.2023 07:20, Jiapeng Chong wrote:
> Variable gpucc_parent_map_2 and gpucc_parent_data_2 is not effectively
> used, so delete it.
>
> drivers/clk/qcom/gpucc-sm6375.c:145:37: warning: unused variable 'gpucc_parent_data_2'.
> drivers/clk/qcom/gpucc-sm6375.c:139:32: warning: unused variable 'gpucc_parent_map_2'.
>
> Reported-by: Abaci Robot <[email protected]>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4555
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
This is fixed already

https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=54ed70b57623e18f6c18f510cbe1e741bca89f34

Konrad
> drivers/clk/qcom/gpucc-sm6375.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/clk/qcom/gpucc-sm6375.c b/drivers/clk/qcom/gpucc-sm6375.c
> index eb9ffa956950..d8f4c4b59f1b 100644
> --- a/drivers/clk/qcom/gpucc-sm6375.c
> +++ b/drivers/clk/qcom/gpucc-sm6375.c
> @@ -136,18 +136,6 @@ static const struct clk_parent_data gpucc_parent_data_1[] = {
> { .index = DT_GCC_GPU_GPLL0_CLK_SRC },
> };
>
> -static const struct parent_map gpucc_parent_map_2[] = {
> - { P_BI_TCXO, 0 },
> - { P_GCC_GPU_GPLL0_CLK_SRC, 5 },
> - { P_GCC_GPU_GPLL0_DIV_CLK_SRC, 6 },
> -};
> -
> -static const struct clk_parent_data gpucc_parent_data_2[] = {
> - { .index = P_BI_TCXO },
> - { .index = DT_GCC_GPU_GPLL0_CLK_SRC },
> - { .index = DT_GCC_GPU_GPLL0_DIV_CLK_SRC },
> -};
> -
> static const struct freq_tbl ftbl_gpucc_gmu_clk_src[] = {
> F(200000000, P_GCC_GPU_GPLL0_DIV_CLK_SRC, 1.5, 0, 0),
> { }