2023-03-24 19:08:30

by Tom Rix

Subject: [PATCH] bcma: remove unused mips_read32 function

clang with W=1 reports
drivers/bcma/driver_mips.c:49:19: error: unused function
'mips_read32' [-Werror,-Wunused-function]
static inline u32 mips_read32(struct bcma_drv_mips *mcore,
^
This function is not used so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/bcma/driver_mips.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/bcma/driver_mips.c b/drivers/bcma/driver_mips.c
index 4f01e6b17bb9..9be0806eb033 100644
--- a/drivers/bcma/driver_mips.c
+++ b/drivers/bcma/driver_mips.c
@@ -46,12 +46,6 @@ static inline bool bcma_core_mips_bcm5357b0_quirk(struct bcma_device *dev)
dev->id.id == BCMA_CORE_USB20_HOST;
}

-static inline u32 mips_read32(struct bcma_drv_mips *mcore,
- u16 offset)
-{
- return bcma_read32(mcore->core, offset);
-}
-
static u32 bcma_core_mips_irqflag(struct bcma_device *dev)
{
u32 flag;
--
2.27.0

2023-03-26 10:42:29

by Simon Horman

Subject: Re: [PATCH] bcma: remove unused mips_read32 function

On Fri, Mar 24, 2023 at 03:06:47PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/bcma/driver_mips.c:49:19: error: unused function
> 'mips_read32' [-Werror,-Wunused-function]
> static inline u32 mips_read32(struct bcma_drv_mips *mcore,
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix <[email protected]>

Reviewed-by: Simon Horman <[email protected]>